PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fix Hotspot & tethering settings crash" into udc-d1-dev

Browse Source
This commit is contained in:
Treehugger Robot
2023-06-14 12:00:21 +00:00
committed by Android (Google) Code Review
parent 90cf6e8a3c 6a20a8c5df
commit 3494d09de4
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/com/android/settings/network/tether/TetherSettings.java
View File

@@ -148,12 +148,13 @@ public class TetherSettings extends RestrictedSettingsFragment
@Override @Override
public void onCreate(Bundle icicle) { public void onCreate(Bundle icicle) {
super.onCreate(icicle); super.onCreate(icicle);
// Even when the UI is restricted, addPreferencesFromResource cannot be omitted.
addPreferencesFromResource(R.xml.tether_prefs);
setIfOnlyAvailableForAdmins(true); setIfOnlyAvailableForAdmins(true);
if (isUiRestricted()) { if (isUiRestricted()) {
return; return;
} }
addPreferencesFromResource(R.xml.tether_prefs);
mContext = getContext(); mContext = getContext();
mDataSaverBackend = new DataSaverBackend(mContext); mDataSaverBackend = new DataSaverBackend(mContext);
mDataSaverEnabled = mDataSaverBackend.isDataSaverEnabled(); mDataSaverEnabled = mDataSaverBackend.isDataSaverEnabled();

2
tests/robotests/src/com/android/settings/network/tether/TetherSettingsTest.java
View File

@@ -131,10 +131,12 @@ public class TetherSettingsTest {
@Test @Test
@Config(shadows = ShadowRestrictedSettingsFragment.class) @Config(shadows = ShadowRestrictedSettingsFragment.class)
public void onCreate_isUiRestricted_doNotSetupViewModel() { public void onCreate_isUiRestricted_doNotSetupViewModel() {
doNothing().when(mTetherSettings).addPreferencesFromResource(anyInt());
when(mTetherSettings.isUiRestricted()).thenReturn(true); when(mTetherSettings.isUiRestricted()).thenReturn(true);
mTetherSettings.onCreate(null); mTetherSettings.onCreate(null);
verify(mTetherSettings).addPreferencesFromResource(anyInt());
verify(mTetherSettings, never()).setupViewModel(); verify(mTetherSettings, never()).setupViewModel();
} }