Merge "Dynamically showing "driving mode"" into pi-dev

This commit is contained in:
TreeHugger Robot
2018-05-22 02:48:34 +00:00
committed by Android (Google) Code Review
2 changed files with 35 additions and 10 deletions

View File

@@ -16,6 +16,7 @@
package com.android.settings.connecteddevice; package com.android.settings.connecteddevice;
import android.content.Context; import android.content.Context;
import android.provider.Settings;
import android.support.annotation.VisibleForTesting; import android.support.annotation.VisibleForTesting;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.core.BasePreferenceController; import com.android.settings.core.BasePreferenceController;
@@ -26,6 +27,9 @@ import com.android.settings.nfc.NfcPreferenceController;
*/ */
public class AdvancedConnectedDeviceController extends BasePreferenceController { public class AdvancedConnectedDeviceController extends BasePreferenceController {
private static final String DRIVING_MODE_SETTINGS_ENABLED =
"gearhead:driving_mode_settings_enabled";
public AdvancedConnectedDeviceController(Context context, String preferenceKey) { public AdvancedConnectedDeviceController(Context context, String preferenceKey) {
super(context, preferenceKey); super(context, preferenceKey);
} }
@@ -47,10 +51,15 @@ public class AdvancedConnectedDeviceController extends BasePreferenceController
public static int getConnectedDevicesSummaryResourceId(Context context) { public static int getConnectedDevicesSummaryResourceId(Context context) {
final NfcPreferenceController nfcPreferenceController = final NfcPreferenceController nfcPreferenceController =
new NfcPreferenceController(context); new NfcPreferenceController(context);
final boolean isDrivingModeAvailable = false;
return getConnectedDevicesSummaryResourceId(nfcPreferenceController, return getConnectedDevicesSummaryResourceId(nfcPreferenceController,
isDrivingModeAvailable); isDrivingModeAvailable(context));
}
@VisibleForTesting
static boolean isDrivingModeAvailable(Context context) {
return Settings.System.
getInt(context.getContentResolver(), DRIVING_MODE_SETTINGS_ENABLED, 0) == 1;
} }
@VisibleForTesting @VisibleForTesting

View File

@@ -17,7 +17,9 @@ package com.android.settings.connecteddevice;
import static com.android.settings.core.BasePreferenceController.AVAILABLE; import static com.android.settings.core.BasePreferenceController.AVAILABLE;
import android.content.ContentResolver;
import android.content.Context; import android.content.Context;
import android.provider.Settings;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.nfc.NfcPreferenceController; import com.android.settings.nfc.NfcPreferenceController;
import com.android.settings.testutils.SettingsRobolectricTestRunner; import com.android.settings.testutils.SettingsRobolectricTestRunner;
@@ -39,16 +41,20 @@ import static org.robolectric.Shadows.shadowOf;
public class AdvancedConnectedDeviceControllerTest { public class AdvancedConnectedDeviceControllerTest {
private static final String KEY = "test_key"; private static final String KEY = "test_key";
private static final String DRIVING_MODE_SETTINGS_ENABLED =
"gearhead:driving_mode_settings_enabled";
private Context mContext; private Context mContext;
private NfcPreferenceController mNfcController; private NfcPreferenceController mNfcController;
private ShadowNfcAdapter mShadowNfcAdapter; private ShadowNfcAdapter mShadowNfcAdapter;
private ContentResolver mContentResolver;
@Before @Before
public void setUp() { public void setUp() {
MockitoAnnotations.initMocks(this); MockitoAnnotations.initMocks(this);
mContext = spy(RuntimeEnvironment.application); mContext = spy(RuntimeEnvironment.application);
mContentResolver = mContext.getContentResolver();
mNfcController = new NfcPreferenceController(mContext); mNfcController = new NfcPreferenceController(mContext);
mShadowNfcAdapter = shadowOf(ShadowNfcAdapter.getNfcAdapter(mContext)); mShadowNfcAdapter = shadowOf(ShadowNfcAdapter.getNfcAdapter(mContext));
} }
@@ -62,43 +68,53 @@ public class AdvancedConnectedDeviceControllerTest {
AVAILABLE); AVAILABLE);
} }
@Test
public void isDrivingModeAvailable_returnTrue() {
Settings.System.putInt(mContentResolver, DRIVING_MODE_SETTINGS_ENABLED, 1);
assertThat(AdvancedConnectedDeviceController.isDrivingModeAvailable(mContext)).isTrue();
}
@Test
public void isDrivingModeAvailable_returnFalse() {
Settings.System.putInt(mContentResolver, DRIVING_MODE_SETTINGS_ENABLED, 0);
assertThat(AdvancedConnectedDeviceController.isDrivingModeAvailable(mContext)).isFalse();
}
@Test @Test
public void getConnectedDevicesSummaryResourceId_NFCAndDrivingModeAvailable() { public void getConnectedDevicesSummaryResourceId_NFCAndDrivingModeAvailable() {
// NFC available, driving mode available // NFC available, driving mode available
final boolean isDrivingModeAvailable = true;
mShadowNfcAdapter.setEnabled(true); mShadowNfcAdapter.setEnabled(true);
assertThat(AdvancedConnectedDeviceController assertThat(AdvancedConnectedDeviceController
.getConnectedDevicesSummaryResourceId(mNfcController, isDrivingModeAvailable)) .getConnectedDevicesSummaryResourceId(mNfcController, true))
.isEqualTo(R.string.connected_devices_dashboard_summary); .isEqualTo(R.string.connected_devices_dashboard_summary);
} }
@Test @Test
public void getConnectedDevicesSummaryResourceId_NFCAvailableAndDrivingModeNotAvailable() { public void getConnectedDevicesSummaryResourceId_NFCAvailableAndDrivingModeNotAvailable() {
// NFC is available, driving mode not available // NFC is available, driving mode not available
final boolean isDrivingModeAvailable = false;
mShadowNfcAdapter.setEnabled(true); mShadowNfcAdapter.setEnabled(true);
assertThat(AdvancedConnectedDeviceController assertThat(AdvancedConnectedDeviceController
.getConnectedDevicesSummaryResourceId(mNfcController, isDrivingModeAvailable)) .getConnectedDevicesSummaryResourceId(mNfcController, false))
.isEqualTo(R.string.connected_devices_dashboard_no_driving_mode_summary); .isEqualTo(R.string.connected_devices_dashboard_no_driving_mode_summary);
} }
@Test @Test
public void getConnectedDevicesSummaryResourceId_NFCNotAvailableDrivingModeAvailable() { public void getConnectedDevicesSummaryResourceId_NFCNotAvailableDrivingModeAvailable() {
// NFC not available, driving mode available // NFC not available, driving mode available
final boolean isDrivingModeAvailable = true;
ReflectionHelpers.setField(mNfcController, "mNfcAdapter", null); ReflectionHelpers.setField(mNfcController, "mNfcAdapter", null);
assertThat(AdvancedConnectedDeviceController assertThat(AdvancedConnectedDeviceController
.getConnectedDevicesSummaryResourceId(mNfcController, isDrivingModeAvailable)) .getConnectedDevicesSummaryResourceId(mNfcController, true))
.isEqualTo(R.string.connected_devices_dashboard_no_nfc_summary); .isEqualTo(R.string.connected_devices_dashboard_no_nfc_summary);
} }
@Test @Test
public void getConnectedDevicesSummaryResourceId_NFCAndDrivingModeNotAvailable() { public void getConnectedDevicesSummaryResourceId_NFCAndDrivingModeNotAvailable() {
// NFC not available, driving mode not available // NFC not available, driving mode not available
final boolean isDrivingModeAvailable = false;
ReflectionHelpers.setField(mNfcController, "mNfcAdapter", null); ReflectionHelpers.setField(mNfcController, "mNfcAdapter", null);
assertThat(AdvancedConnectedDeviceController assertThat(AdvancedConnectedDeviceController
.getConnectedDevicesSummaryResourceId(mNfcController, isDrivingModeAvailable)) .getConnectedDevicesSummaryResourceId(mNfcController, false))
.isEqualTo(R.string.connected_devices_dashboard_no_driving_mode_no_nfc_summary); .isEqualTo(R.string.connected_devices_dashboard_no_driving_mode_no_nfc_summary);
} }
} }