Merge changes from topic 'hotspot_summary'
* changes: Display current vpn for Vpn preference summary text Display carrier network name as celluar setting summary. Add hotspot summary text
This commit is contained in:
committed by
Android (Google) Code Review
commit
33b0a66aee
@@ -253,7 +253,8 @@ public class WirelessSettings extends SettingsPreferenceFragment implements Inde
|
||||
new NfcPreferenceController(context).updateNonIndexableKeys(result);
|
||||
new MobilePlanPreferenceController(context, null /* MobilePlanClickHandler */)
|
||||
.updateNonIndexableKeys(result);
|
||||
new MobileNetworkPreferenceController(context).updateNonIndexableKeys(result);
|
||||
new MobileNetworkPreferenceController(context)
|
||||
.updateNonIndexableKeys(result);
|
||||
|
||||
// Remove Airplane Mode settings if it's a stationary device such as a TV.
|
||||
new AirplaneModePreferenceController(context, null /* fragment */)
|
||||
|
||||
@@ -17,25 +17,39 @@ package com.android.settings.network;
|
||||
|
||||
import android.content.Context;
|
||||
import android.os.UserManager;
|
||||
import android.support.annotation.VisibleForTesting;
|
||||
import android.support.v7.preference.Preference;
|
||||
import android.support.v7.preference.PreferenceScreen;
|
||||
import android.telephony.PhoneStateListener;
|
||||
import android.telephony.ServiceState;
|
||||
import android.telephony.TelephonyManager;
|
||||
|
||||
import com.android.settings.Utils;
|
||||
import com.android.settings.core.PreferenceController;
|
||||
import com.android.settings.core.lifecycle.LifecycleObserver;
|
||||
import com.android.settings.core.lifecycle.events.OnPause;
|
||||
import com.android.settings.core.lifecycle.events.OnResume;
|
||||
|
||||
import static android.os.UserHandle.myUserId;
|
||||
import static android.os.UserManager.DISALLOW_CONFIG_MOBILE_NETWORKS;
|
||||
import static com.android.settingslib.RestrictedLockUtils.hasBaseUserRestriction;
|
||||
|
||||
public class MobileNetworkPreferenceController extends PreferenceController {
|
||||
public class MobileNetworkPreferenceController extends PreferenceController implements
|
||||
LifecycleObserver, OnResume, OnPause {
|
||||
|
||||
private static final String KEY_MOBILE_NETWORK_SETTINGS = "mobile_network_settings";
|
||||
|
||||
private final UserManager mUserManager;
|
||||
private final boolean mIsSecondaryUser;
|
||||
private final TelephonyManager mTelephonyManager;
|
||||
private Preference mPreference;
|
||||
@VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
|
||||
PhoneStateListener mPhoneStateListener;
|
||||
|
||||
public MobileNetworkPreferenceController(Context context) {
|
||||
super(context);
|
||||
mUserManager = (UserManager) context.getSystemService(Context.USER_SERVICE);
|
||||
mTelephonyManager = (TelephonyManager) context.getSystemService(Context.TELEPHONY_SERVICE);
|
||||
mIsSecondaryUser = !mUserManager.isAdminUser();
|
||||
}
|
||||
|
||||
@@ -46,8 +60,40 @@ public class MobileNetworkPreferenceController extends PreferenceController {
|
||||
&& !hasBaseUserRestriction(mContext, DISALLOW_CONFIG_MOBILE_NETWORKS, myUserId());
|
||||
}
|
||||
|
||||
@Override
|
||||
public void displayPreference(PreferenceScreen screen) {
|
||||
super.displayPreference(screen);
|
||||
if (isAvailable()) {
|
||||
mPreference = screen.findPreference(getPreferenceKey());
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
public String getPreferenceKey() {
|
||||
return KEY_MOBILE_NETWORK_SETTINGS;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onResume() {
|
||||
if (isAvailable()) {
|
||||
if (mPhoneStateListener == null) {
|
||||
mPhoneStateListener = new PhoneStateListener() {
|
||||
@Override
|
||||
public void onServiceStateChanged(ServiceState serviceState) {
|
||||
if (mPreference != null) {
|
||||
mPreference.setSummary(mTelephonyManager.getNetworkOperatorName());
|
||||
}
|
||||
}
|
||||
};
|
||||
}
|
||||
mTelephonyManager.listen(mPhoneStateListener, PhoneStateListener.LISTEN_SERVICE_STATE);
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onPause() {
|
||||
if (mPhoneStateListener != null) {
|
||||
mTelephonyManager.listen(mPhoneStateListener, PhoneStateListener.LISTEN_NONE);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -81,16 +81,22 @@ public class NetworkDashboardFragment extends DashboardFragment implements
|
||||
new MobilePlanPreferenceController(context, this);
|
||||
final WifiMasterSwitchPreferenceController wifiPreferenceController =
|
||||
new WifiMasterSwitchPreferenceController(context, mMetricsFeatureProvider);
|
||||
final MobileNetworkPreferenceController mobileNetworkPreferenceController =
|
||||
new MobileNetworkPreferenceController(context);
|
||||
final VpnPreferenceController vpnPreferenceController =
|
||||
new VpnPreferenceController(context);
|
||||
final Lifecycle lifecycle = getLifecycle();
|
||||
lifecycle.addObserver(airplaneModePreferenceController);
|
||||
lifecycle.addObserver(mobilePlanPreferenceController);
|
||||
lifecycle.addObserver(wifiPreferenceController);
|
||||
lifecycle.addObserver(mobileNetworkPreferenceController);
|
||||
lifecycle.addObserver(vpnPreferenceController);
|
||||
|
||||
final List<PreferenceController> controllers = new ArrayList<>();
|
||||
controllers.add(airplaneModePreferenceController);
|
||||
controllers.add(new MobileNetworkPreferenceController(context));
|
||||
controllers.add(mobileNetworkPreferenceController);
|
||||
controllers.add(new TetherPreferenceController(context));
|
||||
controllers.add(new VpnPreferenceController(context));
|
||||
controllers.add(vpnPreferenceController);
|
||||
controllers.add(new ProxyPreferenceController(context));
|
||||
controllers.add(mobilePlanPreferenceController);
|
||||
controllers.add(wifiPreferenceController);
|
||||
|
||||
@@ -15,17 +15,23 @@
|
||||
*/
|
||||
package com.android.settings.network;
|
||||
|
||||
import android.bluetooth.BluetoothAdapter;
|
||||
import android.bluetooth.BluetoothPan;
|
||||
import android.bluetooth.BluetoothProfile;
|
||||
import android.content.Context;
|
||||
import android.net.ConnectivityManager;
|
||||
import android.os.UserHandle;
|
||||
import android.os.UserManager;
|
||||
import android.support.annotation.VisibleForTesting;
|
||||
import android.support.v7.preference.Preference;
|
||||
import android.support.v7.preference.PreferenceScreen;
|
||||
|
||||
import com.android.settings.R;
|
||||
import com.android.settings.TetherSettings;
|
||||
import com.android.settings.core.PreferenceController;
|
||||
|
||||
import java.util.List;
|
||||
import java.util.concurrent.atomic.AtomicReference;
|
||||
|
||||
import static android.os.UserManager.DISALLOW_CONFIG_TETHERING;
|
||||
import static com.android.settingslib.RestrictedLockUtils.checkIfRestrictionEnforced;
|
||||
@@ -36,28 +42,60 @@ public class TetherPreferenceController extends PreferenceController {
|
||||
private static final String KEY_TETHER_SETTINGS = "tether_settings";
|
||||
|
||||
private final boolean mAdminDisallowedTetherConfig;
|
||||
private final AtomicReference<BluetoothPan> mBluetoothPan;
|
||||
private final ConnectivityManager mConnectivityManager;
|
||||
private final BluetoothAdapter mBluetoothAdapter;
|
||||
private final UserManager mUserManager;
|
||||
|
||||
private final BluetoothProfile.ServiceListener mBtProfileServiceListener =
|
||||
new android.bluetooth.BluetoothProfile.ServiceListener() {
|
||||
public void onServiceConnected(int profile, BluetoothProfile proxy) {
|
||||
mBluetoothPan.set((BluetoothPan) proxy);
|
||||
updateSummary();
|
||||
}
|
||||
|
||||
public void onServiceDisconnected(int profile) {
|
||||
mBluetoothPan.set(null);
|
||||
}
|
||||
};
|
||||
|
||||
private Preference mPreference;
|
||||
|
||||
@VisibleForTesting(otherwise = VisibleForTesting.NONE)
|
||||
TetherPreferenceController() {
|
||||
super(null);
|
||||
mAdminDisallowedTetherConfig = false;
|
||||
mBluetoothPan = null;
|
||||
mConnectivityManager = null;
|
||||
mBluetoothAdapter = null;
|
||||
mUserManager = null;
|
||||
}
|
||||
|
||||
public TetherPreferenceController(Context context) {
|
||||
super(context);
|
||||
mBluetoothPan = new AtomicReference<>();
|
||||
mAdminDisallowedTetherConfig = checkIfRestrictionEnforced(
|
||||
context, DISALLOW_CONFIG_TETHERING, UserHandle.myUserId()) != null;
|
||||
mConnectivityManager =
|
||||
(ConnectivityManager) context.getSystemService(Context.CONNECTIVITY_SERVICE);
|
||||
mUserManager = (UserManager) context.getSystemService(Context.USER_SERVICE);
|
||||
mBluetoothAdapter = BluetoothAdapter.getDefaultAdapter();
|
||||
if (mBluetoothAdapter != null) {
|
||||
mBluetoothAdapter.getProfileProxy(context, mBtProfileServiceListener,
|
||||
BluetoothProfile.PAN);
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
public void displayPreference(PreferenceScreen screen) {
|
||||
super.displayPreference(screen);
|
||||
final Preference preference = screen.findPreference(KEY_TETHER_SETTINGS);
|
||||
if (preference != null && !mAdminDisallowedTetherConfig) {
|
||||
preference.setTitle(
|
||||
mPreference = screen.findPreference(KEY_TETHER_SETTINGS);
|
||||
if (mPreference != null && !mAdminDisallowedTetherConfig) {
|
||||
mPreference.setTitle(
|
||||
com.android.settingslib.Utils.getTetheringLabel(mConnectivityManager));
|
||||
|
||||
// Grey out if provisioning is not available.
|
||||
preference.setEnabled(!TetherSettings.isProvisioningNeededButUnavailable(mContext));
|
||||
mPreference.setEnabled(!TetherSettings.isProvisioningNeededButUnavailable(mContext));
|
||||
}
|
||||
}
|
||||
|
||||
@@ -70,6 +108,11 @@ public class TetherPreferenceController extends PreferenceController {
|
||||
return !isBlocked;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void updateState(Preference preference) {
|
||||
updateSummary();
|
||||
}
|
||||
|
||||
@Override
|
||||
public void updateNonIndexableKeys(List<String> keys) {
|
||||
if (!mUserManager.isAdminUser() || !mConnectivityManager.isTetheringSupported()) {
|
||||
@@ -81,4 +124,60 @@ public class TetherPreferenceController extends PreferenceController {
|
||||
public String getPreferenceKey() {
|
||||
return KEY_TETHER_SETTINGS;
|
||||
}
|
||||
|
||||
@VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
|
||||
void updateSummary() {
|
||||
if (mPreference == null) {
|
||||
// Preference is not ready yet.
|
||||
return;
|
||||
}
|
||||
String[] allTethered = mConnectivityManager.getTetheredIfaces();
|
||||
String[] wifiTetherRegex = mConnectivityManager.getTetherableWifiRegexs();
|
||||
String[] bluetoothRegex = mConnectivityManager.getTetherableBluetoothRegexs();
|
||||
|
||||
boolean hotSpotOn = false;
|
||||
boolean tetherOn = false;
|
||||
if (allTethered != null) {
|
||||
if (wifiTetherRegex != null) {
|
||||
for (String tethered : allTethered) {
|
||||
for (String regex : wifiTetherRegex) {
|
||||
if (tethered.matches(regex)) {
|
||||
hotSpotOn = true;
|
||||
break;
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
if (allTethered.length > 1) {
|
||||
// We have more than 1 tethered connection
|
||||
tetherOn = true;
|
||||
} else if (allTethered.length == 1) {
|
||||
// We have more than 1 tethered, it's either wifiTether (hotspot), or other type of
|
||||
// tether.
|
||||
tetherOn = !hotSpotOn;
|
||||
} else {
|
||||
// No tethered connection.
|
||||
tetherOn = false;
|
||||
}
|
||||
}
|
||||
if (!tetherOn
|
||||
&& bluetoothRegex != null && bluetoothRegex.length > 0
|
||||
&& mBluetoothAdapter != null
|
||||
&& mBluetoothAdapter.getState() == BluetoothAdapter.STATE_ON) {
|
||||
// Check bluetooth state. It's not included in mConnectivityManager.getTetheredIfaces.
|
||||
final BluetoothPan pan = mBluetoothPan.get();
|
||||
tetherOn = pan != null && pan.isTetheringOn();
|
||||
}
|
||||
if (!hotSpotOn && !tetherOn) {
|
||||
// Both off
|
||||
mPreference.setSummary(R.string.switch_off_text);
|
||||
} else if (hotSpotOn && tetherOn) {
|
||||
// Both on
|
||||
mPreference.setSummary(R.string.tether_settings_summary_hotspot_on_tether_on);
|
||||
} else if (hotSpotOn) {
|
||||
mPreference.setSummary(R.string.tether_settings_summary_hotspot_on_tether_off);
|
||||
} else {
|
||||
mPreference.setSummary(R.string.tether_settings_summary_hotspot_off_tether_on);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
@@ -16,38 +16,74 @@
|
||||
package com.android.settings.network;
|
||||
|
||||
import android.content.Context;
|
||||
import android.content.pm.PackageManager;
|
||||
import android.content.pm.UserInfo;
|
||||
import android.net.ConnectivityManager;
|
||||
import android.net.IConnectivityManager;
|
||||
import android.net.Network;
|
||||
import android.net.NetworkCapabilities;
|
||||
import android.net.NetworkRequest;
|
||||
import android.os.Handler;
|
||||
import android.os.Looper;
|
||||
import android.os.RemoteException;
|
||||
import android.os.ServiceManager;
|
||||
import android.os.UserHandle;
|
||||
import android.os.UserManager;
|
||||
import android.provider.Settings;
|
||||
import android.support.annotation.VisibleForTesting;
|
||||
import android.support.v7.preference.Preference;
|
||||
import android.support.v7.preference.PreferenceScreen;
|
||||
import android.util.Log;
|
||||
import android.util.SparseArray;
|
||||
|
||||
import com.android.internal.net.LegacyVpnInfo;
|
||||
import com.android.internal.net.VpnConfig;
|
||||
import com.android.settings.R;
|
||||
import com.android.settings.core.PreferenceController;
|
||||
import com.android.settings.core.lifecycle.LifecycleObserver;
|
||||
import com.android.settings.core.lifecycle.events.OnPause;
|
||||
import com.android.settings.core.lifecycle.events.OnResume;
|
||||
import com.android.settingslib.RestrictedLockUtils;
|
||||
|
||||
import java.util.List;
|
||||
|
||||
public class VpnPreferenceController extends PreferenceController {
|
||||
|
||||
public class VpnPreferenceController extends PreferenceController implements LifecycleObserver,
|
||||
OnResume, OnPause {
|
||||
|
||||
private static final String KEY_VPN_SETTINGS = "vpn_settings";
|
||||
private static final NetworkRequest REQUEST = new NetworkRequest.Builder()
|
||||
.removeCapability(NetworkCapabilities.NET_CAPABILITY_NOT_VPN)
|
||||
.removeCapability(NetworkCapabilities.NET_CAPABILITY_NOT_RESTRICTED)
|
||||
.removeCapability(NetworkCapabilities.NET_CAPABILITY_TRUSTED)
|
||||
.build();
|
||||
private static final String TAG = "VpnPreferenceController";
|
||||
|
||||
private final String mToggleable;
|
||||
private final boolean mIsSecondaryUser;
|
||||
private final UserManager mUserManager;
|
||||
private final ConnectivityManager mConnectivityManager;
|
||||
private final IConnectivityManager mConnectivityManagerService;
|
||||
private Preference mPreference;
|
||||
|
||||
public VpnPreferenceController(Context context) {
|
||||
super(context);
|
||||
mToggleable = Settings.Global.getString(context.getContentResolver(),
|
||||
Settings.Global.AIRPLANE_MODE_TOGGLEABLE_RADIOS);
|
||||
mIsSecondaryUser = !UserManager.get(context).isAdminUser();
|
||||
mUserManager = (UserManager) context.getSystemService(Context.USER_SERVICE);
|
||||
mConnectivityManager =
|
||||
(ConnectivityManager) context.getSystemService(Context.CONNECTIVITY_SERVICE);
|
||||
mConnectivityManagerService = IConnectivityManager.Stub.asInterface(
|
||||
ServiceManager.getService(Context.CONNECTIVITY_SERVICE));
|
||||
}
|
||||
|
||||
@Override
|
||||
public void displayPreference(PreferenceScreen screen) {
|
||||
super.displayPreference(screen);
|
||||
mPreference = screen.findPreference(KEY_VPN_SETTINGS);
|
||||
// Manually set dependencies for Wifi when not toggleable.
|
||||
if (mToggleable == null || !mToggleable.contains(Settings.Global.RADIO_WIFI)) {
|
||||
final Preference pref = screen.findPreference(KEY_VPN_SETTINGS);
|
||||
if (pref != null) {
|
||||
pref.setDependency(AirplaneModePreferenceController.KEY_TOGGLE_AIRPLANE);
|
||||
if (mPreference != null) {
|
||||
mPreference.setDependency(AirplaneModePreferenceController.KEY_TOGGLE_AIRPLANE);
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -62,4 +98,96 @@ public class VpnPreferenceController extends PreferenceController {
|
||||
public String getPreferenceKey() {
|
||||
return KEY_VPN_SETTINGS;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onPause() {
|
||||
if (isAvailable()) {
|
||||
mConnectivityManager.unregisterNetworkCallback(mNetworkCallback);
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onResume() {
|
||||
if (isAvailable()) {
|
||||
mConnectivityManager.registerNetworkCallback(REQUEST, mNetworkCallback);
|
||||
}
|
||||
}
|
||||
|
||||
@VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
|
||||
void updateSummary() {
|
||||
if (mPreference == null) {
|
||||
return;
|
||||
}
|
||||
// Copied from SystemUI::SecurityControllerImpl
|
||||
SparseArray<VpnConfig> vpns = new SparseArray<>();
|
||||
try {
|
||||
final List<UserInfo> users = mUserManager.getUsers();
|
||||
for (UserInfo user : users) {
|
||||
VpnConfig cfg = mConnectivityManagerService.getVpnConfig(user.id);
|
||||
if (cfg == null) {
|
||||
continue;
|
||||
} else if (cfg.legacy) {
|
||||
// Legacy VPNs should do nothing if the network is disconnected. Third-party
|
||||
// VPN warnings need to continue as traffic can still go to the app.
|
||||
final LegacyVpnInfo legacyVpn =
|
||||
mConnectivityManagerService.getLegacyVpnInfo(user.id);
|
||||
if (legacyVpn == null || legacyVpn.state != LegacyVpnInfo.STATE_CONNECTED) {
|
||||
continue;
|
||||
}
|
||||
}
|
||||
vpns.put(user.id, cfg);
|
||||
}
|
||||
} catch (RemoteException rme) {
|
||||
// Roll back to previous state
|
||||
Log.e(TAG, "Unable to list active VPNs", rme);
|
||||
return;
|
||||
}
|
||||
final UserInfo userInfo = mUserManager.getUserInfo(UserHandle.myUserId());
|
||||
final int uid;
|
||||
if (userInfo.isRestricted()) {
|
||||
uid = userInfo.restrictedProfileParentId;
|
||||
} else {
|
||||
uid = userInfo.id;
|
||||
}
|
||||
VpnConfig vpn = vpns.get(uid);
|
||||
final String vpnName;
|
||||
if (vpn == null) {
|
||||
vpnName = null;
|
||||
} else {
|
||||
vpnName = getNameForVpnConfig(vpn, UserHandle.of(uid));
|
||||
}
|
||||
new Handler(Looper.getMainLooper()).post(() -> mPreference.setSummary(vpnName));
|
||||
}
|
||||
|
||||
private String getNameForVpnConfig(VpnConfig cfg, UserHandle user) {
|
||||
if (cfg.legacy) {
|
||||
return mContext.getString(R.string.bluetooth_connected);
|
||||
}
|
||||
// The package name for an active VPN is stored in the 'user' field of its VpnConfig
|
||||
final String vpnPackage = cfg.user;
|
||||
try {
|
||||
Context userContext = mContext.createPackageContextAsUser(mContext.getPackageName(),
|
||||
0 /* flags */, user);
|
||||
return VpnConfig.getVpnLabel(userContext, vpnPackage).toString();
|
||||
} catch (PackageManager.NameNotFoundException nnfe) {
|
||||
Log.e(TAG, "Package " + vpnPackage + " is not present", nnfe);
|
||||
return null;
|
||||
}
|
||||
}
|
||||
|
||||
// Copied from SystemUI::SecurityControllerImpl
|
||||
private final ConnectivityManager.NetworkCallback
|
||||
mNetworkCallback = new ConnectivityManager.NetworkCallback() {
|
||||
@Override
|
||||
public void onAvailable(Network network) {
|
||||
Log.d(TAG, "onAvailable " + network.netId);
|
||||
updateSummary();
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onLost(Network network) {
|
||||
Log.d(TAG, "onLost " + network.netId);
|
||||
updateSummary();
|
||||
}
|
||||
};
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user