Add metrics log for special cases in Lanugages & About page

Bug: 137559984
Test: robotest

Change-Id: I007282d8c4d5f9c6168dd84f6feee7e237ec7c42
This commit is contained in:
Edgar Wang
2020-04-23 15:45:05 +08:00
parent c3d052a48c
commit 329b20a445
4 changed files with 23 additions and 17 deletions

View File

@@ -45,7 +45,6 @@ import com.android.settings.R;
import com.android.settings.Settings; import com.android.settings.Settings;
import com.android.settings.SettingsPreferenceFragment; import com.android.settings.SettingsPreferenceFragment;
import com.android.settings.search.BaseSearchIndexProvider; import com.android.settings.search.BaseSearchIndexProvider;
import com.android.settingslib.search.Indexable;
import com.android.settingslib.search.SearchIndexable; import com.android.settingslib.search.SearchIndexable;
import com.android.settingslib.utils.ThreadUtils; import com.android.settingslib.utils.ThreadUtils;
@@ -85,14 +84,16 @@ public final class PhysicalKeyboardFragment extends SettingsPreferenceFragment
mShowVirtualKeyboardSwitch = Preconditions.checkNotNull( mShowVirtualKeyboardSwitch = Preconditions.checkNotNull(
(SwitchPreference) mKeyboardAssistanceCategory.findPreference( (SwitchPreference) mKeyboardAssistanceCategory.findPreference(
SHOW_VIRTUAL_KEYBOARD_SWITCH)); SHOW_VIRTUAL_KEYBOARD_SWITCH));
findPreference(KEYBOARD_SHORTCUTS_HELPER).setOnPreferenceClickListener( }
new Preference.OnPreferenceClickListener() {
@Override @Override
public boolean onPreferenceClick(Preference preference) { public boolean onPreferenceTreeClick(Preference preference) {
if (KEYBOARD_SHORTCUTS_HELPER.equals(preference.getKey())) {
writePreferenceClickMetric(preference);
toggleKeyboardShortcutsMenu(); toggleKeyboardShortcutsMenu();
return true; return true;
} }
}); return super.onPreferenceTreeClick(preference);
} }
@Override @Override

View File

@@ -31,7 +31,6 @@ import android.widget.Switch;
import androidx.appcompat.app.AlertDialog; import androidx.appcompat.app.AlertDialog;
import androidx.preference.Preference; import androidx.preference.Preference;
import androidx.preference.Preference.OnPreferenceChangeListener; import androidx.preference.Preference.OnPreferenceChangeListener;
import androidx.preference.Preference.OnPreferenceClickListener;
import androidx.preference.PreferenceScreen; import androidx.preference.PreferenceScreen;
import com.android.settings.R; import com.android.settings.R;
@@ -41,7 +40,7 @@ import com.android.settings.widget.SwitchBar;
import com.android.settings.widget.SwitchBar.OnSwitchChangeListener; import com.android.settings.widget.SwitchBar.OnSwitchChangeListener;
public class SpellCheckersSettings extends SettingsPreferenceFragment public class SpellCheckersSettings extends SettingsPreferenceFragment
implements OnSwitchChangeListener, OnPreferenceClickListener, OnPreferenceChangeListener { implements OnSwitchChangeListener, OnPreferenceChangeListener {
private static final String TAG = SpellCheckersSettings.class.getSimpleName(); private static final String TAG = SpellCheckersSettings.class.getSimpleName();
private static final boolean DBG = false; private static final boolean DBG = false;
@@ -67,7 +66,6 @@ public class SpellCheckersSettings extends SettingsPreferenceFragment
addPreferencesFromResource(R.xml.spellchecker_prefs); addPreferencesFromResource(R.xml.spellchecker_prefs);
mSpellCheckerLanaguagePref = findPreference(KEY_SPELL_CHECKER_LANGUAGE); mSpellCheckerLanaguagePref = findPreference(KEY_SPELL_CHECKER_LANGUAGE);
mSpellCheckerLanaguagePref.setOnPreferenceClickListener(this);
mTsm = (TextServicesManager) getSystemService(Context.TEXT_SERVICES_MANAGER_SERVICE); mTsm = (TextServicesManager) getSystemService(Context.TEXT_SERVICES_MANAGER_SERVICE);
mCurrentSci = mTsm.getCurrentSpellChecker(); mCurrentSci = mTsm.getCurrentSpellChecker();
@@ -155,12 +153,13 @@ public class SpellCheckersSettings extends SettingsPreferenceFragment
} }
@Override @Override
public boolean onPreferenceClick(final Preference pref) { public boolean onPreferenceTreeClick(Preference preference) {
if (pref == mSpellCheckerLanaguagePref) { if (KEY_SPELL_CHECKER_LANGUAGE.equals(preference.getKey())) {
writePreferenceClickMetric(preference);
showChooseLanguageDialog(); showChooseLanguageDialog();
return true; return true;
} }
return false; return super.onPreferenceTreeClick(preference);
} }
@Override @Override

View File

@@ -42,6 +42,7 @@ import com.android.internal.app.LocalePicker;
import com.android.internal.app.LocaleStore; import com.android.internal.app.LocaleStore;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.RestrictedSettingsFragment; import com.android.settings.RestrictedSettingsFragment;
import com.android.settings.overlay.FeatureFactory;
import com.android.settings.search.BaseSearchIndexProvider; import com.android.settings.search.BaseSearchIndexProvider;
import com.android.settingslib.search.SearchIndexable; import com.android.settingslib.search.SearchIndexable;
import com.android.settingslib.search.SearchIndexableRaw; import com.android.settingslib.search.SearchIndexableRaw;
@@ -300,6 +301,9 @@ public class LocaleListEditor extends RestrictedSettingsFragment {
mAddLanguage.setOnClickListener(new View.OnClickListener() { mAddLanguage.setOnClickListener(new View.OnClickListener() {
@Override @Override
public void onClick(View v) { public void onClick(View v) {
FeatureFactory.getFactory(getContext()).getMetricsFeatureProvider()
.logSettingsTileClick(INDEX_KEY_ADD_LANGUAGE, getMetricsCategory());
final Intent intent = new Intent(getActivity(), final Intent intent = new Intent(getActivity(),
LocalePickerWithRegionActivity.class); LocalePickerWithRegionActivity.class);
startActivityForResult(intent, REQUEST_LOCALE_PICKER); startActivityForResult(intent, REQUEST_LOCALE_PICKER);

View File

@@ -46,6 +46,7 @@ import com.android.settings.R;
import com.android.settings.SettingsActivity; import com.android.settings.SettingsActivity;
import com.android.settings.SettingsPreferenceFragment; import com.android.settings.SettingsPreferenceFragment;
import com.android.settings.Utils; import com.android.settings.Utils;
import com.android.settings.overlay.FeatureFactory;
import com.android.settings.search.BaseSearchIndexProvider; import com.android.settings.search.BaseSearchIndexProvider;
import com.android.settings.widget.GearPreference; import com.android.settings.widget.GearPreference;
import com.android.settings.widget.SeekBarPreference; import com.android.settings.widget.SeekBarPreference;
@@ -720,8 +721,7 @@ public class TextToSpeechSettings extends SettingsPreferenceFragment
} }
private void updateTTSSetting(String key, int value) { private void updateTTSSetting(String key, int value) {
Secure.putInt( Secure.putInt(getContentResolver(), key, value);
getContentResolver(), key, value);
final int managedProfileUserId = final int managedProfileUserId =
Utils.getManagedProfileId(mUserManager, UserHandle.myUserId()); Utils.getManagedProfileId(mUserManager, UserHandle.myUserId());
if (managedProfileUserId != UserHandle.USER_NULL) { if (managedProfileUserId != UserHandle.USER_NULL) {
@@ -799,6 +799,8 @@ public class TextToSpeechSettings extends SettingsPreferenceFragment
} else { } else {
Log.e(TAG, "settingsIntent is null"); Log.e(TAG, "settingsIntent is null");
} }
FeatureFactory.getFactory(getContext()).getMetricsFeatureProvider()
.logClickedPreference(p, getMetricsCategory());
} }
} }