From 8d9b26562046827a1a626fd1696efebae582cf34 Mon Sep 17 00:00:00 2001
From: Emily Chuang <emilychuang@google.com>
Date: Wed, 17 Oct 2018 20:50:20 +0800
Subject: [PATCH] Give SliceView a height to support four rows and show more
 button.

The default height of sliceView with MODE_LARGE is 240dp which supports
three rows(including the header) above "show more" button. Since WIFI
and Connected devices use cases require four rows + show more button, we
need to expand the height to fulfill it.

Bug: 117868297
Test: visual
Change-Id: I13b29c3f859d1c117c680432f9a6ad8e71c6acf5
---
 res/layout/homepage_slice_tile.xml | 2 +-
 res/values/dimens.xml              | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/res/layout/homepage_slice_tile.xml b/res/layout/homepage_slice_tile.xml
index b947d656097..4244460a961 100644
--- a/res/layout/homepage_slice_tile.xml
+++ b/res/layout/homepage_slice_tile.xml
@@ -30,7 +30,7 @@
     <androidx.slice.widget.SliceView
         android:id="@+id/slice_view"
         android:layout_width="match_parent"
-        android:layout_height="wrap_content"
+        android:layout_height="@dimen/homepage_slice_card_max_height"
         android:paddingStart="@dimen/homepage_card_padding_start"
         android:paddingEnd="@dimen/homepage_card_padding_end"
         android:paddingTop="@dimen/homepage_card_padding_top"
diff --git a/res/values/dimens.xml b/res/values/dimens.xml
index 2d2bfb781ef..edece3cb930 100755
--- a/res/values/dimens.xml
+++ b/res/values/dimens.xml
@@ -350,6 +350,10 @@
     <dimen name="homepage_card_padding_top">6dp</dimen>
     <dimen name="homepage_card_padding_bottom">6dp</dimen>
 
+    <!-- Slice cards maximum height (4 rows + show more)
+        MODE_LARGE height(3 rows + show more) 240dp + one line text(1 row) 48dp = 288dp -->
+    <dimen name="homepage_slice_card_max_height">288dp</dimen>
+
     <!-- Signal icon in NetworkSelectSetting -->
     <dimen name="signal_strength_icon_size">24dp</dimen>