From 6c921e5b6cabf097efe5bf6fff7ed209eac78877 Mon Sep 17 00:00:00 2001 From: Tsung-Mao Fang Date: Mon, 11 Jan 2021 22:57:45 +0800 Subject: [PATCH] Refine the preference layout for homepage Based on the Android S design, we update the layout for homepage. The scope covers the layout of preference and icons itself. - Change the icon size for IA items. - Change the layout spacing of preference. - Change the margin or search bar. Test: See the screen and confirm with UX Bug: 177213699 Change-Id: I985966fdf39a5989d51991aa3c06ea5fd31e8fe2 --- color-check-baseline.xml | 396 ++++++++++++++++-- res/drawable/ic_homepage_about_v2.xml | 33 ++ res/drawable/ic_homepage_accessibility_v2.xml | 33 ++ res/drawable/ic_homepage_accounts_v2.xml | 33 ++ res/drawable/ic_homepage_apps_v2.xml | 33 ++ res/drawable/ic_homepage_battery_v2.xml | 33 ++ .../ic_homepage_connected_device_v2.xml | 33 ++ res/drawable/ic_homepage_display_v2.xml | 33 ++ res/drawable/ic_homepage_emergency_v2.xml | 33 ++ res/drawable/ic_homepage_location_v2.xml | 33 ++ res/drawable/ic_homepage_network_v2.xml | 33 ++ res/drawable/ic_homepage_notification_v2.xml | 33 ++ res/drawable/ic_homepage_privacy_v2.xml | 33 ++ res/drawable/ic_homepage_security_v2.xml | 33 ++ res/drawable/ic_homepage_sound_v2.xml | 33 ++ res/drawable/ic_homepage_storage_v2.xml | 33 ++ res/drawable/ic_homepage_support_v2.xml | 33 ++ .../ic_homepage_system_dashboard_v2.xml | 33 ++ res/drawable/ic_homepage_wallpaper_v2.xml | 33 ++ res/layout/homepage_preference.xml | 65 +++ res/layout/search_bar.xml | 5 +- res/values/dimens.xml | 6 + res/values/styles.xml | 6 + res/xml/top_level_settings_grouped.xml | 73 ++-- ...TopLevelWallpaperPreferenceController.java | 23 +- .../settings/homepage/HomePagePreference.java | 49 +++ .../RestrictedHomepagePreference.java | 122 ++++++ 27 files changed, 1268 insertions(+), 71 deletions(-) create mode 100644 res/drawable/ic_homepage_about_v2.xml create mode 100644 res/drawable/ic_homepage_accessibility_v2.xml create mode 100644 res/drawable/ic_homepage_accounts_v2.xml create mode 100644 res/drawable/ic_homepage_apps_v2.xml create mode 100644 res/drawable/ic_homepage_battery_v2.xml create mode 100644 res/drawable/ic_homepage_connected_device_v2.xml create mode 100644 res/drawable/ic_homepage_display_v2.xml create mode 100644 res/drawable/ic_homepage_emergency_v2.xml create mode 100644 res/drawable/ic_homepage_location_v2.xml create mode 100644 res/drawable/ic_homepage_network_v2.xml create mode 100644 res/drawable/ic_homepage_notification_v2.xml create mode 100644 res/drawable/ic_homepage_privacy_v2.xml create mode 100644 res/drawable/ic_homepage_security_v2.xml create mode 100644 res/drawable/ic_homepage_sound_v2.xml create mode 100644 res/drawable/ic_homepage_storage_v2.xml create mode 100644 res/drawable/ic_homepage_support_v2.xml create mode 100644 res/drawable/ic_homepage_system_dashboard_v2.xml create mode 100644 res/drawable/ic_homepage_wallpaper_v2.xml create mode 100644 res/layout/homepage_preference.xml create mode 100644 src/com/android/settings/homepage/HomePagePreference.java create mode 100644 src/com/android/settings/homepage/RestrictedHomepagePreference.java diff --git a/color-check-baseline.xml b/color-check-baseline.xml index 768929b6b98..eac6d3c2511 100644 --- a/color-check-baseline.xml +++ b/color-check-baseline.xml @@ -1,6 +1,18 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -2973,7 +3305,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -2989,7 +3321,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -3005,7 +3337,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -3021,7 +3353,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -3037,7 +3369,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -3053,7 +3385,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -3069,7 +3401,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -3121,6 +3453,22 @@ column="9"/> + + + + @@ -3149,7 +3497,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~"> @@ -3165,7 +3513,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~"> @@ -3181,26 +3529,10 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~"> - - - - @@ -3261,7 +3593,7 @@ errorLine2=" ^"> @@ -3277,7 +3609,7 @@ errorLine2=" ^"> @@ -3293,7 +3625,7 @@ errorLine2=" ^"> diff --git a/res/drawable/ic_homepage_about_v2.xml b/res/drawable/ic_homepage_about_v2.xml new file mode 100644 index 00000000000..c069bfc98ba --- /dev/null +++ b/res/drawable/ic_homepage_about_v2.xml @@ -0,0 +1,33 @@ + + + + + + + + + + + diff --git a/res/drawable/ic_homepage_accessibility_v2.xml b/res/drawable/ic_homepage_accessibility_v2.xml new file mode 100644 index 00000000000..24ca8cf20f9 --- /dev/null +++ b/res/drawable/ic_homepage_accessibility_v2.xml @@ -0,0 +1,33 @@ + + + + + + + + + + + diff --git a/res/drawable/ic_homepage_accounts_v2.xml b/res/drawable/ic_homepage_accounts_v2.xml new file mode 100644 index 00000000000..6ea981ff206 --- /dev/null +++ b/res/drawable/ic_homepage_accounts_v2.xml @@ -0,0 +1,33 @@ + + + + + + + + + + + diff --git a/res/drawable/ic_homepage_apps_v2.xml b/res/drawable/ic_homepage_apps_v2.xml new file mode 100644 index 00000000000..c6ac0c4f6da --- /dev/null +++ b/res/drawable/ic_homepage_apps_v2.xml @@ -0,0 +1,33 @@ + + + + + + + + + + + diff --git a/res/drawable/ic_homepage_battery_v2.xml b/res/drawable/ic_homepage_battery_v2.xml new file mode 100644 index 00000000000..680031fe592 --- /dev/null +++ b/res/drawable/ic_homepage_battery_v2.xml @@ -0,0 +1,33 @@ + + + + + + + + + + + diff --git a/res/drawable/ic_homepage_connected_device_v2.xml b/res/drawable/ic_homepage_connected_device_v2.xml new file mode 100644 index 00000000000..f3e95d23f91 --- /dev/null +++ b/res/drawable/ic_homepage_connected_device_v2.xml @@ -0,0 +1,33 @@ + + + + + + + + + + + diff --git a/res/drawable/ic_homepage_display_v2.xml b/res/drawable/ic_homepage_display_v2.xml new file mode 100644 index 00000000000..e4014ee4daa --- /dev/null +++ b/res/drawable/ic_homepage_display_v2.xml @@ -0,0 +1,33 @@ + + + + + + + + + + + diff --git a/res/drawable/ic_homepage_emergency_v2.xml b/res/drawable/ic_homepage_emergency_v2.xml new file mode 100644 index 00000000000..86d1470f5ea --- /dev/null +++ b/res/drawable/ic_homepage_emergency_v2.xml @@ -0,0 +1,33 @@ + + + + + + + + + + + diff --git a/res/drawable/ic_homepage_location_v2.xml b/res/drawable/ic_homepage_location_v2.xml new file mode 100644 index 00000000000..5dc72eb1855 --- /dev/null +++ b/res/drawable/ic_homepage_location_v2.xml @@ -0,0 +1,33 @@ + + + + + + + + + + + diff --git a/res/drawable/ic_homepage_network_v2.xml b/res/drawable/ic_homepage_network_v2.xml new file mode 100644 index 00000000000..d3b33e96fe2 --- /dev/null +++ b/res/drawable/ic_homepage_network_v2.xml @@ -0,0 +1,33 @@ + + + + + + + + + + + diff --git a/res/drawable/ic_homepage_notification_v2.xml b/res/drawable/ic_homepage_notification_v2.xml new file mode 100644 index 00000000000..9b57456f277 --- /dev/null +++ b/res/drawable/ic_homepage_notification_v2.xml @@ -0,0 +1,33 @@ + + + + + + + + + + + diff --git a/res/drawable/ic_homepage_privacy_v2.xml b/res/drawable/ic_homepage_privacy_v2.xml new file mode 100644 index 00000000000..56e6da82ce8 --- /dev/null +++ b/res/drawable/ic_homepage_privacy_v2.xml @@ -0,0 +1,33 @@ + + + + + + + + + + + diff --git a/res/drawable/ic_homepage_security_v2.xml b/res/drawable/ic_homepage_security_v2.xml new file mode 100644 index 00000000000..5e33add6613 --- /dev/null +++ b/res/drawable/ic_homepage_security_v2.xml @@ -0,0 +1,33 @@ + + + + + + + + + + + diff --git a/res/drawable/ic_homepage_sound_v2.xml b/res/drawable/ic_homepage_sound_v2.xml new file mode 100644 index 00000000000..8561820e549 --- /dev/null +++ b/res/drawable/ic_homepage_sound_v2.xml @@ -0,0 +1,33 @@ + + + + + + + + + + + diff --git a/res/drawable/ic_homepage_storage_v2.xml b/res/drawable/ic_homepage_storage_v2.xml new file mode 100644 index 00000000000..1a8b7d28b4e --- /dev/null +++ b/res/drawable/ic_homepage_storage_v2.xml @@ -0,0 +1,33 @@ + + + + + + + + + + + diff --git a/res/drawable/ic_homepage_support_v2.xml b/res/drawable/ic_homepage_support_v2.xml new file mode 100644 index 00000000000..81399738279 --- /dev/null +++ b/res/drawable/ic_homepage_support_v2.xml @@ -0,0 +1,33 @@ + + + + + + + + + + + diff --git a/res/drawable/ic_homepage_system_dashboard_v2.xml b/res/drawable/ic_homepage_system_dashboard_v2.xml new file mode 100644 index 00000000000..7c016a2080f --- /dev/null +++ b/res/drawable/ic_homepage_system_dashboard_v2.xml @@ -0,0 +1,33 @@ + + + + + + + + + + + diff --git a/res/drawable/ic_homepage_wallpaper_v2.xml b/res/drawable/ic_homepage_wallpaper_v2.xml new file mode 100644 index 00000000000..ee16339ac95 --- /dev/null +++ b/res/drawable/ic_homepage_wallpaper_v2.xml @@ -0,0 +1,33 @@ + + + + + + + + + + + diff --git a/res/layout/homepage_preference.xml b/res/layout/homepage_preference.xml new file mode 100644 index 00000000000..c08a74f2418 --- /dev/null +++ b/res/layout/homepage_preference.xml @@ -0,0 +1,65 @@ + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/res/layout/search_bar.xml b/res/layout/search_bar.xml index d3e98c37ea3..c4dd15dc243 100644 --- a/res/layout/search_bar.xml +++ b/res/layout/search_bar.xml @@ -20,7 +20,10 @@ xmlns:app="http://schemas.android.com/apk/res-auto" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_margin="@dimen/search_bar_margin" + android:layout_marginTop="@dimen/search_bar_margin" + android:layout_marginStart="@dimen/search_bar_margin" + android:layout_marginEnd="@dimen/search_bar_margin" + android:layout_marginBottom="16dp" app:layout_scrollFlags="scroll|enterAlways"> 6dp + + 48dp + + + 12dp + 12dp diff --git a/res/values/styles.xml b/res/values/styles.xml index 4ab1e6c90ec..e75766d36e2 100644 --- a/res/values/styles.xml +++ b/res/values/styles.xml @@ -312,6 +312,12 @@ @dimen/search_bar_text_size + +