From 3bb961affdfada4d5b03e6a72e9ea37fecf0f7b4 Mon Sep 17 00:00:00 2001 From: Aaron Huang Date: Mon, 1 Feb 2021 18:48:33 +0800 Subject: [PATCH] Replace @hide API with public API ProxyInfo is inculded in framework-connectivity module which should not have external dependencies on its hidden API. Thus, migrate getExclusionListAsString to getExclusionList. Bug: 178777253 Test: build Change-Id: I64b9d5be062bec43c7be3ea68d1f63054319df2d Change-Id: I400df793fc669d0e574fb4cf022d021d99859d53 --- src/com/android/settings/ProxySelector.java | 3 ++- src/com/android/settings/wifi/WifiConfigController.java | 4 +++- src/com/android/settings/wifi/WifiConfigController2.java | 4 +++- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/com/android/settings/ProxySelector.java b/src/com/android/settings/ProxySelector.java index 625369e7915..0b6f16a5dcd 100644 --- a/src/com/android/settings/ProxySelector.java +++ b/src/com/android/settings/ProxySelector.java @@ -41,6 +41,7 @@ import android.widget.TextView; import androidx.appcompat.app.AlertDialog; +import com.android.net.module.util.ProxyUtils; import com.android.settings.SettingsPreferenceFragment.SettingsDialogFragment; import com.android.settings.core.InstrumentedFragment; @@ -151,7 +152,7 @@ public class ProxySelector extends InstrumentedFragment implements DialogCreatab if (proxy != null) { hostname = proxy.getHost(); port = proxy.getPort(); - exclList = proxy.getExclusionListAsString(); + exclList = ProxyUtils.exclusionListAsString(proxy.getExclusionList()); } if (hostname == null) { diff --git a/src/com/android/settings/wifi/WifiConfigController.java b/src/com/android/settings/wifi/WifiConfigController.java index 07d270d422e..29e4fb73f48 100644 --- a/src/com/android/settings/wifi/WifiConfigController.java +++ b/src/com/android/settings/wifi/WifiConfigController.java @@ -69,6 +69,7 @@ import android.widget.TextView; import androidx.annotation.VisibleForTesting; +import com.android.net.module.util.ProxyUtils; import com.android.settings.ProxySelector; import com.android.settings.R; import com.android.settings.wifi.details.WifiPrivacyPreferenceController; @@ -1428,7 +1429,8 @@ public class WifiConfigController implements TextWatcher, if (proxyProperties != null) { mProxyHostView.setText(proxyProperties.getHost()); mProxyPortView.setText(Integer.toString(proxyProperties.getPort())); - mProxyExclusionListView.setText(proxyProperties.getExclusionListAsString()); + mProxyExclusionListView.setText( + ProxyUtils.exclusionListAsString(proxyProperties.getExclusionList())); } } } else if (mProxySettingsSpinner.getSelectedItemPosition() == PROXY_PAC) { diff --git a/src/com/android/settings/wifi/WifiConfigController2.java b/src/com/android/settings/wifi/WifiConfigController2.java index 7ae6061c4df..4d31105cd62 100644 --- a/src/com/android/settings/wifi/WifiConfigController2.java +++ b/src/com/android/settings/wifi/WifiConfigController2.java @@ -67,6 +67,7 @@ import android.widget.TextView; import androidx.annotation.VisibleForTesting; +import com.android.net.module.util.ProxyUtils; import com.android.settings.ProxySelector; import com.android.settings.R; import com.android.settings.wifi.details.WifiPrivacyPreferenceController; @@ -1410,7 +1411,8 @@ public class WifiConfigController2 implements TextWatcher, if (proxyProperties != null) { mProxyHostView.setText(proxyProperties.getHost()); mProxyPortView.setText(Integer.toString(proxyProperties.getPort())); - mProxyExclusionListView.setText(proxyProperties.getExclusionListAsString()); + mProxyExclusionListView.setText( + ProxyUtils.exclusionListAsString(proxyProperties.getExclusionList())); } } } else if (mProxySettingsSpinner.getSelectedItemPosition() == PROXY_PAC) {