From 736eae02bd49e757a64e670881326536d124e39d Mon Sep 17 00:00:00 2001 From: Raff Tsai Date: Wed, 19 Dec 2018 17:13:32 +0800 Subject: [PATCH] Fix talkback speaks "double tap to activate" on preference Talkback will speak "double tap to activate" on clickable view. But the SliderPreference is not clickable. Because it is default clickable for Preference. We should set android:selectable in every SliderPreference. Change-Id: I7bf09c2a7e2d8688352e35c1882674b6e73e5db7 Fixes: 121111172 Test: Manual --- .../settings/notification/VolumeSeekBarPreference.java | 5 +++++ src/com/android/settings/widget/SeekBarPreference.java | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/src/com/android/settings/notification/VolumeSeekBarPreference.java b/src/com/android/settings/notification/VolumeSeekBarPreference.java index 2ef33d4ab04..13f630004d1 100644 --- a/src/com/android/settings/notification/VolumeSeekBarPreference.java +++ b/src/com/android/settings/notification/VolumeSeekBarPreference.java @@ -80,6 +80,11 @@ public class VolumeSeekBarPreference extends SeekBarPreference { mAudioManager = (AudioManager) context.getSystemService(Context.AUDIO_SERVICE); } + @Override + public boolean isSelectable() { + return false; + } + public void setStream(int stream) { mStream = stream; setMax(mAudioManager.getStreamMaxVolume(mStream)); diff --git a/src/com/android/settings/widget/SeekBarPreference.java b/src/com/android/settings/widget/SeekBarPreference.java index 2c57bb31a94..f4d2aac83d4 100644 --- a/src/com/android/settings/widget/SeekBarPreference.java +++ b/src/com/android/settings/widget/SeekBarPreference.java @@ -91,6 +91,11 @@ public class SeekBarPreference extends RestrictedPreference notifyChanged(); } + @Override + public boolean isSelectable() { + return false; + } + @Override public void onBindViewHolder(PreferenceViewHolder view) { super.onBindViewHolder(view);