From 8b822858cfee30dc77ba2c24ac385283c5cfe502 Mon Sep 17 00:00:00 2001 From: "J. Eason" Date: Thu, 16 Sep 2021 14:59:53 +0000 Subject: [PATCH 1/2] Fix Wireless debugging icon alignment on developer options screen. Added icon and dividers to realign and balance the screen layout. Bug: 200139203 Test: atest SettingsUnitTests and manual Change-Id: Ie5e89fd952f85bdf3fe0009b25ff127493e3cb95 (cherry picked from commit 4677bfbe253248f6a8d81b95a5644a289ff150eb) --- res/xml/adb_wireless_settings.xml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/res/xml/adb_wireless_settings.xml b/res/xml/adb_wireless_settings.xml index 8a9cfe6d8cc..7d372070f37 100644 --- a/res/xml/adb_wireless_settings.xml +++ b/res/xml/adb_wireless_settings.xml @@ -42,7 +42,8 @@ + android:layout="@layout/preference_category_no_label" + settings:allowDividerAbove="true"> @@ -59,7 +61,8 @@ + android:title="@string/adb_paired_devices_title" + settings:allowDividerAbove="true"/> Date: Thu, 9 Sep 2021 19:09:50 +0800 Subject: [PATCH 2/2] Use the correct pageId for the existing accessibility page * correct page id for "Accessibility timeout" and "Select to Speak" Bug: 190344664 Test: build pass Change-Id: I3f6b2c389c1ca77e4d3fca3601915caa7a9dd6f8 --- .../AccessibilityControlTimeoutPreferenceFragment.java | 2 +- .../ToggleSelectToSpeakPreferenceFragmentForSetupWizard.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/com/android/settings/accessibility/AccessibilityControlTimeoutPreferenceFragment.java b/src/com/android/settings/accessibility/AccessibilityControlTimeoutPreferenceFragment.java index 1e2a2b47b8a..c7a9b10aab9 100644 --- a/src/com/android/settings/accessibility/AccessibilityControlTimeoutPreferenceFragment.java +++ b/src/com/android/settings/accessibility/AccessibilityControlTimeoutPreferenceFragment.java @@ -69,7 +69,7 @@ public final class AccessibilityControlTimeoutPreferenceFragment extends Dashboa @Override public int getMetricsCategory() { - return SettingsEnums.ACCESSIBILITY; + return SettingsEnums.ACCESSIBILITY_TIMEOUT; } @Override diff --git a/src/com/android/settings/accessibility/ToggleSelectToSpeakPreferenceFragmentForSetupWizard.java b/src/com/android/settings/accessibility/ToggleSelectToSpeakPreferenceFragmentForSetupWizard.java index 4334cd0e7a0..9ca1f199756 100644 --- a/src/com/android/settings/accessibility/ToggleSelectToSpeakPreferenceFragmentForSetupWizard.java +++ b/src/com/android/settings/accessibility/ToggleSelectToSpeakPreferenceFragmentForSetupWizard.java @@ -33,7 +33,7 @@ public class ToggleSelectToSpeakPreferenceFragmentForSetupWizard @Override public int getMetricsCategory() { - return SettingsEnums.SUW_ACCESSIBILITY_TOGGLE_SCREEN_READER; + return SettingsEnums.SUW_ACCESSIBILITY_TOGGLE_SELECT_TO_SPEAK; } @Override