diff --git a/res/xml/storage_dashboard_fragment.xml b/res/xml/storage_dashboard_fragment.xml index f6d63101382..e08ca961fd9 100644 --- a/res/xml/storage_dashboard_fragment.xml +++ b/res/xml/storage_dashboard_fragment.xml @@ -43,4 +43,10 @@ android:key="pref_system" android:title="@string/storage_detail_system"> + + \ No newline at end of file diff --git a/src/com/android/settings/deviceinfo/ManageStoragePreferenceController.java b/src/com/android/settings/deviceinfo/ManageStoragePreferenceController.java index 3170a87f899..769b69bb72e 100644 --- a/src/com/android/settings/deviceinfo/ManageStoragePreferenceController.java +++ b/src/com/android/settings/deviceinfo/ManageStoragePreferenceController.java @@ -16,14 +16,13 @@ package com.android.settings.deviceinfo; import android.content.Context; -import android.support.v7.preference.Preference; import com.android.settings.R; import com.android.settings.core.PreferenceController; public class ManageStoragePreferenceController extends PreferenceController { - public static final String KEY_MANAGE_STORAGE = "footer_preference"; + public static final String KEY_MANAGE_STORAGE = "manage_storage"; public ManageStoragePreferenceController(Context context) { super(context); diff --git a/src/com/android/settings/deviceinfo/StorageDashboardFragment.java b/src/com/android/settings/deviceinfo/StorageDashboardFragment.java index 6ec1b731295..914a8fe535a 100644 --- a/src/com/android/settings/deviceinfo/StorageDashboardFragment.java +++ b/src/com/android/settings/deviceinfo/StorageDashboardFragment.java @@ -32,7 +32,6 @@ import com.android.settings.deviceinfo.storage.StorageSummaryDonutPreferenceCont import com.android.settings.overlay.FeatureFactory; import com.android.settings.search.BaseSearchIndexProvider; import com.android.settings.search.Indexable; -import com.android.settings.widget.FooterPreference; import com.android.settingslib.deviceinfo.StorageManagerVolumeProvider; import java.util.ArrayList; @@ -84,13 +83,6 @@ public class StorageDashboardFragment extends DashboardFragment { mSummaryController.updateBytes(usedBytes, totalSize); mPreferenceController.setVolume(mVolume); mPreferenceController.setSystemSize(systemSize); - - // Initialize the footer preference to go to the smart storage management. - final FooterPreference pref = mFooterPreferenceMixin.createFooterPreference(); - pref.setTitle(R.string.storage_menu_manage); - pref.setFragment("com.android.settings.deletionhelper.AutomaticStorageManagerSettings"); - pref.setIcon(R.drawable.ic_settings_storage); - pref.setEnabled(true); } @Override diff --git a/tests/app/src/com/android/settings/deviceinfo/StorageDashboardFragmentEspressoTest.java b/tests/app/src/com/android/settings/deviceinfo/StorageDashboardFragmentEspressoTest.java new file mode 100644 index 00000000000..b43a5ba882d --- /dev/null +++ b/tests/app/src/com/android/settings/deviceinfo/StorageDashboardFragmentEspressoTest.java @@ -0,0 +1,40 @@ +package com.android.settings.deviceinfo; + +import android.support.test.espresso.intent.rule.IntentsTestRule; +import android.support.test.filters.SmallTest; +import android.support.test.runner.AndroidJUnitRunner; +import com.android.settings.R; +import com.android.settings.Settings.StorageDashboardActivity; +import com.android.settings.deletionhelper.AutomaticStorageManagerSettings; +import org.junit.Rule; +import org.junit.Test; +import org.junit.runner.RunWith; + +import static android.support.test.espresso.Espresso.onView; +import static android.support.test.espresso.action.ViewActions.click; +import static android.support.test.espresso.intent.Intents.intended; +import static android.support.test.espresso.intent.matcher.IntentMatchers.hasExtra; +import static android.support.test.espresso.matcher.ViewMatchers.withText; +import static org.hamcrest.Matchers.containsString; +import static org.hamcrest.Matchers.equalTo; + +@SmallTest +public class StorageDashboardFragmentEspressoTest { + + public static final String EXTRA_KEY = ":settings:show_fragment"; + + @Rule + public IntentsTestRule mActivityRule = + new IntentsTestRule<>(StorageDashboardActivity.class, true, true); + + @Test + public void testStorageManagePreference_canClickTextView() throws InterruptedException { + // Click on the actual textbox instead of just somewhere in the preference + onView(withText(R.string.storage_menu_manage)).perform(click()); + + // Check that it worked by seeing if we switched screens + intended(hasExtra(equalTo(EXTRA_KEY), + containsString(AutomaticStorageManagerSettings.class.getName()))); + + } +}