diff --git a/res/layout/preference_radio.xml b/res/layout/preference_radio.xml new file mode 100644 index 00000000000..1ce8b8109d3 --- /dev/null +++ b/res/layout/preference_radio.xml @@ -0,0 +1,104 @@ + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/src/com/android/settings/applications/defaultapps/DefaultAppPickerFragment.java b/src/com/android/settings/applications/defaultapps/DefaultAppPickerFragment.java index cc3b3d1bdbd..ab81290d969 100644 --- a/src/com/android/settings/applications/defaultapps/DefaultAppPickerFragment.java +++ b/src/com/android/settings/applications/defaultapps/DefaultAppPickerFragment.java @@ -86,11 +86,6 @@ public abstract class DefaultAppPickerFragment extends RadioButtonPickerFragment } } - @Override - protected int getRadioButtonPreferenceCustomLayoutResId() { - return R.layout.preference_app; - } - protected ConfirmationDialogFragment newConfirmationDialogFragment(String selectedKey, CharSequence confirmationMessage) { final ConfirmationDialogFragment fragment = new ConfirmationDialogFragment(); diff --git a/src/com/android/settings/widget/RadioButtonPreference.java b/src/com/android/settings/widget/RadioButtonPreference.java index d386698c020..2d3068719d6 100644 --- a/src/com/android/settings/widget/RadioButtonPreference.java +++ b/src/com/android/settings/widget/RadioButtonPreference.java @@ -47,6 +47,8 @@ public class RadioButtonPreference extends CheckBoxPreference { public RadioButtonPreference(Context context, AttributeSet attrs, int defStyle) { super(context, attrs, defStyle); setWidgetLayoutResource(R.layout.preference_widget_radiobutton); + setLayoutResource(R.layout.preference_radio); + setIconSpaceReserved(false); } public RadioButtonPreference(Context context, AttributeSet attrs) { diff --git a/tests/robotests/src/com/android/settings/applications/defaultapps/DefaultAppPickerFragmentTest.java b/tests/robotests/src/com/android/settings/applications/defaultapps/DefaultAppPickerFragmentTest.java index 1c0130ac017..4377c4ff537 100644 --- a/tests/robotests/src/com/android/settings/applications/defaultapps/DefaultAppPickerFragmentTest.java +++ b/tests/robotests/src/com/android/settings/applications/defaultapps/DefaultAppPickerFragmentTest.java @@ -16,7 +16,6 @@ package com.android.settings.applications.defaultapps; -import static com.google.common.truth.Truth.assertThat; import static org.mockito.Matchers.any; import static org.mockito.Matchers.eq; import static org.mockito.Mockito.doReturn; @@ -31,7 +30,6 @@ import android.support.v7.preference.PreferenceScreen; import android.util.Pair; import com.android.internal.logging.nano.MetricsProto; -import com.android.settings.R; import com.android.settings.testutils.FakeFeatureFactory; import com.android.settings.testutils.SettingsRobolectricTestRunner; import com.android.settings.widget.RadioButtonPreference; @@ -96,12 +94,6 @@ public class DefaultAppPickerFragmentTest { any(Pair.class)); } - @Test - public void shouldHaveAppPreferenceLayout() { - assertThat(mFragment.getRadioButtonPreferenceCustomLayoutResId()) - .isEqualTo(R.layout.preference_app); - } - public static class TestFragment extends DefaultAppPickerFragment { boolean setDefaultAppKeyCalled; diff --git a/tests/robotests/src/com/android/settings/widget/RadioButtonPreferenceTest.java b/tests/robotests/src/com/android/settings/widget/RadioButtonPreferenceTest.java index e8a705c94c8..878bae4f1a2 100644 --- a/tests/robotests/src/com/android/settings/widget/RadioButtonPreferenceTest.java +++ b/tests/robotests/src/com/android/settings/widget/RadioButtonPreferenceTest.java @@ -16,6 +16,7 @@ package com.android.settings.widget; +import static com.google.common.truth.Truth.assertThat; import static junit.framework.Assert.assertEquals; import static org.mockito.Mockito.mock; @@ -45,6 +46,16 @@ public class RadioButtonPreferenceTest { mPreference = new RadioButtonPreference(mContext); } + @Test + public void shouldHaveRadioPreferenceLayout() { + assertThat(mPreference.getLayoutResource()).isEqualTo(R.layout.preference_radio); + } + + @Test + public void iconSpaceReservedShouldBeFalse() { + assertThat(mPreference.isIconSpaceReserved()).isFalse(); + } + @Test public void summary_containerShouldBeVisible() { mPreference.setSummary("some summary");