diff --git a/res/xml/night_display_settings.xml b/res/xml/night_display_settings.xml index dc4fecd8b77..8f2bb976b0e 100644 --- a/res/xml/night_display_settings.xml +++ b/res/xml/night_display_settings.xml @@ -16,7 +16,8 @@ + android:title="@string/night_display_title" + android:key="night_display_title"> { + final LocalTime time = LocalTime.of(hourOfDay, minute); + if (dialogId == DIALOG_START_TIME) { + mController.setCustomStartTime(time); + } else { + mController.setCustomEndTime(time); } }, initialTime.getHour(), initialTime.getMinute(), use24HourFormat); } @@ -247,4 +251,23 @@ public class NightDisplaySettings extends SettingsPreferenceFragment public int getMetricsCategory() { return MetricsEvent.NIGHT_DISPLAY_SETTINGS; } + + public static final Indexable.SearchIndexProvider SEARCH_INDEX_DATA_PROVIDER = + new BaseSearchIndexProvider() { + @Override + public List getXmlResourcesToIndex(Context context, + boolean enabled) { + final ArrayList result = new ArrayList<>(); + + final SearchIndexableResource sir = new SearchIndexableResource(context); + sir.xmlResId = R.xml.night_display_settings; + result.add(sir); + return result; + } + + @Override + protected boolean isPageSearchEnabled(Context context) { + return ColorDisplayController.isAvailable(context); + } + }; } diff --git a/src/com/android/settings/search/SearchIndexableResources.java b/src/com/android/settings/search/SearchIndexableResources.java index 82ab0205800..1f8887246a5 100644 --- a/src/com/android/settings/search/SearchIndexableResources.java +++ b/src/com/android/settings/search/SearchIndexableResources.java @@ -42,6 +42,7 @@ import com.android.settings.development.DevelopmentSettingsDashboardFragment; import com.android.settings.deviceinfo.StorageDashboardFragment; import com.android.settings.deviceinfo.StorageSettings; import com.android.settings.display.AmbientDisplaySettings; +import com.android.settings.display.NightDisplaySettings; import com.android.settings.display.ScreenZoomSettings; import com.android.settings.dream.DreamSettings; import com.android.settings.enterprise.EnterprisePrivacySettings; @@ -170,6 +171,7 @@ public final class SearchIndexableResources { addIndex(WifiDisplaySettings.class); addIndex(ZenModeBehaviorSettings.class); addIndex(ZenModeAutomationSettings.class); + addIndex(NightDisplaySettings.class); } private SearchIndexableResources() { diff --git a/tests/robotests/assets/grandfather_not_implementing_indexable b/tests/robotests/assets/grandfather_not_implementing_indexable index 681e8f66ba0..451bcd473dc 100644 --- a/tests/robotests/assets/grandfather_not_implementing_indexable +++ b/tests/robotests/assets/grandfather_not_implementing_indexable @@ -9,7 +9,6 @@ com.android.settings.accessibility.AccessibilitySettingsForSetupWizard com.android.settings.deviceinfo.ImeiInformation com.android.settings.datausage.DataUsageList com.android.settings.vpn2.AppManagementFragment -com.android.settings.display.NightDisplaySettings com.android.settings.vpn2.VpnSettings com.android.settings.fingerprint.FingerprintSettings$FingerprintSettingsFragment com.android.settings.applications.ProcessStatsDetail diff --git a/tests/robotests/src/com/android/settings/display/NightDisplaySettingsTest.java b/tests/robotests/src/com/android/settings/display/NightDisplaySettingsTest.java new file mode 100644 index 00000000000..113e7ecbc75 --- /dev/null +++ b/tests/robotests/src/com/android/settings/display/NightDisplaySettingsTest.java @@ -0,0 +1,60 @@ +/* + * Copyright (C) 2017 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package com.android.settings.display; + +import static com.google.common.truth.Truth.assertThat; + +import android.content.Context; +import android.provider.SearchIndexableResource; + +import com.android.settings.R; +import com.android.settings.TestConfig; +import com.android.settings.testutils.SettingsRobolectricTestRunner; + +import org.junit.Before; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.robolectric.RuntimeEnvironment; +import org.robolectric.annotation.Config; + +import java.util.ArrayList; +import java.util.List; + +@RunWith(SettingsRobolectricTestRunner.class) +@Config(manifest = TestConfig.MANIFEST_PATH, sdk = TestConfig.SDK_VERSION_O) +public class NightDisplaySettingsTest { + + private Context mContext; + + @Before + public void setUp() { + mContext = RuntimeEnvironment.application; + } + + @Test + public void testNightDisplayIndexing_containsResource() { + List resources = + NightDisplaySettings.SEARCH_INDEX_DATA_PROVIDER.getXmlResourcesToIndex(mContext, + true /* enabled */); + + List indexedXml = new ArrayList<>(); + for (SearchIndexableResource resource : resources) { + indexedXml.add(resource.xmlResId); + } + + assertThat(indexedXml).contains(R.xml.night_display_settings); + } +}