From 2d57d002ae9daae3c450734bc7992ba0bfc1cc05 Mon Sep 17 00:00:00 2001 From: Edgar Wang Date: Tue, 15 Aug 2023 19:48:13 +0800 Subject: [PATCH] Update the API usage to get total size of devices StorageStatsManager fixed in StorageStatsService#getTotalBytes So that we should change back to call the API. Bug: 295358118 Bug: 288103116 Test: verified manually Change-Id: I3dcc9698403612f961cf0de41925dcbcb43e260b --- src/com/android/settings/Utils.java | 11 ----------- .../settings/deviceinfo/StorageCategoryFragment.java | 4 +--- .../settings/deviceinfo/StorageDashboardFragment.java | 4 +--- .../TopLevelStoragePreferenceController.java | 4 +--- .../StorageUsageProgressBarPreferenceController.java | 5 +---- 5 files changed, 4 insertions(+), 24 deletions(-) diff --git a/src/com/android/settings/Utils.java b/src/com/android/settings/Utils.java index dda5b24b310..910ab81031a 100644 --- a/src/com/android/settings/Utils.java +++ b/src/com/android/settings/Utils.java @@ -66,7 +66,6 @@ import android.os.BatteryManager; import android.os.Binder; import android.os.Build; import android.os.Bundle; -import android.os.Environment; import android.os.IBinder; import android.os.INetworkManagementService; import android.os.RemoteException; @@ -1354,14 +1353,4 @@ public final class Utils extends com.android.settingslib.Utils { return dreamsSupported && (!dreamsOnlyEnabledForDockUser || canCurrentUserDream(context)); } - /** - * Get private total size directly. - * Referred from StorageManager - */ - public static long getPrimaryStorageSize() { - // TODO(b/288103116): remove this method once support by StorageManager. - return Environment.getDataDirectory().getTotalSpace() - + Environment.getRootDirectory().getTotalSpace(); - } - } diff --git a/src/com/android/settings/deviceinfo/StorageCategoryFragment.java b/src/com/android/settings/deviceinfo/StorageCategoryFragment.java index d1d4cbe7f50..52f453d46a9 100644 --- a/src/com/android/settings/deviceinfo/StorageCategoryFragment.java +++ b/src/com/android/settings/deviceinfo/StorageCategoryFragment.java @@ -211,9 +211,7 @@ public class StorageCategoryFragment extends DashboardFragment setLoading(false /* loading */, false /* animate */); - // TODO(b/288103116): replace with new API to get TotalBytes before rounding - // once support by StorageManager. - final long privateUsedBytes = Utils.getPrimaryStorageSize() - mStorageInfo.freeBytes; + final long privateUsedBytes = mStorageInfo.totalBytes - mStorageInfo.freeBytes; mPreferenceController.setVolume(mSelectedStorageEntry.getVolumeInfo()); mPreferenceController.setUsedSize(privateUsedBytes); mPreferenceController.setTotalSize(mStorageInfo.totalBytes); diff --git a/src/com/android/settings/deviceinfo/StorageDashboardFragment.java b/src/com/android/settings/deviceinfo/StorageDashboardFragment.java index 4138057a90c..f31f2be0049 100644 --- a/src/com/android/settings/deviceinfo/StorageDashboardFragment.java +++ b/src/com/android/settings/deviceinfo/StorageDashboardFragment.java @@ -387,9 +387,7 @@ public class StorageDashboardFragment extends DashboardFragment setLoading(false /* loading */, false /* animate */); - // TODO(b/288103116): replace with new API to get TotalBytes before rounding - // once support by StorageManager. - final long privateUsedBytes = Utils.getPrimaryStorageSize() - mStorageInfo.freeBytes; + final long privateUsedBytes = mStorageInfo.totalBytes - mStorageInfo.freeBytes; mPreferenceController.setVolume(mSelectedStorageEntry.getVolumeInfo()); mPreferenceController.setUsedSize(privateUsedBytes); mPreferenceController.setTotalSize(mStorageInfo.totalBytes); diff --git a/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceController.java b/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceController.java index 43dc9dd0d15..ccae7e92ab1 100644 --- a/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceController.java +++ b/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceController.java @@ -75,9 +75,7 @@ public class TopLevelStoragePreferenceController extends BasePreferenceControlle final PrivateStorageInfo info = PrivateStorageInfo.getPrivateStorageInfo( getStorageManagerVolumeProvider()); - // TODO(b/288103116): replace with new API to get TotalBytes before rounding - // once support by StorageManager. - long usedBytes = Utils.getPrimaryStorageSize() - info.freeBytes; + long usedBytes = info.totalBytes - info.freeBytes; storageCacheHelper.cacheUsedSize(usedBytes); ThreadUtils.postOnMainThread(() -> { preference.setSummary( diff --git a/src/com/android/settings/deviceinfo/storage/StorageUsageProgressBarPreferenceController.java b/src/com/android/settings/deviceinfo/storage/StorageUsageProgressBarPreferenceController.java index 23559d4db00..be2a64abf58 100644 --- a/src/com/android/settings/deviceinfo/storage/StorageUsageProgressBarPreferenceController.java +++ b/src/com/android/settings/deviceinfo/storage/StorageUsageProgressBarPreferenceController.java @@ -26,7 +26,6 @@ import androidx.preference.Preference; import androidx.preference.PreferenceScreen; import com.android.settings.R; -import com.android.settings.Utils; import com.android.settings.core.BasePreferenceController; import com.android.settingslib.utils.ThreadUtils; import com.android.settingslib.widget.UsageProgressBarPreference; @@ -93,9 +92,7 @@ public class StorageUsageProgressBarPreferenceController extends BasePreferenceC if (mStorageEntry.isPrivate()) { // StorageStatsManager can only query private storages. mTotalBytes = mStorageStatsManager.getTotalBytes(mStorageEntry.getFsUuid()); - // TODO(b/288103116): replace with new API to get TotalBytes before rounding - // once support by StorageManager. - mUsedBytes = Utils.getPrimaryStorageSize() + mUsedBytes = mTotalBytes - mStorageStatsManager.getFreeBytes(mStorageEntry.getFsUuid()); } else { final File rootFile = mStorageEntry.getPath();