PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix failure test cases in AccessibilityShortcutPreferenceFragmentTest

Browse Source 
Root Cause: The lifecycle for
AccessibilityShortcutPreferenceFragmentTest did not be called correctly.

Solution:
* Call onAttach() before onCreate() to some config, e.g.
FeatureFactory.
* Use ShadowFragment.class that we usually do in accessibility
tests.

Fix: 200906425
Fix: 201020915
Test: atest AccessibilityShortcutPreferenceFragmentTest
Change-Id: I3391c0a4a2c7c361a44c7d282b1d5d3e75a28a39
This commit is contained in:
jasonwshsu
2021-09-26 02:01:27 +08:00
parent 89abc263e0
commit 2d3894a148
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/robotests/src/com/android/settings/accessibility/AccessibilityShortcutPreferenceFragmentTest.java
View File

@@ -41,7 +41,6 @@ import com.android.settings.R;
import com.android.settings.testutils.shadow.ShadowFragment; import com.android.settings.testutils.shadow.ShadowFragment;
import org.junit.Before; import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.mockito.Answers; import org.mockito.Answers;
@@ -165,7 +164,6 @@ public class AccessibilityShortcutPreferenceFragmentTest {
assertThat(checkboxValue).isEqualTo(AccessibilityUtil.UserShortcutType.HARDWARE); assertThat(checkboxValue).isEqualTo(AccessibilityUtil.UserShortcutType.HARDWARE);
} }
@Ignore
@Test @Test
@Config(shadows = ShadowFragment.class) @Config(shadows = ShadowFragment.class)
public void restoreValueFromSavedInstanceState_assignToVariable() { public void restoreValueFromSavedInstanceState_assignToVariable() {
@@ -182,8 +180,8 @@ public class AccessibilityShortcutPreferenceFragmentTest {
savedInstanceState.putInt(KEY_SAVED_USER_SHORTCUT_TYPE, savedInstanceState.putInt(KEY_SAVED_USER_SHORTCUT_TYPE,
AccessibilityUtil.UserShortcutType.SOFTWARE AccessibilityUtil.UserShortcutType.SOFTWARE
| AccessibilityUtil.UserShortcutType.HARDWARE); | AccessibilityUtil.UserShortcutType.HARDWARE);
mFragment.onCreate(savedInstanceState);
mFragment.onAttach(mContext); mFragment.onAttach(mContext);
mFragment.onCreate(savedInstanceState);
mFragment.setupEditShortcutDialog(dialog); mFragment.setupEditShortcutDialog(dialog);
final int value = mFragment.getShortcutTypeCheckBoxValue(); final int value = mFragment.getShortcutTypeCheckBoxValue();
mFragment.saveNonEmptyUserShortcutType(value); mFragment.saveNonEmptyUserShortcutType(value);
@@ -197,10 +195,11 @@ public class AccessibilityShortcutPreferenceFragmentTest {
} }
@Test @Test
@Ignore @Config(shadows = ShadowFragment.class)
public void showGeneralCategory_shouldInitCategory() { public void showGeneralCategory_shouldInitCategory() {
final Bundle savedInstanceState = new Bundle(); final Bundle savedInstanceState = new Bundle();
when(mFragment.showGeneralCategory()).thenReturn(true); when(mFragment.showGeneralCategory()).thenReturn(true);
mFragment.onAttach(mContext);
mFragment.onCreate(savedInstanceState); mFragment.onCreate(savedInstanceState);
verify(mFragment).initGeneralCategory(); verify(mFragment).initGeneralCategory();