diff --git a/res/values/strings.xml b/res/values/strings.xml index 9c87e87aeb8..e4cbb114285 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -5830,6 +5830,8 @@ History details View battery usage + + View usage for past 24 hours Battery usage @@ -5966,7 +5968,7 @@ Detect when apps drain battery - On / Detecting when apps drain battery + Detecting when apps drain battery Off @@ -6232,6 +6234,9 @@ Based on your routine + + Will turn on based on your routine + Based on percentage diff --git a/src/com/android/settings/fuelgauge/BatterySaverController.java b/src/com/android/settings/fuelgauge/BatterySaverController.java index fba163dd223..15070c3e8d2 100644 --- a/src/com/android/settings/fuelgauge/BatterySaverController.java +++ b/src/com/android/settings/fuelgauge/BatterySaverController.java @@ -111,7 +111,7 @@ public class BatterySaverController extends BasePreferenceController Utils.formatPercentage(percent)) : mContext.getString(R.string.battery_saver_off_summary); } else { - return mContext.getString(R.string.battery_saver_auto_routine); + return mContext.getString(R.string.battery_saver_pref_auto_routine_summary); } } diff --git a/src/com/android/settings/fuelgauge/batterytip/BatteryManagerPreferenceController.java b/src/com/android/settings/fuelgauge/batterytip/BatteryManagerPreferenceController.java index 9565036bfc8..790264cf313 100644 --- a/src/com/android/settings/fuelgauge/batterytip/BatteryManagerPreferenceController.java +++ b/src/com/android/settings/fuelgauge/batterytip/BatteryManagerPreferenceController.java @@ -19,7 +19,6 @@ package com.android.settings.fuelgauge.batterytip; import android.app.AppOpsManager; import android.content.Context; import android.os.UserManager; -import android.provider.Settings; import androidx.annotation.VisibleForTesting; import androidx.preference.Preference; @@ -34,7 +33,6 @@ import com.android.settings.overlay.FeatureFactory; */ public class BatteryManagerPreferenceController extends BasePreferenceController { private static final String KEY_BATTERY_MANAGER = "smart_battery_manager"; - private static final int ON = 1; private PowerUsageFeatureProvider mPowerUsageFeatureProvider; private AppOpsManager mAppOpsManager; private UserManager mUserManager; @@ -56,24 +54,17 @@ public class BatteryManagerPreferenceController extends BasePreferenceController public void updateState(Preference preference) { super.updateState(preference); final int num = BatteryTipUtils.getRestrictedAppsList(mAppOpsManager, mUserManager).size(); - final String setting = mPowerUsageFeatureProvider.isSmartBatterySupported() - ? Settings.Global.ADAPTIVE_BATTERY_MANAGEMENT_ENABLED - : Settings.Global.APP_AUTO_RESTRICTION_ENABLED; - final boolean featureOn = - Settings.Global.getInt(mContext.getContentResolver(), setting, ON) == ON; - updateSummary(preference, featureOn, num); + updateSummary(preference, num); } @VisibleForTesting - void updateSummary(Preference preference, boolean featureOn, int num) { + void updateSummary(Preference preference, int num) { if (num > 0) { preference.setSummary(mContext.getResources().getQuantityString( R.plurals.battery_manager_app_restricted, num, num)); - } else if (featureOn) { - preference.setSummary(R.string.battery_manager_on); } else { - preference.setSummary(R.string.battery_manager_off); + preference.setSummary(R.string.battery_manager_summary); } } } diff --git a/tests/robotests/src/com/android/settings/fuelgauge/BatterySaverControllerTest.java b/tests/robotests/src/com/android/settings/fuelgauge/BatterySaverControllerTest.java index b3b81969b8b..52f682cd8ab 100644 --- a/tests/robotests/src/com/android/settings/fuelgauge/BatterySaverControllerTest.java +++ b/tests/robotests/src/com/android/settings/fuelgauge/BatterySaverControllerTest.java @@ -105,7 +105,8 @@ public class BatterySaverControllerTest { Settings.Global.AUTOMATIC_POWER_SAVE_MODE, PowerManager.POWER_SAVE_MODE_TRIGGER_DYNAMIC); - assertThat(mBatterySaverController.getSummary()).isEqualTo("Based on your routine"); + assertThat(mBatterySaverController.getSummary()). + isEqualTo("Will turn on based on your routine"); } @Test diff --git a/tests/robotests/src/com/android/settings/fuelgauge/batterytip/BatteryManagerPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/fuelgauge/batterytip/BatteryManagerPreferenceControllerTest.java index 435aa8874fc..b01e3b1f66c 100644 --- a/tests/robotests/src/com/android/settings/fuelgauge/batterytip/BatteryManagerPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/fuelgauge/batterytip/BatteryManagerPreferenceControllerTest.java @@ -63,31 +63,20 @@ public class BatteryManagerPreferenceControllerTest { } @Test - public void updateState_smartBatteryOnWithRestrictApps_showSummary() { - mController.updateSummary(mPreference, true /* smartBatteryOn */, 2); + public void updateState_smartBatteryWithRestrictApps_showSummary() { + mController.updateSummary(mPreference, 2); assertThat(mPreference.getSummary()).isEqualTo("2 apps restricted"); } @Test - public void updateState_smartBatteryOnWithoutRestriction_showSummary() { + public void updateState_smartBatteryWithoutRestriction_showSummary() { when(mFeatureFactory.powerUsageFeatureProvider.isSmartBatterySupported()).thenReturn(true); Settings.Global.putInt(mContext.getContentResolver(), Settings.Global.ADAPTIVE_BATTERY_MANAGEMENT_ENABLED, ON); mController.updateState(mPreference); - assertThat(mPreference.getSummary()).isEqualTo("On / Detecting when apps drain battery"); - } - - @Test - public void updateState_smartBatteryOff_showSummary() { - when(mFeatureFactory.powerUsageFeatureProvider.isSmartBatterySupported()).thenReturn(true); - Settings.Global.putInt(mContext.getContentResolver(), - Settings.Global.ADAPTIVE_BATTERY_MANAGEMENT_ENABLED, OFF); - - mController.updateState(mPreference); - - assertThat(mPreference.getSummary()).isEqualTo("Off"); + assertThat(mPreference.getSummary()).isEqualTo("Detecting when apps drain battery"); } }