From 3acd34fe4a19737f35f35efe1bee6d8055d09c64 Mon Sep 17 00:00:00 2001 From: Tiffany Nguyen Date: Tue, 2 Aug 2022 17:26:10 +0000 Subject: [PATCH 1/2] Move restricted apps page to new battery optimization page. New entry: https://screenshot.googleplex.com/BbU6RnQhBbpnBc3.png Restricted: https://screenshot.googleplex.com/5ggid7TcSsH9CUF.png Old entry: https://screenshot.googleplex.com/7JgZpSfKs5zZb3Z.png Bug: 240711616 Test: manual Change-Id: I03d17beac0fb85a3d17acd7d0d581feb35e9582b --- res/values/config.xml | 3 + res/xml/apps.xml | 12 ++++ src/com/android/settings/Settings.java | 4 +- .../AppBatteryUsagePreferenceController.java | 55 +++++++++++++++++++ ...ava => AppStateAppBatteryUsageBridge.java} | 32 +++++------ .../manageapplications/AppFilterRegistry.java | 8 +-- .../ManageApplications.java | 12 ++-- .../RestrictAppPreferenceController.java | 6 +- .../BatteryManagerPreferenceController.java | 10 +++- 9 files changed, 111 insertions(+), 31 deletions(-) create mode 100644 src/com/android/settings/applications/AppBatteryUsagePreferenceController.java rename src/com/android/settings/applications/{AppStateBatteryOptimizationBridge.java => AppStateAppBatteryUsageBridge.java} (82%) diff --git a/res/values/config.xml b/res/values/config.xml index bb792815b66..ddbcb0fb1aa 100755 --- a/res/values/config.xml +++ b/res/values/config.xml @@ -633,4 +633,7 @@ @string/config_settingsintelligence_package_name android.uid.system:1000 + + + false diff --git a/res/xml/apps.xml b/res/xml/apps.xml index ea1e6921363..7ce4d619ad5 100644 --- a/res/xml/apps.xml +++ b/res/xml/apps.xml @@ -76,6 +76,18 @@ + + + + 0 ? AVAILABLE : CONDITIONALLY_UNAVAILABLE; + return mAppInfos.size() > 0 && !mEnableAppBatteryUsagePage ? AVAILABLE + : CONDITIONALLY_UNAVAILABLE; } @Override diff --git a/src/com/android/settings/fuelgauge/batterytip/BatteryManagerPreferenceController.java b/src/com/android/settings/fuelgauge/batterytip/BatteryManagerPreferenceController.java index d920a8ef777..d508603c772 100644 --- a/src/com/android/settings/fuelgauge/batterytip/BatteryManagerPreferenceController.java +++ b/src/com/android/settings/fuelgauge/batterytip/BatteryManagerPreferenceController.java @@ -36,6 +36,7 @@ public class BatteryManagerPreferenceController extends BasePreferenceController private PowerUsageFeatureProvider mPowerUsageFeatureProvider; private AppOpsManager mAppOpsManager; private UserManager mUserManager; + private boolean mEnableAppBatteryUsagePage; public BatteryManagerPreferenceController(Context context) { super(context, KEY_BATTERY_MANAGER); @@ -43,6 +44,8 @@ public class BatteryManagerPreferenceController extends BasePreferenceController context).getPowerUsageFeatureProvider(context); mAppOpsManager = context.getSystemService(AppOpsManager.class); mUserManager = context.getSystemService(UserManager.class); + mEnableAppBatteryUsagePage = + mContext.getResources().getBoolean(R.bool.config_app_battery_usage_list_enabled); } @Override @@ -53,9 +56,12 @@ public class BatteryManagerPreferenceController extends BasePreferenceController @Override public void updateState(Preference preference) { super.updateState(preference); - final int num = BatteryTipUtils.getRestrictedAppsList(mAppOpsManager, mUserManager).size(); + if (!mEnableAppBatteryUsagePage) { + final int num = BatteryTipUtils.getRestrictedAppsList(mAppOpsManager, + mUserManager).size(); - updateSummary(preference, num); + updateSummary(preference, num); + } } @VisibleForTesting From 1d1b11578564dde236822d8d7ee1338aec17600b Mon Sep 17 00:00:00 2001 From: Tiffany Nguyen Date: Wed, 10 Aug 2022 17:12:36 +0000 Subject: [PATCH 2/2] Align strings and UX across the different pages. https://screenshot.googleplex.com/ercwXXcfg2QHkAW.png https://screenshot.googleplex.com/AWfsrNWsJUbdF8x.png Bug: 240711618 Test: Manual Change-Id: I3d1083a7b50adffb67592b2e42914adf755bd6cd --- res/values/strings.xml | 12 +++---- res/xml/app_info_settings.xml | 2 +- res/xml/apps.xml | 4 +-- res/xml/power_usage_detail.xml | 35 ++++++++----------- .../ManageApplications.java | 5 ++- 5 files changed, 27 insertions(+), 31 deletions(-) diff --git a/res/values/strings.xml b/res/values/strings.xml index 01604c1d704..5743e264de4 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -6097,7 +6097,7 @@ View usage from last full charge - Battery usage + App battery usage Use details @@ -6288,8 +6288,6 @@ Battery usage data is approximate and can change based on usage. Battery usage - - Manage battery usage ^1 total • ^2 background\nfrom last full charge @@ -11260,11 +11258,11 @@ Not using battery optimization - - Manage battery usage + + App battery usage - - Set battery usage for apps + + Set battery usage for apps Unrestricted diff --git a/res/xml/app_info_settings.xml b/res/xml/app_info_settings.xml index a310af59ea6..2bb05d000ae 100644 --- a/res/xml/app_info_settings.xml +++ b/res/xml/app_info_settings.xml @@ -85,7 +85,7 @@ - + - + - - - - - +