From 9ccb9f56ca6adde8a7aedcced38d38ce94e7161d Mon Sep 17 00:00:00 2001 From: jasonwshsu Date: Wed, 28 Jul 2021 01:04:03 +0800 Subject: [PATCH 1/3] Update the preview image in 'Accessibility button & gesture' page. * Put images in drawable/ and drawable-night/ Fix: 193081959 Fix: 193081959 Test: atest AccessibilityButtonPreviewPreferenceControllerTest Change-Id: If0700e285920686cea6a815877af71fe6652d711 --- .../accessibility_button_preview_base.xml | 28 +++++++++++++ ...ity_button_preview_large_floating_menu.xml | 28 +++++++++++++ ...ity_button_preview_small_floating_menu.xml | 28 +++++++++++++ ...essibility_button_preview_three_finger.xml | 40 +++++++++++++++++++ ...ccessibility_button_preview_two_finger.xml | 37 +++++++++++++++++ .../accessibility_button_preview_base.xml | 34 +++++----------- ...ity_button_preview_large_floating_menu.xml | 33 +++++---------- ...ity_button_preview_small_floating_menu.xml | 33 +++++---------- ...essibility_button_preview_three_finger.xml | 32 +++++++-------- ...ccessibility_button_preview_two_finger.xml | 27 +++++++------ res/layout/accessibility_button_preview.xml | 33 --------------- res/xml/accessibility_button_settings.xml | 6 +-- ...lityButtonPreviewPreferenceController.java | 29 ++++++-------- ...ButtonPreviewPreferenceControllerTest.java | 16 ++++---- 14 files changed, 245 insertions(+), 159 deletions(-) create mode 100644 res/drawable-night/accessibility_button_preview_base.xml create mode 100644 res/drawable-night/accessibility_button_preview_large_floating_menu.xml create mode 100644 res/drawable-night/accessibility_button_preview_small_floating_menu.xml create mode 100644 res/drawable-night/accessibility_button_preview_three_finger.xml create mode 100644 res/drawable-night/accessibility_button_preview_two_finger.xml delete mode 100644 res/layout/accessibility_button_preview.xml diff --git a/res/drawable-night/accessibility_button_preview_base.xml b/res/drawable-night/accessibility_button_preview_base.xml new file mode 100644 index 00000000000..a5b0bfa9b26 --- /dev/null +++ b/res/drawable-night/accessibility_button_preview_base.xml @@ -0,0 +1,28 @@ + + + + + + + diff --git a/res/drawable-night/accessibility_button_preview_large_floating_menu.xml b/res/drawable-night/accessibility_button_preview_large_floating_menu.xml new file mode 100644 index 00000000000..74ecbfcd7b1 --- /dev/null +++ b/res/drawable-night/accessibility_button_preview_large_floating_menu.xml @@ -0,0 +1,28 @@ + + + + + + + diff --git a/res/drawable-night/accessibility_button_preview_small_floating_menu.xml b/res/drawable-night/accessibility_button_preview_small_floating_menu.xml new file mode 100644 index 00000000000..4226086d4eb --- /dev/null +++ b/res/drawable-night/accessibility_button_preview_small_floating_menu.xml @@ -0,0 +1,28 @@ + + + + + + + diff --git a/res/drawable-night/accessibility_button_preview_three_finger.xml b/res/drawable-night/accessibility_button_preview_three_finger.xml new file mode 100644 index 00000000000..7afb0f79cc3 --- /dev/null +++ b/res/drawable-night/accessibility_button_preview_three_finger.xml @@ -0,0 +1,40 @@ + + + + + + + + + + + diff --git a/res/drawable-night/accessibility_button_preview_two_finger.xml b/res/drawable-night/accessibility_button_preview_two_finger.xml new file mode 100644 index 00000000000..05871d98e26 --- /dev/null +++ b/res/drawable-night/accessibility_button_preview_two_finger.xml @@ -0,0 +1,37 @@ + + + + + + + + + + diff --git a/res/drawable/accessibility_button_preview_base.xml b/res/drawable/accessibility_button_preview_base.xml index 9e3ec598586..b75b1a8027c 100644 --- a/res/drawable/accessibility_button_preview_base.xml +++ b/res/drawable/accessibility_button_preview_base.xml @@ -15,28 +15,14 @@ --> - - - - - - - - - - - + android:width="412dp" + android:height="300dp" + android:viewportWidth="412" + android:viewportHeight="300"> + + diff --git a/res/drawable/accessibility_button_preview_large_floating_menu.xml b/res/drawable/accessibility_button_preview_large_floating_menu.xml index e003dc7322c..794f3ca5f5a 100644 --- a/res/drawable/accessibility_button_preview_large_floating_menu.xml +++ b/res/drawable/accessibility_button_preview_large_floating_menu.xml @@ -15,27 +15,14 @@ --> + android:width="412dp" + android:height="300dp" + android:viewportWidth="412" + android:viewportHeight="300"> - - - - - - - \ No newline at end of file + android:pathData="M325.4,198.2h-40.9c-22.1,0 -40,-18 -40,-40s18,-40 40,-40h40.9v2.6h-40.9c-20.7,0 -37.5,16.8 -37.5,37.5s16.8,37.5 37.5,37.5h40.9V198.2z" + android:fillColor="#DADCE0"/> + + diff --git a/res/drawable/accessibility_button_preview_small_floating_menu.xml b/res/drawable/accessibility_button_preview_small_floating_menu.xml index 3ff8e4b25f4..670a516348b 100644 --- a/res/drawable/accessibility_button_preview_small_floating_menu.xml +++ b/res/drawable/accessibility_button_preview_small_floating_menu.xml @@ -15,27 +15,14 @@ --> + android:width="412dp" + android:height="300dp" + android:viewportWidth="412" + android:viewportHeight="300"> - - - - - - - \ No newline at end of file + android:pathData="M325.4,189.2h-31.7c-17.1,0 -31,-13.9 -31,-31s13.9,-31 31,-31h31.7v2h-31.7c-16,0 -29,13 -29,29s13,29 29,29h31.7V189.2z" + android:fillColor="#DADCE0"/> + + diff --git a/res/drawable/accessibility_button_preview_three_finger.xml b/res/drawable/accessibility_button_preview_three_finger.xml index 0fe6710df66..d18ce60e0bb 100644 --- a/res/drawable/accessibility_button_preview_three_finger.xml +++ b/res/drawable/accessibility_button_preview_three_finger.xml @@ -15,26 +15,26 @@ --> + android:width="412dp" + android:height="300dp" + android:viewportWidth="412" + android:viewportHeight="300"> + android:pathData="M384.2,300H27.8C12.5,300 0,287.2 0,271.5v-243C0,12.8 12.5,0 27.8,0h356.5C399.5,0 412,12.8 412,28.5v243.2C412,287.2 399.5,300 384.2,300z" + android:fillColor="#FFFFFF"/> + android:pathData="M182.7,222.6v-17.5h7.5l-10.6,-18.7l-10.6,18.7h7.5v17.5c-2.9,1.2 -4.9,4 -4.9,7.4c0,4.4 3.5,8 8,8c4.4,0 8,-3.5 8,-8C187.6,226.7 185.6,223.8 182.7,222.6z" + android:fillColor="#1A73E8"/> + android:pathData="M209,222.6v-17.5h7.5l-10.6,-18.7l-10.6,18.7h7.5v17.5c-2.9,1.2 -4.9,4 -4.9,7.4c0,4.4 3.5,8 8,8c4.4,0 8,-3.5 8,-8C213.9,226.7 211.9,223.8 209,222.6z" + android:fillColor="#1A73E8"/> + android:pathData="M235.2,222.6v-17.5h7.5l-10.6,-18.7l-10.6,18.7h7.5v17.5c-2.9,1.2 -4.9,4 -4.9,7.4c0,4.4 3.5,8 8,8c4.4,0 8,-3.5 8,-8C240,226.7 238,223.8 235.2,222.6z" + android:fillColor="#1A73E8"/> + diff --git a/res/drawable/accessibility_button_preview_two_finger.xml b/res/drawable/accessibility_button_preview_two_finger.xml index e61e3e84fc7..bec95af17c0 100644 --- a/res/drawable/accessibility_button_preview_two_finger.xml +++ b/res/drawable/accessibility_button_preview_two_finger.xml @@ -15,22 +15,23 @@ --> + android:width="412dp" + android:height="300dp" + android:viewportWidth="412" + android:viewportHeight="300"> + android:pathData="M384.2,300H27.8C12.5,300 0,287.2 0,271.5v-243C0,12.8 12.5,0 27.8,0h356.5C399.5,0 412,12.8 412,28.5v243.2C412,287.2 399.5,300 384.2,300z" + android:fillColor="#FFFFFF"/> + android:pathData="M242.4,226.9h-9.3h-5.6h-43.4h-4.7h-10.2c-1.7,0 -3.1,1.4 -3.1,3.1s1.4,3.1 3.1,3.1h10.2h3.9h45h4.8h9.3c1.7,0 3.1,-1.4 3.1,-3.1S244.1,226.9 242.4,226.9z" + android:fillColor="#DADCE0"/> + android:pathData="M194,223.5v-17.5h7.5l-10.6,-18.7l-10.6,18.7h7.5v17.5c-1.6,0.7 -2.9,1.9 -3.8,3.4c-0.7,1.2 -1.1,2.5 -1.1,4c0,0.7 0.1,1.5 0.3,2.2c0.9,3.3 4,5.8 7.7,5.8c3.6,0 6.7,-2.5 7.7,-5.8c0.2,-0.7 0.3,-1.4 0.3,-2.2c0,-1.5 -0.4,-2.8 -1.1,-4C197,225.4 195.6,224.2 194,223.5z" + android:fillColor="#1A73E8"/> + diff --git a/res/layout/accessibility_button_preview.xml b/res/layout/accessibility_button_preview.xml deleted file mode 100644 index 07cb0ffb8ab..00000000000 --- a/res/layout/accessibility_button_preview.xml +++ /dev/null @@ -1,33 +0,0 @@ - - - - - - - \ No newline at end of file diff --git a/res/xml/accessibility_button_settings.xml b/res/xml/accessibility_button_settings.xml index 9f32714f328..86dd0875058 100644 --- a/res/xml/accessibility_button_settings.xml +++ b/res/xml/accessibility_button_settings.xml @@ -18,10 +18,8 @@ xmlns:android="http://schemas.android.com/apk/res/android" xmlns:settings="http://schemas.android.com/apk/res-auto"> - Date: Sun, 11 Jul 2021 23:26:03 -0800 Subject: [PATCH 2/3] Use new api to create InteractionJankMonitor.Configuration.Builder The api to create InteractionJankMonitor.Configuration.Builder has changed, adopt the new api. Bug: 170708749 Test: build pass Change-Id: I627370fed43630750eab2ec9752338fb03753463 --- .../android/settings/core/InstrumentedPreferenceFragment.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/com/android/settings/core/InstrumentedPreferenceFragment.java b/src/com/android/settings/core/InstrumentedPreferenceFragment.java index f6115fc7ae7..48e5176c891 100644 --- a/src/com/android/settings/core/InstrumentedPreferenceFragment.java +++ b/src/com/android/settings/core/InstrumentedPreferenceFragment.java @@ -158,8 +158,7 @@ public abstract class InstrumentedPreferenceFragment extends ObservablePreferenc switch (newState) { case RecyclerView.SCROLL_STATE_DRAGGING: final Configuration.Builder builder = - new Configuration.Builder(CUJ_SETTINGS_PAGE_SCROLL) - .setView(recyclerView) + Configuration.Builder.withView(CUJ_SETTINGS_PAGE_SCROLL, recyclerView) .setTag(mClassName); mMonitor.begin(builder); break; From d5ea0ffe67d18b4e87e49e7c24b959ed1e88638e Mon Sep 17 00:00:00 2001 From: Joe Bolinger Date: Fri, 30 Jul 2021 12:48:56 -0700 Subject: [PATCH 3/3] Skip enrollment when unicorn account is launched by setup wizard. Bug: 194244555 Test: manual Change-Id: Id310c5e4dec1b1c5262c9703259223ce21b1da61 --- .../biometrics/BiometricEnrollActivity.java | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/com/android/settings/biometrics/BiometricEnrollActivity.java b/src/com/android/settings/biometrics/BiometricEnrollActivity.java index 904a37d1ba6..b3a950511d7 100644 --- a/src/com/android/settings/biometrics/BiometricEnrollActivity.java +++ b/src/com/android/settings/biometrics/BiometricEnrollActivity.java @@ -205,11 +205,25 @@ public class BiometricEnrollActivity extends InstrumentedActivity { mSkipReturnToParent = intent.getBooleanExtra(EXTRA_SKIP_RETURN_TO_PARENT, false); Log.d(TAG, "parentalOptionsRequired: " + mParentalOptionsRequired - + ", skipReturnToParent: " + mSkipReturnToParent); + + ", skipReturnToParent: " + mSkipReturnToParent + + ", isSetupWizard: " + isSetupWizard); + + // TODO(b/195128094): remove this restriction + // Consent can only be recorded when this activity is launched directly from the kids + // module. This can be removed when there is a way to notify consent status out of band. + if (isSetupWizard && mParentalOptionsRequired) { + Log.w(TAG, "Enrollment with parental consent is not supported when launched " + + " directly from SuW - skipping enrollment"); + setResult(RESULT_SKIP); + finish(); + return; + } // Only allow the consent flow to happen once when running from setup wizard. // This isn't common and should only happen if setup wizard is not completed normally // due to a restart, etc. + // This check should probably remain even if b/195128094 is fixed to prevent SuW from + // restarting the process once it has been fully completed at least one time. if (isSetupWizard && mParentalOptionsRequired) { final boolean consentAlreadyManaged = ParentalControlsUtils.parentConsentRequired(this, BiometricAuthenticator.TYPE_FACE | BiometricAuthenticator.TYPE_FINGERPRINT)