From 2bb9cac5f0855adb01925b0a650429cce82c9510 Mon Sep 17 00:00:00 2001
From: Peter_Liang <peterliang@google.com>
Date: Sat, 30 Apr 2022 14:45:01 +0800
Subject: [PATCH] Fix that ripple effect of level buttons for adjusting
 font/display size doesn't fit the shape.

Root cause: Ripple effect of lower view was clipped by the upper layout.

Solution: Add the android:clipChildren="false" into the upper layout.

Bug: 230564860
Test: manual test
Change-Id: Iaa764ced9e33a7a2acd5cc0401e5014184c49cdb
---
 res/layout/icon_discrete_slider.xml | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/res/layout/icon_discrete_slider.xml b/res/layout/icon_discrete_slider.xml
index 47be5efff79..1319987c740 100644
--- a/res/layout/icon_discrete_slider.xml
+++ b/res/layout/icon_discrete_slider.xml
@@ -20,14 +20,13 @@
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
     android:clipChildren="false"
-    android:background="?android:colorBackground"
     android:gravity="center_vertical">
 
     <FrameLayout
         android:id="@+id/icon_start_frame"
         android:layout_width="48dp"
         android:layout_height="48dp"
-        android:background="?android:attr/selectableItemBackgroundBorderless"
+        android:clipChildren="false"
         android:focusable="true"
         android:visibility="gone">
 
@@ -36,6 +35,7 @@
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:layout_gravity="start|center_vertical"
+            android:background="?android:attr/selectableItemBackgroundBorderless"
             android:adjustViewBounds="true"
             android:focusable="false"
             android:tint="?android:attr/textColorPrimary"
@@ -56,7 +56,7 @@
         android:id="@+id/icon_end_frame"
         android:layout_width="48dp"
         android:layout_height="48dp"
-        android:background="?android:attr/selectableItemBackgroundBorderless"
+        android:clipChildren="false"
         android:focusable="true"
         android:visibility="gone">
 
@@ -65,6 +65,7 @@
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:layout_gravity="end|center_vertical"
+            android:background="?android:attr/selectableItemBackgroundBorderless"
             android:adjustViewBounds="true"
             android:focusable="false"
             android:tint="?android:attr/textColorPrimary"