diff --git a/color-check-baseline.xml b/color-check-baseline.xml index 365cbe71abd..cbfae2e6ac2 100644 --- a/color-check-baseline.xml +++ b/color-check-baseline.xml @@ -109,6 +109,22 @@ column="5"/> + + + + + + + + + errorLine1=" <color name="homepage_location_background">#2EC7DC</color>" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + errorLine1=" <color name="homepage_privacy_background">#5E97F6</color>" + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + file="res/values/colors.xml" + line="130" + column="5"/> + + + + - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + @@ -1369,7 +1417,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -1385,7 +1433,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -1401,7 +1449,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -1417,7 +1465,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -1433,7 +1481,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -1449,7 +1497,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -1734,7 +1782,7 @@ summary="Using hardcoded color" explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes. This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app." errorLine1=" android:color="@color/homepage_about_background" />" - errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> + + + + + + + + - - - - - - - - - - - - + + + + @@ -2521,7 +2569,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~"> @@ -2537,7 +2585,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~"> @@ -2553,7 +2601,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~"> @@ -2569,7 +2617,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~"> @@ -2585,7 +2633,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~"> @@ -2601,7 +2649,7 @@ errorLine2=" ^"> @@ -2617,7 +2665,7 @@ errorLine2=" ^"> @@ -2633,7 +2681,7 @@ errorLine2=" ^"> @@ -2649,7 +2697,7 @@ errorLine2=" ^"> @@ -2713,7 +2761,7 @@ errorLine2=" ^"> @@ -2725,12 +2773,12 @@ priority="4" summary="Using hardcoded color" explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes. This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app." - errorLine1=" <item name="android:statusBarColor">#00000000</item>" - errorLine2=" ^"> + errorLine1=" <item name="switchBarBackgroundColor">@color/switch_bar_background</item>" + errorLine2=" ^"> + line="91" + column="47"/> + errorLine1=" <item name="android:trackTint">@color/switchbar_switch_track_tint</item>" + errorLine2=" ^"> + line="97" + column="40"/> + + + + + errorLine1=" <item name="android:statusBarColor">#00000000</item>" + errorLine2=" ^"> + line="169" + column="45"/> + + + + @@ -2921,7 +3001,7 @@ errorLine2=" ^"> @@ -2937,7 +3017,7 @@ errorLine2=" ^"> diff --git a/res/color/switchbar_switch_thumb_tint.xml b/res/color/switchbar_switch_thumb_tint.xml deleted file mode 100644 index 4c75a7e4cc7..00000000000 --- a/res/color/switchbar_switch_thumb_tint.xml +++ /dev/null @@ -1,20 +0,0 @@ - - - - - - \ No newline at end of file diff --git a/res/color/switchbar_switch_track_tint.xml b/res/color/switchbar_switch_track_tint.xml deleted file mode 100644 index 141f9775bba..00000000000 --- a/res/color/switchbar_switch_track_tint.xml +++ /dev/null @@ -1,21 +0,0 @@ - - - - - - \ No newline at end of file diff --git a/res/drawable/ic_friction_lock_closed.xml b/res/drawable/ic_friction_lock_closed.xml index 194c9afb404..dab8c913684 100644 --- a/res/drawable/ic_friction_lock_closed.xml +++ b/res/drawable/ic_friction_lock_closed.xml @@ -21,6 +21,5 @@ android:height="18dp"> + android:fillColor="?attr/frictionIconColor" /> diff --git a/res/drawable/ic_friction_money.xml b/res/drawable/ic_friction_money.xml index 1018533d035..b17092144ea 100644 --- a/res/drawable/ic_friction_money.xml +++ b/res/drawable/ic_friction_money.xml @@ -20,8 +20,7 @@ android:width="18dp" android:height="18dp"> - + android:background="?android:attr/colorBackground" + android:theme="@style/ThemeOverlay.Settings.SearchBar" + app:layout_scrollFlags="scroll|enterAlways"> + android:navigationIcon="@drawable/ic_search_24dp"> + + + + @android:color/black + #dadce0 + #82000000 + @android:color/black + + diff --git a/res/values-night/styles.xml b/res/values-night/styles.xml new file mode 100644 index 00000000000..87159b8b76f --- /dev/null +++ b/res/values-night/styles.xml @@ -0,0 +1,24 @@ + + + + + + + + \ No newline at end of file diff --git a/res/values-night/themes.xml b/res/values-night/themes.xml index 725fe17685d..8deae1cb359 100644 --- a/res/values-night/themes.xml +++ b/res/values-night/themes.xml @@ -20,6 +20,21 @@ + + + + + + diff --git a/res/values/attrs.xml b/res/values/attrs.xml index afff3cebe22..752fd3dada5 100644 --- a/res/values/attrs.xml +++ b/res/values/attrs.xml @@ -154,4 +154,5 @@ + diff --git a/res/values/colors.xml b/res/values/colors.xml index f55eb1a7813..34885b4770a 100644 --- a/res/values/colors.xml +++ b/res/values/colors.xml @@ -130,6 +130,10 @@ #5E97F6 + @android:color/white + #BFFFFFFF + @android:color/white + @*android:color/material_red_A700 #43a047 diff --git a/res/values/styles.xml b/res/values/styles.xml index 8fa357bc75f..fd070594615 100644 --- a/res/values/styles.xml +++ b/res/values/styles.xml @@ -16,12 +16,15 @@ - - diff --git a/res/values/themes.xml b/res/values/themes.xml index 4050cb2b708..4f44a36e6e6 100644 --- a/res/values/themes.xml +++ b/res/values/themes.xml @@ -39,7 +39,7 @@ ?android:attr/colorAccent - @style/Theme.ActionBar + @style/Widget.ActionBar @style/ThemeOverlay.SwitchBar.Settings @@ -62,13 +62,18 @@ true - + - + + @@ -183,4 +190,9 @@ true + +