diff --git a/res/values/strings.xml b/res/values/strings.xml index 7f42c94f152..2e4f08a7fc8 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -5263,6 +5263,8 @@ Caption preferences Magnification + + Magnification shortcut Magnification type @@ -5485,6 +5487,8 @@ Color inversion Use color inversion + + Color inversion shortcut
@@ -5536,6 +5540,8 @@ Open %1$s Use color correction + + Color correction shortcut Show captions @@ -5615,6 +5621,8 @@ Extra dim Make screen extra dim + + Extra dim shortcut Dim screen beyond your phone\u2019s minimum brightness diff --git a/src/com/android/settings/accessibility/ToggleAccessibilityServicePreferenceFragment.java b/src/com/android/settings/accessibility/ToggleAccessibilityServicePreferenceFragment.java index 934907181a7..0e209aa77af 100644 --- a/src/com/android/settings/accessibility/ToggleAccessibilityServicePreferenceFragment.java +++ b/src/com/android/settings/accessibility/ToggleAccessibilityServicePreferenceFragment.java @@ -55,7 +55,6 @@ import com.android.internal.widget.LockPatternUtils; import com.android.settings.R; import com.android.settings.accessibility.AccessibilityUtil.UserShortcutType; import com.android.settings.password.ConfirmDeviceCredentialActivity; -import com.android.settings.widget.SettingsMainSwitchPreference; import com.android.settingslib.accessibility.AccessibilityUtils; import java.util.List; @@ -221,15 +220,6 @@ public class ToggleAccessibilityServicePreferenceFragment extends mComponentName); } - @Override - protected void updateToggleServiceTitle(SettingsMainSwitchPreference switchPreference) { - final AccessibilityServiceInfo info = getAccessibilityServiceInfo(); - final String switchBarText = (info == null) ? "" : - getString(R.string.accessibility_service_primary_switch_title, - info.getResolveInfo().loadLabel(getPackageManager())); - switchPreference.setTitle(switchBarText); - } - @Override protected void updateSwitchBarToggleSwitch() { final boolean checked = isAccessibilityServiceEnabled(); diff --git a/src/com/android/settings/accessibility/ToggleColorInversionPreferenceFragment.java b/src/com/android/settings/accessibility/ToggleColorInversionPreferenceFragment.java index b41bafda512..e06078558b7 100644 --- a/src/com/android/settings/accessibility/ToggleColorInversionPreferenceFragment.java +++ b/src/com/android/settings/accessibility/ToggleColorInversionPreferenceFragment.java @@ -72,6 +72,11 @@ public class ToggleColorInversionPreferenceFragment extends switchPreference.setTitle(R.string.accessibility_display_inversion_switch_title); } + @Override + protected void updateShortcutTitle(ShortcutPreference shortcutPreference) { + shortcutPreference.setTitle(R.string.accessibility_display_inversion_shortcut_title); + } + @Override public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { diff --git a/src/com/android/settings/accessibility/ToggleDaltonizerPreferenceFragment.java b/src/com/android/settings/accessibility/ToggleDaltonizerPreferenceFragment.java index 4bcf4781162..7cf57b9ab77 100644 --- a/src/com/android/settings/accessibility/ToggleDaltonizerPreferenceFragment.java +++ b/src/com/android/settings/accessibility/ToggleDaltonizerPreferenceFragment.java @@ -167,6 +167,11 @@ public final class ToggleDaltonizerPreferenceFragment extends ToggleFeaturePrefe switchPreference.setTitle(R.string.accessibility_daltonizer_primary_switch_title); } + @Override + protected void updateShortcutTitle(ShortcutPreference shortcutPreference) { + shortcutPreference.setTitle(R.string.accessibility_daltonizer_shortcut_title); + } + @Override int getUserShortcutTypes() { return AccessibilityUtil.getUserShortcutTypesFromSettings(getPrefContext(), diff --git a/src/com/android/settings/accessibility/ToggleFeaturePreferenceFragment.java b/src/com/android/settings/accessibility/ToggleFeaturePreferenceFragment.java index 510f8d3484a..1c807eb463f 100644 --- a/src/com/android/settings/accessibility/ToggleFeaturePreferenceFragment.java +++ b/src/com/android/settings/accessibility/ToggleFeaturePreferenceFragment.java @@ -284,7 +284,14 @@ public abstract class ToggleFeaturePreferenceFragment extends SettingsPreference abstract int getUserShortcutTypes(); protected void updateToggleServiceTitle(SettingsMainSwitchPreference switchPreference) { - switchPreference.setTitle(R.string.accessibility_service_primary_switch_title); + final CharSequence title = + getString(R.string.accessibility_service_primary_switch_title, mPackageName); + switchPreference.setTitle(title); + } + + protected void updateShortcutTitle(ShortcutPreference shortcutPreference) { + final CharSequence title = getString(R.string.accessibility_shortcut_title, mPackageName); + shortcutPreference.setTitle(title); } protected abstract void onPreferenceToggled(String preferenceKey, boolean enabled); @@ -434,8 +441,7 @@ public abstract class ToggleFeaturePreferenceFragment extends SettingsPreference mShortcutPreference.setKey(getShortcutPreferenceKey()); mShortcutPreference.setOnClickCallback(this); - final CharSequence title = getString(R.string.accessibility_shortcut_title, mPackageName); - mShortcutPreference.setTitle(title); + updateShortcutTitle(mShortcutPreference); final PreferenceCategory generalCategory = findPreference(KEY_GENERAL_CATEGORY); generalCategory.addPreference(mShortcutPreference); diff --git a/src/com/android/settings/accessibility/ToggleReduceBrightColorsPreferenceFragment.java b/src/com/android/settings/accessibility/ToggleReduceBrightColorsPreferenceFragment.java index e60751e56b5..6fd2e1d81d0 100644 --- a/src/com/android/settings/accessibility/ToggleReduceBrightColorsPreferenceFragment.java +++ b/src/com/android/settings/accessibility/ToggleReduceBrightColorsPreferenceFragment.java @@ -154,6 +154,11 @@ public class ToggleReduceBrightColorsPreferenceFragment extends ToggleFeaturePre switchPreference.setTitle(R.string.reduce_bright_colors_preference_title); } + @Override + protected void updateShortcutTitle(ShortcutPreference shortcutPreference) { + shortcutPreference.setTitle(R.string.reduce_bright_colors_shortcut_title); + } + @Override int getUserShortcutTypes() { return AccessibilityUtil.getUserShortcutTypesFromSettings(getPrefContext(), diff --git a/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragment.java b/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragment.java index 9266f720ca2..6b02f04154c 100644 --- a/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragment.java +++ b/src/com/android/settings/accessibility/ToggleScreenMagnificationPreferenceFragment.java @@ -396,6 +396,11 @@ public class ToggleScreenMagnificationPreferenceFragment extends generalCategory.addPreference(mShortcutPreference); } + @Override + protected void updateShortcutTitle(ShortcutPreference shortcutPreference) { + shortcutPreference.setTitle(R.string.accessibility_screen_magnification_shortcut_title); + } + @Override protected void updateShortcutPreference() { final int shortcutTypes = PreferredShortcuts.retrieveUserShortcutType(getPrefContext(),