PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Wi-Fi QR code scanning icon disappears problem

Browse Source 
Should not do one time initialization for the View in
Preference#onBindViewHolder. Because A view setup in
PreferenceViewHolder may be recycled.

Bug: 127502788
Test: manual
Change-Id: Iedf023fa00d2745a02521b65e5c12165c2bc025b
This commit is contained in:
Arc Wang
2019-04-10 11:46:49 +08:00
parent 0aa0d665c0
commit 2b0c8a0c6b
2 changed files with 31 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/com/android/settings/wifi/AddWifiNetworkPreference.java
View File

@@ -36,7 +36,7 @@ public class AddWifiNetworkPreference extends Preference {
private static final String TAG = "AddWifiNetworkPreference";
private boolean mInitialized;
private final Drawable mScanIconDrawable;
public AddWifiNetworkPreference(Context context) {
super(context);
@@ -45,24 +45,22 @@ public class AddWifiNetworkPreference extends Preference {
setWidgetLayoutResource(R.layout.wifi_button_preference_widget);
setIcon(R.drawable.ic_menu_add);
setTitle(R.string.wifi_add_network);
mScanIconDrawable = getDrawable(R.drawable.ic_scan_24dp);
}
@Override
public void onBindViewHolder(PreferenceViewHolder holder) {
super.onBindViewHolder(holder);
if (!mInitialized) {
mInitialized = true;
final ImageButton imageButton = (ImageButton) holder.findViewById(R.id.button_icon);
imageButton.setImageDrawable(getDrawable(R.drawable.ic_scan_24dp));
imageButton.setContentDescription(
getContext().getString(R.string.wifi_dpp_scan_qr_code));
imageButton.setOnClickListener(view -> {
getContext().startActivity(
WifiDppUtils.getEnrolleeQrCodeScannerIntent(/* ssid */ null));
});
}
final ImageButton scanButton = (ImageButton) holder.findViewById(R.id.button_icon);
scanButton.setImageDrawable(mScanIconDrawable);
scanButton.setContentDescription(
getContext().getString(R.string.wifi_dpp_scan_qr_code));
scanButton.setOnClickListener(view -> {
getContext().startActivity(
WifiDppUtils.getEnrolleeQrCodeScannerIntent(/* ssid */ null));
});
}
private Drawable getDrawable(@DrawableRes int iconResId) {