diff --git a/AndroidManifest.xml b/AndroidManifest.xml
index 00b2e94a235..d115a40c881 100644
--- a/AndroidManifest.xml
+++ b/AndroidManifest.xml
@@ -742,7 +742,7 @@
android:name=".notification.ZenOnboardingActivity"
android:label="@string/zen_onboarding_dnd_visual_disturbances_header"
android:icon="@drawable/ic_settings_notifications"
- android:theme="@style/Theme.Settings.NoActionBar"
+ android:theme="@*android:style/Theme.DeviceDefault.Settings.Dialog.NoActionBar"
android:exported="true"
android:taskAffinity="com.android.settings"
android:parentActivityName="Settings">
diff --git a/res/layout/zen_onboarding.xml b/res/layout/zen_onboarding.xml
index 684044319c5..64679550189 100644
--- a/res/layout/zen_onboarding.xml
+++ b/res/layout/zen_onboarding.xml
@@ -16,152 +16,49 @@
-->
-
-
+ android:textAppearance="@android:style/TextAppearance.Material.DialogWindowTitle" />
-
+ android:layout_marginTop="35dp">
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+ android:text="@string/zen_onboarding_no_update"
+ android:layout_toStartOf="@+id/ok"
+ style="@style/TextAppearance.ZenOnboardingButton"
+ android:onClick="close" />
\ No newline at end of file
diff --git a/res/values/strings.xml b/res/values/strings.xml
index 7bdb06972eb..bd7a47cee67 100644
--- a/res/values/strings.xml
+++ b/res/values/strings.xml
@@ -7360,14 +7360,26 @@
- %d rules can turn on automatically
- Ok
+
+ Update
+
+ Don\'t update
+
+ Your phone mutes sounds & vibrations\n\nUpdate settings to also:\n\n- Hide notifications\n\n- Only show calls from starred contacts
+
+ Update your Do Not Disturb settings?
+
+
Settings
+
You can further customize this in Settings.
+
Block when the screen is on
+
Block when the screen is off
- Do Not Disturb can do more than block unwanted sounds - it can block visuals too. This may be helpful if you\'re trying to sleep, focus, or limit time spent on your phone.
- Block sounds and visuals
+
Don\'t turn on the screen or wake for notifications
+
Don\'t show notifications at all, except for basic phone activity and status
diff --git a/res/values/styles.xml b/res/values/styles.xml
index 90758913818..819202e0e8a 100644
--- a/res/values/styles.xml
+++ b/res/values/styles.xml
@@ -432,6 +432,17 @@
- marquee
+
+
diff --git a/src/com/android/settings/notification/ZenOnboardingActivity.java b/src/com/android/settings/notification/ZenOnboardingActivity.java
index b38bad67af3..baca8110ff3 100644
--- a/src/com/android/settings/notification/ZenOnboardingActivity.java
+++ b/src/com/android/settings/notification/ZenOnboardingActivity.java
@@ -33,8 +33,6 @@ public class ZenOnboardingActivity extends Activity {
private NotificationManager mNm;
private MetricsLogger mMetrics;
- CheckBox mScreenOn;
- CheckBox mScreenOff;
@Override
protected void onCreate(Bundle savedInstanceState) {
@@ -48,10 +46,6 @@ public class ZenOnboardingActivity extends Activity {
@VisibleForTesting
protected void setupUI() {
setContentView(R.layout.zen_onboarding);
- mScreenOn = findViewById(R.id.screen_on_option);
- mScreenOff = findViewById(R.id.screen_off_option);
- mScreenOn.setChecked(true);
- mScreenOff.setChecked(true);
mMetrics.visible(MetricsEvent.SETTINGS_ZEN_ONBOARDING);
}
@@ -66,39 +60,19 @@ public class ZenOnboardingActivity extends Activity {
mMetrics = ml;
}
- public void logClick(View view) {
- CheckBox checkbox = (CheckBox) view;
- switch (checkbox.getId()) {
- case R.id.screen_on_option:
- mMetrics.action(MetricsEvent.ACTION_ZEN_ONBOARDING_SCREEN_ON, checkbox.isChecked());
- break;
- case R.id.screen_off_option:
- mMetrics.action(MetricsEvent.ACTION_ZEN_ONBOARDING_SCREEN_OFF,
- checkbox.isChecked());
- break;
- }
- }
-
- public void launchSettings(View button) {
- mMetrics.action(MetricsEvent.ACTION_ZEN_ONBOARDING_SETTINGS);
- Intent settings = new Intent(Settings.ZEN_MODE_BLOCKED_EFFECTS_SETTINGS);
- settings.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK | Intent.FLAG_ACTIVITY_CLEAR_TASK);
- startActivity(settings);
+ public void close(View button) {
+ mMetrics.action(MetricsEvent.ACTION_ZEN_ONBOARDING_KEEP_CURRENT_SETTINGS);
+ finishAndRemoveTask();
}
public void save(View button) {
mMetrics.action(MetricsEvent.ACTION_ZEN_ONBOARDING_OK);
NotificationManager.Policy policy = mNm.getNotificationPolicy();
- int currentEffects = policy.suppressedVisualEffects;
-
- currentEffects = NotificationManager.Policy.toggleScreenOnEffectsSuppressed(
- currentEffects, mScreenOn != null && mScreenOn.isChecked());
- currentEffects = NotificationManager.Policy.toggleScreenOffEffectsSuppressed(
- currentEffects, mScreenOff != null && mScreenOff.isChecked());
NotificationManager.Policy newPolicy = new NotificationManager.Policy(
- policy.priorityCategories, policy.priorityCallSenders,
- policy.priorityMessageSenders, currentEffects);
+ policy.priorityCategories, NotificationManager.Policy.PRIORITY_SENDERS_STARRED,
+ policy.priorityMessageSenders,
+ NotificationManager.Policy.getAllSuppressedVisualEffects());
mNm.setNotificationPolicy(newPolicy);
finishAndRemoveTask();
diff --git a/tests/robotests/src/com/android/settings/notification/ZenOnboardingActivityTest.java b/tests/robotests/src/com/android/settings/notification/ZenOnboardingActivityTest.java
index 3fd2239173b..57dc855a780 100644
--- a/tests/robotests/src/com/android/settings/notification/ZenOnboardingActivityTest.java
+++ b/tests/robotests/src/com/android/settings/notification/ZenOnboardingActivityTest.java
@@ -30,6 +30,8 @@ import static android.app.NotificationManager.Policy.SUPPRESSED_EFFECT_STATUS_BA
import static com.google.common.truth.Truth.assertThat;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.never;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
@@ -59,9 +61,6 @@ public class ZenOnboardingActivityTest {
@Mock
NotificationManager mNm;
- @Mock(answer = Answers.RETURNS_DEEP_STUBS)
- private Context mContext;
-
ZenOnboardingActivity mActivity;
@Before
@@ -83,44 +82,10 @@ public class ZenOnboardingActivityTest {
}
@Test
- public void toggleCheckBoxRecordsEvents_screenOn() {
- mActivity.findViewById(R.id.screen_on_option).performClick();
-
- verify(mMetricsLogger).action(MetricsEvent.ACTION_ZEN_ONBOARDING_SCREEN_ON, false);
-
- mActivity.findViewById(R.id.screen_on_option).performClick();
-
- verify(mMetricsLogger).action(MetricsEvent.ACTION_ZEN_ONBOARDING_SCREEN_ON, true);
- }
-
- @Test
- public void toggleCheckBoxRecordsEvents_screenOff() {
- mActivity.findViewById(R.id.screen_off_option).performClick();
-
- verify(mMetricsLogger).action(MetricsEvent.ACTION_ZEN_ONBOARDING_SCREEN_OFF, false);
-
- mActivity.findViewById(R.id.screen_off_option).performClick();
-
- verify(mMetricsLogger).action(MetricsEvent.ACTION_ZEN_ONBOARDING_SCREEN_OFF, true);
- }
-
- @Test
- public void save_screenOn() {
- Policy policy = new Policy(
- PRIORITY_CATEGORY_ALARMS, 0, 0,
- SUPPRESSED_EFFECT_SCREEN_ON
- | SUPPRESSED_EFFECT_SCREEN_OFF
- | SUPPRESSED_EFFECT_FULL_SCREEN_INTENT
- | SUPPRESSED_EFFECT_LIGHTS
- | SUPPRESSED_EFFECT_PEEK
- | SUPPRESSED_EFFECT_STATUS_BAR
- | SUPPRESSED_EFFECT_BADGE
- | SUPPRESSED_EFFECT_AMBIENT
- | SUPPRESSED_EFFECT_NOTIFICATION_LIST);
+ public void save() {
+ Policy policy = new Policy(PRIORITY_CATEGORY_ALARMS, 0, 0, SUPPRESSED_EFFECT_SCREEN_ON);
when(mNm.getNotificationPolicy()).thenReturn(policy);
- mActivity.findViewById(R.id.screen_off_option).performClick();
-
mActivity.save(null);
verify(mMetricsLogger).action(MetricsEvent.ACTION_ZEN_ONBOARDING_OK);
@@ -130,14 +95,14 @@ public class ZenOnboardingActivityTest {
Policy actual = captor.getValue();
assertThat(actual.priorityCategories).isEqualTo(PRIORITY_CATEGORY_ALARMS);
+ assertThat(actual.priorityCallSenders).isEqualTo(Policy.PRIORITY_SENDERS_STARRED);
+ assertThat(actual.priorityMessageSenders).isEqualTo(Policy.PRIORITY_SENDERS_ANY);
assertThat(actual.suppressedVisualEffects).isEqualTo(
- SUPPRESSED_EFFECT_SCREEN_ON | SUPPRESSED_EFFECT_NOTIFICATION_LIST
- | SUPPRESSED_EFFECT_BADGE | SUPPRESSED_EFFECT_STATUS_BAR
- | SUPPRESSED_EFFECT_PEEK);
+ Policy.getAllSuppressedVisualEffects());
}
@Test
- public void save_screenOff() {
+ public void close() {
Policy policy = new Policy(
PRIORITY_CATEGORY_ALARMS, PRIORITY_SENDERS_ANY, 0,
SUPPRESSED_EFFECT_SCREEN_ON
@@ -151,72 +116,10 @@ public class ZenOnboardingActivityTest {
| SUPPRESSED_EFFECT_NOTIFICATION_LIST);
when(mNm.getNotificationPolicy()).thenReturn(policy);
- mActivity.findViewById(R.id.screen_on_option).performClick();
+ mActivity.close(null);
- mActivity.save(null);
+ verify(mMetricsLogger).action(MetricsEvent.ACTION_ZEN_ONBOARDING_KEEP_CURRENT_SETTINGS);
- verify(mMetricsLogger).action(MetricsEvent.ACTION_ZEN_ONBOARDING_OK);
-
- ArgumentCaptor captor = ArgumentCaptor.forClass(Policy.class);
- verify(mNm).setNotificationPolicy(captor.capture());
-
- Policy actual = captor.getValue();
- assertThat(actual.priorityCallSenders).isEqualTo(PRIORITY_SENDERS_ANY);
- assertThat(actual.suppressedVisualEffects).isEqualTo(
- SUPPRESSED_EFFECT_SCREEN_OFF | SUPPRESSED_EFFECT_FULL_SCREEN_INTENT
- | SUPPRESSED_EFFECT_LIGHTS | SUPPRESSED_EFFECT_AMBIENT);
- }
-
- @Test
- public void save_none() {
- Policy policy = new Policy(0, 0, 0,
- SUPPRESSED_EFFECT_SCREEN_ON
- | SUPPRESSED_EFFECT_SCREEN_OFF
- | SUPPRESSED_EFFECT_FULL_SCREEN_INTENT
- | SUPPRESSED_EFFECT_LIGHTS
- | SUPPRESSED_EFFECT_PEEK
- | SUPPRESSED_EFFECT_STATUS_BAR
- | SUPPRESSED_EFFECT_BADGE
- | SUPPRESSED_EFFECT_AMBIENT
- | SUPPRESSED_EFFECT_NOTIFICATION_LIST);
- when(mNm.getNotificationPolicy()).thenReturn(policy);
-
- mActivity.findViewById(R.id.screen_on_option).performClick();
- mActivity.findViewById(R.id.screen_off_option).performClick();
-
- mActivity.save(null);
-
- verify(mMetricsLogger).action(MetricsEvent.ACTION_ZEN_ONBOARDING_OK);
-
- ArgumentCaptor captor = ArgumentCaptor.forClass(Policy.class);
- verify(mNm).setNotificationPolicy(captor.capture());
-
- Policy actual = captor.getValue();
- assertThat(actual.suppressedVisualEffects).isEqualTo(0);
- }
-
- @Test
- public void save_all() {
- Policy policy = new Policy(0, 0, 0, 0);
- when(mNm.getNotificationPolicy()).thenReturn(policy);
-
- mActivity.save(null);
-
- verify(mMetricsLogger).action(MetricsEvent.ACTION_ZEN_ONBOARDING_OK);
-
- ArgumentCaptor captor = ArgumentCaptor.forClass(Policy.class);
- verify(mNm).setNotificationPolicy(captor.capture());
-
- Policy actual = captor.getValue();
- assertThat(actual.suppressedVisualEffects).isEqualTo(
- SUPPRESSED_EFFECT_SCREEN_ON
- | SUPPRESSED_EFFECT_SCREEN_OFF
- | SUPPRESSED_EFFECT_FULL_SCREEN_INTENT
- | SUPPRESSED_EFFECT_LIGHTS
- | SUPPRESSED_EFFECT_PEEK
- | SUPPRESSED_EFFECT_STATUS_BAR
- | SUPPRESSED_EFFECT_BADGE
- | SUPPRESSED_EFFECT_AMBIENT
- | SUPPRESSED_EFFECT_NOTIFICATION_LIST);
+ verify(mNm, never()).setNotificationPolicy(any());
}
}