PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prompt to start user before choosing a new ringtone

Browse Source 
Dead users can't hear, nor see, ringtones. Let's wake them up and give
them a good shake first.

Until then, show a nice friendly "work profile isn't available" message.
Or depending on locale something confusing, egregious, and mismatched
like "work profile isn't available" instead.

Fix: 34735015
Bug: 34734809
Test: make RunSettingsRoboTests && make Settings && adb install -r $OUT/system/priv-app/Settings/Settings.apk && then reboot the device to see what happens
Change-Id: I86e61a7f3f654d7f38f04c43227a31e2f288e18f
This commit is contained in:
Robin Lee
2017-01-26 18:14:08 +00:00
parent 6596c8ff4e
commit 2953f31b61
2 changed files with 11 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/com/android/settings/DefaultRingtonePreference.java
View File

@@ -30,7 +30,7 @@ import android.util.Log;
public class DefaultRingtonePreference extends RingtonePreference { public class DefaultRingtonePreference extends RingtonePreference {
private static final String TAG = "DefaultRingtonePreference"; private static final String TAG = "DefaultRingtonePreference";
private int mUserId; private int mUserId = UserHandle.USER_CURRENT;
protected Context mUserContext; protected Context mUserContext;
public DefaultRingtonePreference(Context context, AttributeSet attrs) { public DefaultRingtonePreference(Context context, AttributeSet attrs) {
@@ -40,22 +40,20 @@ public class DefaultRingtonePreference extends RingtonePreference {
public void setUserId(int userId) { public void setUserId(int userId) {
mUserId = userId; mUserId = userId;
Context context = getContext(); mUserContext = Utils.createPackageContextAsUser(getContext(), mUserId);
mUserContext = Utils.createPackageContextAsUser(context, mUserId);
} }
@Override @Override
public void performClick() { public void performClick() {
if (!Utils.startQuietModeDialogIfNecessary(getContext(), UserManager.get(getContext()), if (mUserId != UserHandle.USER_CURRENT) {
mUserId)) { if (Utils.unlockWorkProfileIfNecessary(getContext(), mUserId) ||
Utils.startQuietModeDialogIfNecessary(getContext(),
UserManager.get(getContext()), mUserId)) {
return;
}
}
super.performClick(); super.performClick();
} }
}
public void clearUserId(int userId) {
mUserId = UserHandle.USER_CURRENT;
mUserContext = getContext();
}
@Override @Override
public void onPrepareRingtonePickerIntent(Intent ringtonePickerIntent) { public void onPrepareRingtonePickerIntent(Intent ringtonePickerIntent) {

5
src/com/android/settings/notification/WorkSoundPreferenceController.java
View File

@@ -157,9 +157,8 @@ public class WorkSoundPreferenceController extends PreferenceController implemen
} }
private CharSequence updateRingtoneName(Context context, int type) { private CharSequence updateRingtoneName(Context context, int type) {
if (context == null) { if (context == null || !UserManager.get(context).isUserUnlocked(context.getUserId())) {
Log.e(TAG, "Unable to update ringtone name, no context provided"); return context.getString(R.string.managed_profile_not_available_label);
return null;
} }
Uri ringtoneUri = RingtoneManager.getActualDefaultRingtoneUri(context, type); Uri ringtoneUri = RingtoneManager.getActualDefaultRingtoneUri(context, type);
return Ringtone.getTitle(context, ringtoneUri, false /* followSettingsUri */, return Ringtone.getTitle(context, ringtoneUri, false /* followSettingsUri */,