PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix the NullPointerException

Browse Source 
Add the checking of null point for LocalBluetoothProfileManager

Bug: 296442243
Test: [pass]make RunSettingsRoboTests ROBOTEST_FILTER=MediaOutputIndicatorWorkerTest
Change-Id: Ieb38feec0a8a6b1f28c3ebd256ae7482c96fdf55
This commit is contained in:
SongFerngWang
2023-08-23 17:28:34 +08:00
committed by SongFerng Wang
parent 67d5cb42e9
commit 280dfac8af
2 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/com/android/settings/media/MediaOutputIndicatorWorker.java
View File

@@ -167,12 +167,20 @@ public class MediaOutputIndicatorWorker extends SliceBackgroundWorker implements
/** Check if this device supports LE Audio Broadcast feature */ /** Check if this device supports LE Audio Broadcast feature */
public boolean isBroadcastSupported() { public boolean isBroadcastSupported() {
if (mLocalBluetoothManager == null) {
Log.e(TAG, "isBroadcastSupported: Bluetooth is not supported on this device");
return false;
}
LocalBluetoothLeBroadcast broadcast = LocalBluetoothLeBroadcast broadcast =
mLocalBluetoothManager.getProfileManager().getLeAudioBroadcastProfile(); mLocalBluetoothManager.getProfileManager().getLeAudioBroadcastProfile();
return broadcast != null ? true : false; return broadcast != null ? true : false;
} }
public boolean isDeviceBroadcasting() { public boolean isDeviceBroadcasting() {
if (mLocalBluetoothManager == null) {
Log.e(TAG, "isDeviceBroadcasting: Bluetooth is not supported on this device");
return false;
}
LocalBluetoothLeBroadcast broadcast = LocalBluetoothLeBroadcast broadcast =
mLocalBluetoothManager.getProfileManager().getLeAudioBroadcastProfile(); mLocalBluetoothManager.getProfileManager().getLeAudioBroadcastProfile();
if (broadcast == null) { if (broadcast == null) {

14
tests/robotests/src/com/android/settings/media/MediaOutputIndicatorWorkerTest.java
View File

@@ -313,4 +313,18 @@ public class MediaOutputIndicatorWorkerTest {
assertThat(mMediaOutputIndicatorWorker.isBroadcastSupported()).isTrue(); assertThat(mMediaOutputIndicatorWorker.isBroadcastSupported()).isTrue();
} }
@Test
public void isBroadcastSupported_noLocalMediaManager_returnFalse() {
mMediaOutputIndicatorWorker.mLocalMediaManager = null;
assertThat(mMediaOutputIndicatorWorker.isBroadcastSupported()).isFalse();
}
@Test
public void isDeviceBroadcasting_noLocalMediaManager_returnFalse() {
mMediaOutputIndicatorWorker.mLocalMediaManager = null;
assertThat(mMediaOutputIndicatorWorker.isDeviceBroadcasting()).isFalse();
}
} }