PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update CodeInspectionTest

Browse Source 
Update the method to check it contains valid constructor, otherwise
report error.

Fixes: 129346285
Test: RunSettingsRoboTests
Change-Id: I4c5a62b1046e791f3988cd5215879435a831d19d
This commit is contained in:
jackqdyulei
2019-03-26 16:28:36 -07:00
parent 6aeed0eaa1
commit 27c3fe65fd
2 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/robotests/assets/grandfather_invalid_base_preference_controller_constructor
View File

@@ -10,8 +10,5 @@ com.android.settings.datausage.WifiDataUsageSummaryPreferenceController
com.android.settings.fuelgauge.RestrictAppPreferenceController com.android.settings.fuelgauge.RestrictAppPreferenceController
com.android.settings.fuelgauge.batterysaver.BatterySaverButtonPreferenceController com.android.settings.fuelgauge.batterysaver.BatterySaverButtonPreferenceController
com.android.settings.fuelgauge.batterytip.BatteryTipPreferenceController com.android.settings.fuelgauge.batterytip.BatteryTipPreferenceController
com.android.settings.gestures.SystemNavigationEdgeToEdgePreferenceController
com.android.settings.gestures.SystemNavigationLegacyPreferenceController
com.android.settings.gestures.SystemNavigationSwipeUpPreferenceController
com.android.settings.security.VisiblePatternProfilePreferenceController com.android.settings.security.VisiblePatternProfilePreferenceController
com.android.settings.wifi.details.WifiMeteredPreferenceController com.android.settings.wifi.details.WifiMeteredPreferenceController

11
tests/robotests/src/com/android/settings/core/BasePreferenceControllerSignatureInspector.java
View File

@@ -58,12 +58,17 @@ public class BasePreferenceControllerSignatureInspector extends CodeInspector {
if (constructors == null || constructors.length == 0) { if (constructors == null || constructors.length == 0) {
badClasses.append(c.getName()).append(","); badClasses.append(c.getName()).append(",");
} }
boolean hasValidConstructor = false;
for (Constructor constructor : constructors) { for (Constructor constructor : constructors) {
if (!hasValidConstructorSignature(constructor)) { if (hasValidConstructorSignature(constructor)) {
badClasses.append(className).append(","); hasValidConstructor = true;
continue; break;
} }
} }
if (!hasValidConstructor) {
badClasses.append(className).append(",");
}
} }
assertWithMessage("All BasePreferenceController (and subclasses) constructor must either" assertWithMessage("All BasePreferenceController (and subclasses) constructor must either"