Merge "Add a condition for preventing NPE when accessing SatelliteManager" into main

This commit is contained in:
Hakjun Choi
2024-06-18 04:01:46 +00:00
committed by Android (Google) Code Review
2 changed files with 12 additions and 1 deletions

View File

@@ -92,6 +92,14 @@ public class SatelliteSetting extends RestrictedDashboardFragment {
} }
mActivity = getActivity(); mActivity = getActivity();
mSatelliteManager = mActivity.getSystemService(SatelliteManager.class);
if (mSatelliteManager == null) {
Log.d(TAG, "SatelliteManager is null, do nothing.");
finish();
return;
}
mSubId = mActivity.getIntent().getIntExtra(SUB_ID, mSubId = mActivity.getIntent().getIntExtra(SUB_ID,
SubscriptionManager.INVALID_SUBSCRIPTION_ID); SubscriptionManager.INVALID_SUBSCRIPTION_ID);
@@ -104,7 +112,6 @@ public class SatelliteSetting extends RestrictedDashboardFragment {
} }
mTelephonymanager = mActivity.getSystemService(TelephonyManager.class); mTelephonymanager = mActivity.getSystemService(TelephonyManager.class);
mSatelliteManager = mActivity.getSystemService(SatelliteManager.class);
} }
@Override @Override

View File

@@ -64,6 +64,10 @@ public class SatelliteSettingPreferenceController extends
return UNSUPPORTED_ON_DEVICE; return UNSUPPORTED_ON_DEVICE;
} }
if (mSatelliteManager == null) {
return UNSUPPORTED_ON_DEVICE;
}
final PersistableBundle carrierConfig = mCarrierConfigCache.getConfigForSubId(subId); final PersistableBundle carrierConfig = mCarrierConfigCache.getConfigForSubId(subId);
final boolean isSatelliteAttachSupported = carrierConfig.getBoolean( final boolean isSatelliteAttachSupported = carrierConfig.getBoolean(
CarrierConfigManager.KEY_SATELLITE_ATTACH_SUPPORTED_BOOL); CarrierConfigManager.KEY_SATELLITE_ATTACH_SUPPORTED_BOOL);