Fix bugs in auto restriction.
1. Dismiss this tip once user clicks it and goes to detail page. 2. In auto restriction, since apps are automatically restricted, we need to remove apps in list that unrestricted by user. 3. Refactor the code to remove the unnecessary parameter(i.e. SettingsActivity) Bug: 78187414 Test: RunSettingsRoboTests Change-Id: I1c950f7c55df35795641c2ea8579ce9e011dba28
This commit is contained in:
@@ -67,8 +67,6 @@ public class RestrictAppPreferenceControllerTest {
|
||||
@Mock
|
||||
private AppOpsManager.PackageOps mOtherUserPackageOps;
|
||||
@Mock
|
||||
private SettingsActivity mSettingsActivity;
|
||||
@Mock
|
||||
private InstrumentedPreferenceFragment mFragment;
|
||||
@Mock
|
||||
private UserManager mUserManager;
|
||||
@@ -102,9 +100,9 @@ public class RestrictAppPreferenceControllerTest {
|
||||
mContext = spy(RuntimeEnvironment.application);
|
||||
doReturn(mAppOpsManager).when(mContext).getSystemService(Context.APP_OPS_SERVICE);
|
||||
doReturn(mUserManager).when(mContext).getSystemService(UserManager.class);
|
||||
doReturn(mContext).when(mSettingsActivity).getApplicationContext();
|
||||
doReturn(mContext).when(mFragment).getContext();
|
||||
mRestrictAppPreferenceController =
|
||||
new RestrictAppPreferenceController(mSettingsActivity, mFragment);
|
||||
new RestrictAppPreferenceController(mFragment);
|
||||
mPackageOpsList = new ArrayList<>();
|
||||
mPreference = new Preference(mContext);
|
||||
mPreference.setKey(mRestrictAppPreferenceController.getPreferenceKey());
|
||||
@@ -171,7 +169,7 @@ public class RestrictAppPreferenceControllerTest {
|
||||
|
||||
mRestrictAppPreferenceController.handlePreferenceTreeClick(mPreference);
|
||||
|
||||
verify(mSettingsActivity).startActivity(intent.capture());
|
||||
verify(mContext).startActivity(intent.capture());
|
||||
assertThat(intent.getValue().getStringExtra(EXTRA_SHOW_FRAGMENT))
|
||||
.isEqualTo(RestrictedAppDetails.class.getName());
|
||||
assertThat(intent.getValue().getIntExtra(EXTRA_SHOW_FRAGMENT_TITLE_RESID, -1))
|
||||
|
Reference in New Issue
Block a user