From 23872128235a3e051c5b05958270f3c00c9d74ee Mon Sep 17 00:00:00 2001 From: Peter_Liang Date: Thu, 6 Aug 2020 21:13:08 +0800 Subject: [PATCH] Fix the screen scrolling down after enabling dark theme. Root Cause: Dynamically update preferences behind onCreate lifecycle. Solution: Move it to previous lifecycle. Bug: 139877200 Test: make RunSettingsRoboTests ROBOTEST_FILTER=AccessibilitySettingsTest Change-Id: I1638a8b2d48369ec1ea0b996fbed09233c5e3649 --- .../android/settings/accessibility/AccessibilitySettings.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/com/android/settings/accessibility/AccessibilitySettings.java b/src/com/android/settings/accessibility/AccessibilitySettings.java index f918046bc37..fca49f917f4 100644 --- a/src/com/android/settings/accessibility/AccessibilitySettings.java +++ b/src/com/android/settings/accessibility/AccessibilitySettings.java @@ -216,6 +216,7 @@ public class AccessibilitySettings extends DashboardFragment { public void onCreate(Bundle icicle) { super.onCreate(icicle); initializeAllPreferences(); + updateAllPreferences(); } @Override @@ -229,7 +230,6 @@ public class AccessibilitySettings extends DashboardFragment { @Override public void onStart() { super.onStart(); - updateAllPreferences(); mSettingsPackageMonitor.register(getActivity(), getActivity().getMainLooper(), false); mSettingsContentObserver.register(getContentResolver());