PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change the permission bar chart to use the new design

Browse Source 
- Each bar is now labeled with the permission name and the subtitle is
slightly different.
- Change some string for new design

Test: View screen.
Test: atest PermissionBarChartPreferenceControllerTest
Change-Id: Ia82f9cbb6255d93c38a27b038ae5af3f066eec28
This commit is contained in:
Joel Galenson
2019-03-21 10:00:20 -07:00
committed by tmfang
parent 41562c66aa
commit 22ab71c7c6
2 changed files with 11 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
res/values/strings.xml
View File

@@ -10916,17 +10916,15 @@
<string name="permission_bar_chart_empty_text">0 apps used permissions</string> <string name="permission_bar_chart_empty_text">0 apps used permissions</string>
<!-- Text for permission bar chart title in Privacy page. [CHAR LIMIT=NONE] --> <!-- Text for permission bar chart title in Privacy page. [CHAR LIMIT=NONE] -->
<string name="permission_bar_chart_title">Most-used permissions in last 24 hours</string> <string name="permission_bar_chart_title">Permission usage in last 24 hours</string>
<!-- Text for permission bar chart title in Privacy page. [CHAR LIMIT=NONE] -->
<string name="permission_bar_chart_title_v2">In last 24 hr, apps on this device accessed</string>
<!-- Text for permission bar chart details in Privacy page. [CHAR LIMIT=NONE] --> <!-- Text for permission bar chart details in Privacy page. [CHAR LIMIT=NONE] -->
<string name="permission_bar_chart_details">View Permissions Dashboard</string> <string name="permission_bar_chart_details">See all in Dashboard</string>
<!-- Text for permission bar chart details in Privacy page. [CHAR LIMIT=NONE] --> <plurals name="permission_bar_chart_label">
<string name="permission_bar_chart_details_v2">See all permission usage in Dashboard</string> <item quantity="one">1 app</item>
<!-- Text for permission bar chart details in Privacy page. [CHAR LIMIT=NONE] --> <item quantity="other"><xliff:g id="number" example="7">%s</xliff:g> apps</item>
<string name="permission_bar_chart_details_v3">+ <xliff:g id="permissionCount" example="3">%1$d</xliff:g> other permissions</string> </plurals>
<!-- Title for the accessibility usage preference in the Privacy page. [CHAR LIMIT=NONE] --> <!-- Title for the accessibility usage preference in the Privacy page. [CHAR LIMIT=NONE] -->
<string name="accessibility_usage_title">Accessibility usage</string> <string name="accessibility_usage_title">Accessibility usage</string>

9
src/com/android/settings/privacy/PermissionBarChartPreferenceController.java
View File

@@ -163,12 +163,13 @@ public class PermissionBarChartPreferenceController extends BasePreferenceContro
for (int index = 0; index < barViewInfos.length; index++) { for (int index = 0; index < barViewInfos.length; index++) {
final RuntimePermissionUsageInfo permissionGroupInfo = usageInfos.get(index); final RuntimePermissionUsageInfo permissionGroupInfo = usageInfos.get(index);
final int count = permissionGroupInfo.getAppAccessCount();
final CharSequence permLabel = getPermissionGroupLabel(permissionGroupInfo.getName());
barViewInfos[index] = new BarViewInfo( barViewInfos[index] = new BarViewInfo(
getPermissionGroupIcon(permissionGroupInfo.getName()), getPermissionGroupIcon(permissionGroupInfo.getName()), count, permLabel,
permissionGroupInfo.getAppAccessCount(), mContext.getResources().getQuantityString(R.plurals.permission_bar_chart_label,
R.string.storage_detail_apps, count, count), permLabel);
getPermissionGroupLabel(permissionGroupInfo.getName()));
// Set the click listener for each bar view. // Set the click listener for each bar view.
// The listener will navigate user to permission usage app. // The listener will navigate user to permission usage app.