From 21eaa773f5d733c158eefdc024822100858dd3f5 Mon Sep 17 00:00:00 2001 From: Ady Abraham Date: Thu, 26 Dec 2019 11:37:58 -0800 Subject: [PATCH] Settings: fix ShowRefreshRatePreferenceControllerTest ShowRefreshRatePreferenceControllerTest is using an incorrect type (Int vs. Bool) which causing a test to fail. Bug: 146767072 Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.development Change-Id: I9269c01619eebac9c0eac29e23f248d1c6d48ba5 --- .../ShowRefreshRatePreferenceControllerTest.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/robotests/src/com/android/settings/development/ShowRefreshRatePreferenceControllerTest.java b/tests/robotests/src/com/android/settings/development/ShowRefreshRatePreferenceControllerTest.java index 380ff5aac2e..cf6d91e0e31 100644 --- a/tests/robotests/src/com/android/settings/development/ShowRefreshRatePreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/development/ShowRefreshRatePreferenceControllerTest.java @@ -39,7 +39,6 @@ import androidx.preference.SwitchPreference; import com.android.settings.testutils.shadow.ShadowParcel; import org.junit.Before; -import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; import org.mockito.Mock; @@ -87,10 +86,9 @@ public class ShowRefreshRatePreferenceControllerTest { } @Test - @Ignore @Config(shadows = ShadowParcel.class) public void updateState_settingEnabled_shouldCheckPreference() throws RemoteException { - ShadowParcel.sReadIntResult = 1; + ShadowParcel.sReadBoolResult = true; doReturn(true).when(mSurfaceFlinger) .transact(eq(SURFACE_FLINGER_CODE), any(), any(), eq(0 /* flags */)); mController.updateState(mPreference); @@ -101,7 +99,7 @@ public class ShowRefreshRatePreferenceControllerTest { @Test @Config(shadows = {ShadowParcel.class}) public void updateState_settingDisabled_shouldUnCheckPreference() throws RemoteException { - ShadowParcel.sReadIntResult = 0; + ShadowParcel.sReadBoolResult = false; doReturn(true).when(mSurfaceFlinger) .transact(eq(SURFACE_FLINGER_CODE), any(), any(), eq(0 /* flags */)); mController.updateState(mPreference);