From 1ff25ba7e6b500123a715b48123e39f70e0c1842 Mon Sep 17 00:00:00 2001 From: Fan Zhang Date: Thu, 27 Oct 2016 15:50:36 -0700 Subject: [PATCH] Modify AppHeaderController to provide UI for notif settings - The AppHeaderController is no longer a singleton. Each time appheader should be updated we will create a new controller. It acts as a builder/mutator, user provides customizable inputs, and the controller will bind everything to UI when calling done(). Bug: 32442716 Test: RunSettingsRoboTests Change-Id: Icfc5bcd8bc170a02b57432d864eaddf71db0d5b4 --- res/layout/app_details.xml | 1 - res/values/styles.xml | 3 +- .../applications/AppHeaderController.java | 196 +++++++++++++++--- .../ApplicationFeatureProvider.java | 8 +- .../ApplicationFeatureProviderImpl.java | 12 +- .../applications/InstalledAppDetails.java | 26 ++- .../notification/AppNotificationSettings.java | 39 +++- .../ChannelNotificationSettings.java | 33 ++- .../applications/AppHeaderControllerTest.java | 121 +++++++++-- 9 files changed, 364 insertions(+), 75 deletions(-) diff --git a/res/layout/app_details.xml b/res/layout/app_details.xml index 68cc57d6649..4e654fd5047 100644 --- a/res/layout/app_details.xml +++ b/res/layout/app_details.xml @@ -29,7 +29,6 @@ @color/card_background_grey center_horizontal + 16dp 16dp 16dp - 16dp + 8dp