From 20374fd211962c20ab2e35ed09a269331135cf57 Mon Sep 17 00:00:00 2001 From: Fan Zhang Date: Fri, 23 Sep 2016 12:10:38 -0700 Subject: [PATCH] Add metrics for remaining dialogs in settings. Fix: 31707295 Test: make RunSettingRoboTests Test: verify logs Change-Id: Icf70900ac4472195624d14e9172207a5c85dccca --- src/com/android/settings/DateTimeSettings.java | 13 +++++++++++++ src/com/android/settings/WirelessSettings.java | 8 ++++++++ 2 files changed, 21 insertions(+) diff --git a/src/com/android/settings/DateTimeSettings.java b/src/com/android/settings/DateTimeSettings.java index 5d5d54ea4cf..1fed1897da1 100644 --- a/src/com/android/settings/DateTimeSettings.java +++ b/src/com/android/settings/DateTimeSettings.java @@ -38,6 +38,7 @@ import android.support.v7.preference.Preference.OnPreferenceChangeListener; import android.text.format.DateFormat; import android.widget.DatePicker; import android.widget.TimePicker; + import com.android.internal.logging.MetricsProto.MetricsEvent; import com.android.settings.dashboard.SummaryLoader; import com.android.settings.search.BaseSearchIndexProvider; @@ -235,6 +236,18 @@ public class DateTimeSettings extends SettingsPreferenceFragment } } + @Override + public int getDialogMetricsCategory(int dialogId) { + switch (dialogId) { + case DIALOG_DATEPICKER: + return MetricsEvent.DIALOG_DATE_PICKER; + case DIALOG_TIMEPICKER: + return MetricsEvent.DIALOG_TIME_PICKER; + default: + return 0; + } + } + static void configureDatePicker(DatePicker datePicker) { // The system clock can't represent dates outside this range. Calendar t = Calendar.getInstance(); diff --git a/src/com/android/settings/WirelessSettings.java b/src/com/android/settings/WirelessSettings.java index fc572fb253c..b73795fcc69 100644 --- a/src/com/android/settings/WirelessSettings.java +++ b/src/com/android/settings/WirelessSettings.java @@ -202,6 +202,14 @@ public class WirelessSettings extends SettingsPreferenceFragment implements Inde return super.onCreateDialog(dialogId); } + @Override + public int getDialogMetricsCategory(int dialogId) { + if (MANAGE_MOBILE_PLAN_DIALOG_ID == dialogId) { + return MetricsEvent.DIALOG_MANAGE_MOBILE_PLAN; + } + return 0; + } + private void log(String s) { Log.d(TAG, s); }