PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Testcase] To migration DisabledSubscriptionControllerTest

Browse Source 
1. Use AndroidJunit4 instead of RobolectricTestRunner
2. Use ApplicationProvider instead of RuntimeEnvironment
   to get context
3. Change Copy Right
4. remove the mock of PreferenceScreen

Bug: 173003522
Test: atest DisabledSubscriptionControllerTest.java
Change-Id: Ia99a4cf4618fcb32162485e7da5e48e3b313ce67
Merged-In: Ia99a4cf4618fcb32162485e7da5e48e3b313ce67
This commit is contained in:
SongFerngWang
2020-11-11 16:29:35 +08:00
committed by SongFerng Wang
parent 766f78e8ed
commit 1ffba4af4e
1 changed files with 21 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
tests/robotests/src/com/android/settings/network/telephony/DisabledSubscriptionControllerTest.java → tests/unit/src/com/android/settings/network/telephony/DisabledSubscriptionControllerTest.java
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright (C) 2019 The Android Open Source Project * Copyright (C) 2020 The Android Open Source Project
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@@ -11,7 +11,7 @@
* distributed under the License is distributed on an "AS IS" BASIS, * distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and * See the License for the specific language governing permissions and
* limitations under the License * limitations under the License.
*/ */
package com.android.settings.network.telephony; package com.android.settings.network.telephony;
@@ -20,13 +20,17 @@ import static com.google.common.truth.Truth.assertThat;
import static org.mockito.Mockito.doReturn; import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.spy; import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.when;
import android.content.Context; import android.content.Context;
import android.os.Looper;
import android.telephony.SubscriptionManager; import android.telephony.SubscriptionManager;
import androidx.lifecycle.LifecycleOwner;
import androidx.preference.PreferenceCategory; import androidx.preference.PreferenceCategory;
import androidx.preference.PreferenceManager;
import androidx.preference.PreferenceScreen; import androidx.preference.PreferenceScreen;
import androidx.test.core.app.ApplicationProvider;
import androidx.test.ext.junit.runners.AndroidJUnit4;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
@@ -35,10 +39,8 @@ import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
import org.mockito.Mock; import org.mockito.Mock;
import org.mockito.MockitoAnnotations; import org.mockito.MockitoAnnotations;
import org.robolectric.RobolectricTestRunner;
import org.robolectric.RuntimeEnvironment;
@RunWith(RobolectricTestRunner.class) @RunWith(AndroidJUnit4.class)
public class DisabledSubscriptionControllerTest { public class DisabledSubscriptionControllerTest {
private static final String KEY = "disabled_subscription_category"; private static final String KEY = "disabled_subscription_category";
@@ -47,22 +49,28 @@ public class DisabledSubscriptionControllerTest {
@Mock @Mock
private SubscriptionManager mSubscriptionManager; private SubscriptionManager mSubscriptionManager;
@Mock @Mock
private PreferenceScreen mScreen; private Lifecycle mLifecycle;
private PreferenceScreen mScreen;
private PreferenceManager mPreferenceManager;
private PreferenceCategory mCategory; private PreferenceCategory mCategory;
private Context mContext; private Context mContext;
private Lifecycle mLifecycle;
private DisabledSubscriptionController mController; private DisabledSubscriptionController mController;
@Before @Before
public void setUp() { public void setUp() {
MockitoAnnotations.initMocks(this); MockitoAnnotations.initMocks(this);
mContext = spy(RuntimeEnvironment.application); mContext = spy(ApplicationProvider.getApplicationContext());
LifecycleOwner lifecycleOwner = () -> mLifecycle; when(mContext.getSystemService(SubscriptionManager.class)).thenReturn(mSubscriptionManager);
mLifecycle = new Lifecycle(lifecycleOwner); if (Looper.myLooper() == null) {
doReturn(mSubscriptionManager).when(mContext).getSystemService(SubscriptionManager.class); Looper.prepare();
}
mPreferenceManager = new PreferenceManager(mContext);
mScreen = mPreferenceManager.createPreferenceScreen(mContext);
mCategory = new PreferenceCategory(mContext); mCategory = new PreferenceCategory(mContext);
doReturn(mCategory).when(mScreen).findPreference(KEY); mCategory.setKey(KEY);
mScreen.addPreference(mCategory);
mController = new DisabledSubscriptionController(mContext, KEY); mController = new DisabledSubscriptionController(mContext, KEY);
mController.init(mLifecycle, SUB_ID); mController.init(mLifecycle, SUB_ID);
} }