From e3a821d6fe4f90389be61f2fb07f9d2cd02ef8ae Mon Sep 17 00:00:00 2001 From: Tim Peng Date: Mon, 15 Jun 2020 11:34:26 +0800 Subject: [PATCH] Unable to adjust remote session volume in Sound Setting -It is incorrect to compare the device ID with session ID -The preference key is the session ID and we should adjust remote session volume by it Fix: 158956140 Test: make -j42 RunSettingsRoboTests Change-Id: Ia815b7bfdf6d7e44aca9832f11371669e973d363 --- .../settings/notification/RemoteVolumeGroupController.java | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/com/android/settings/notification/RemoteVolumeGroupController.java b/src/com/android/settings/notification/RemoteVolumeGroupController.java index 4b045e289b0..6d3c96dcc3d 100644 --- a/src/com/android/settings/notification/RemoteVolumeGroupController.java +++ b/src/com/android/settings/notification/RemoteVolumeGroupController.java @@ -20,7 +20,6 @@ import android.content.Context; import android.content.Intent; import android.media.RoutingSessionInfo; import android.text.TextUtils; -import android.util.Log; import androidx.annotation.VisibleForTesting; import androidx.preference.Preference; @@ -136,11 +135,6 @@ public class RemoteVolumeGroupController extends BasePreferenceController implem @Override public boolean onPreferenceChange(Preference preference, Object newValue) { - final MediaDevice device = mLocalMediaManager.getMediaDeviceById(preference.getKey()); - if (device == null) { - Log.e(TAG, "Unable to find " + preference.getKey() + " to set volume"); - return false; - } ThreadUtils.postOnBackgroundThread(() -> { mLocalMediaManager.adjustSessionVolume(preference.getKey(), (int) newValue); }); @@ -184,6 +178,5 @@ public class RemoteVolumeGroupController extends BasePreferenceController implem @Override public void onSelectedDeviceStateChanged(MediaDevice device, int state) { - } }