From 1ebf80446f701f7a200358c24a9098dbfd346de1 Mon Sep 17 00:00:00 2001 From: Raff Tsai Date: Thu, 1 Aug 2019 18:28:51 +0800 Subject: [PATCH] Fix arabic language % character in wrong place info.batteryPercentString is applied language format. We don't need to format it again in BidiFormatter. Fixes: 136699046 Test: visual Change-Id: Ie89823c23fd23bd6a9a97821f3062cad4dfb3709 --- .../fuelgauge/TopLevelBatteryPreferenceController.java | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/com/android/settings/fuelgauge/TopLevelBatteryPreferenceController.java b/src/com/android/settings/fuelgauge/TopLevelBatteryPreferenceController.java index c4da6701f0f..f6182f661e9 100644 --- a/src/com/android/settings/fuelgauge/TopLevelBatteryPreferenceController.java +++ b/src/com/android/settings/fuelgauge/TopLevelBatteryPreferenceController.java @@ -17,7 +17,6 @@ package com.android.settings.fuelgauge; import android.content.Context; -import android.text.BidiFormatter; import androidx.preference.Preference; import androidx.preference.PreferenceScreen; @@ -49,8 +48,8 @@ public class TopLevelBatteryPreferenceController extends BasePreferenceControlle @Override public int getAvailabilityStatus() { return mContext.getResources().getBoolean(R.bool.config_show_top_level_battery) - ? AVAILABLE_UNSEARCHABLE - : UNSUPPORTED_ON_DEVICE; + ? AVAILABLE_UNSEARCHABLE + : UNSUPPORTED_ON_DEVICE; } @Override @@ -79,15 +78,14 @@ public class TopLevelBatteryPreferenceController extends BasePreferenceControlle return null; } CharSequence label; - final BidiFormatter formatter = BidiFormatter.getInstance(); if (!info.discharging && info.chargeLabel != null) { label = info.chargeLabel; } else if (info.remainingLabel == null) { label = info.batteryPercentString; } else { label = context.getString(R.string.power_remaining_settings_home_page, - formatter.unicodeWrap(info.batteryPercentString), - formatter.unicodeWrap(info.remainingLabel)); + info.batteryPercentString, + info.remainingLabel); } return label; }