From 1e2a91ba1ab40866f8840bd01cdadbe5fa39a251 Mon Sep 17 00:00:00 2001 From: Benedict Wong Date: Tue, 3 Mar 2020 16:48:25 -0800 Subject: [PATCH] Address cleanup comments from aosp/1234607 This change addresses minor cleanup comments from aosp/1234607, renaming a method. Bug: 148991741 Test: Compiles Change-Id: I2f31f8045040e6065a89e842b034aea605a99bd4 --- src/com/android/settings/vpn2/ConfigDialog.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/com/android/settings/vpn2/ConfigDialog.java b/src/com/android/settings/vpn2/ConfigDialog.java index a0aac19794d..4c50b743b73 100644 --- a/src/com/android/settings/vpn2/ConfigDialog.java +++ b/src/com/android/settings/vpn2/ConfigDialog.java @@ -342,14 +342,14 @@ class ConfigDialog extends AlertDialog implements TextWatcher, mView.findViewById(R.id.vpn_proxy_fields).setVisibility(visible); } - private boolean hasAdvancedOptionsEnabled() { + private boolean isAdvancedOptionsEnabled() { return mSearchDomains.getText().length() > 0 || mDnsServers.getText().length() > 0 || mRoutes.getText().length() > 0 || mProxyHost.getText().length() > 0 || mProxyPort.getText().length() > 0; } private void configureAdvancedOptionsVisibility() { - if (mShowOptions.isChecked() || hasAdvancedOptionsEnabled()) { + if (mShowOptions.isChecked() || isAdvancedOptionsEnabled()) { mView.findViewById(R.id.options).setVisibility(View.VISIBLE); mShowOptions.setVisibility(View.GONE);