From 6600ddec73a188446008b4a63e402b226b1c94cf Mon Sep 17 00:00:00 2001 From: Adrian Roos Date: Sun, 23 Jul 2017 14:18:16 +0200 Subject: [PATCH] FRP: Add dedicated explanation strings for ConfirmCredential Change-Id: I1bf63898509032560cd302fde9dfe05473336e49 Fixes: 63958816 Test: adb shell settings put global device_provisioned 1 && adb shell am start -a android.app.action.CONFIRM_FRP_CREDENTIAL; verify strings --- res/values/strings.xml | 14 ++++++++++++++ .../settings/password/ConfirmLockPassword.java | 8 ++++++++ .../settings/password/ConfirmLockPattern.java | 10 +++++++++- 3 files changed, 31 insertions(+), 1 deletion(-) diff --git a/res/values/strings.xml b/res/values/strings.xml index c2b90de1b0b..3e9b3737dde 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -3491,6 +3491,20 @@ continue. [CHAR LIMIT=100] --> For added security, enter your work password + + Your phone was reset to factory settings. To use this phone, enter your previous pattern. + + Your phone was reset to factory settings. To use this phone, enter your previous PIN. + + Your phone was reset to factory settings. To use this phone, enter your previous password. + + + Verify pattern + + Verify PIN + + Verify password + Wrong PIN diff --git a/src/com/android/settings/password/ConfirmLockPassword.java b/src/com/android/settings/password/ConfirmLockPassword.java index 328646b1710..dcb7b66992f 100644 --- a/src/com/android/settings/password/ConfirmLockPassword.java +++ b/src/com/android/settings/password/ConfirmLockPassword.java @@ -197,11 +197,19 @@ public class ConfirmLockPassword extends ConfirmDeviceCredentialBaseActivity { } private int getDefaultHeader() { + if (mFrp) { + return mIsAlpha ? R.string.lockpassword_confirm_your_password_header_frp + : R.string.lockpassword_confirm_your_pin_header_frp; + } return mIsAlpha ? R.string.lockpassword_confirm_your_password_header : R.string.lockpassword_confirm_your_pin_header; } private int getDefaultDetails() { + if (mFrp) { + return mIsAlpha ? R.string.lockpassword_confirm_your_password_details_frp + : R.string.lockpassword_confirm_your_pin_details_frp; + } boolean isStrongAuthRequired = isStrongAuthRequired(); boolean isProfile = UserManager.get(getActivity()).isManagedProfile(mEffectiveUserId); // Map boolean flags to an index by isStrongAuth << 2 + isProfile << 1 + isAlpha. diff --git a/src/com/android/settings/password/ConfirmLockPattern.java b/src/com/android/settings/password/ConfirmLockPattern.java index eb4278439d4..60d5a01b3c1 100644 --- a/src/com/android/settings/password/ConfirmLockPattern.java +++ b/src/com/android/settings/password/ConfirmLockPattern.java @@ -243,6 +243,9 @@ public class ConfirmLockPattern extends ConfirmDeviceCredentialBaseActivity { } private int getDefaultDetails() { + if (mFrp) { + return R.string.lockpassword_confirm_your_pattern_details_frp; + } final boolean isStrongAuthRequired = isStrongAuthRequired(); if (UserManager.get(getActivity()).isManagedProfile(mEffectiveUserId)) { return isStrongAuthRequired @@ -296,7 +299,7 @@ public class ConfirmLockPattern extends ConfirmDeviceCredentialBaseActivity { if (mHeaderText != null) { mHeaderTextView.setText(mHeaderText); } else { - mHeaderTextView.setText(R.string.lockpassword_confirm_your_pattern_header); + mHeaderTextView.setText(getDefaultHeader()); } if (mDetailsText != null) { mDetailsTextView.setText(mDetailsText); @@ -331,6 +334,11 @@ public class ConfirmLockPattern extends ConfirmDeviceCredentialBaseActivity { mHeaderTextView.announceForAccessibility(mHeaderTextView.getText()); } + private int getDefaultHeader() { + return mFrp ? R.string.lockpassword_confirm_your_pattern_header_frp + : R.string.lockpassword_confirm_your_pattern_header; + } + private Runnable mClearPatternRunnable = new Runnable() { public void run() { mLockPatternView.clearPattern();