From c3d4b9ace9614734f467e8d0a8f72ad6b4d0473d Mon Sep 17 00:00:00 2001 From: Hugh Chen Date: Mon, 31 Aug 2020 15:48:46 +0800 Subject: [PATCH] Fix cast volume control bar not work Use hashcode as a requestCode id, since the same requestCode will cause the intent be cached. Bug: 163095633 Test: make -j42 RunSettingsRoboTests Change-Id: I2c120f18e24a66aeff5565e952fa4064149ec540 Merged-In: I2c120f18e24a66aeff5565e952fa4064149ec540 (cherry picked from commit 7f3efd435776ebdf3d8b90181d35fb16e5f86bdc) --- src/com/android/settings/media/RemoteMediaSlice.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/com/android/settings/media/RemoteMediaSlice.java b/src/com/android/settings/media/RemoteMediaSlice.java index 61a53f3f8ed..510a60e48d7 100644 --- a/src/com/android/settings/media/RemoteMediaSlice.java +++ b/src/com/android/settings/media/RemoteMediaSlice.java @@ -91,7 +91,6 @@ public class RemoteMediaSlice implements CustomSliceable { R.drawable.ic_volume_remote); // To create an empty icon to indent the row final IconCompat emptyIcon = createEmptyIcon(); - int requestCode = 0; for (RoutingSessionInfo info : infos) { final int maxVolume = info.getVolumeMax(); if (maxVolume <= 0) { @@ -104,7 +103,7 @@ public class RemoteMediaSlice implements CustomSliceable { listBuilder.addInputRange(new InputRangeBuilder() .setTitleItem(icon, ListBuilder.ICON_IMAGE) .setTitle(castVolume) - .setInputAction(getSliderInputAction(requestCode++, info.getId())) + .setInputAction(getSliderInputAction(info.getId().hashCode(), info.getId())) .setPrimaryAction(getSoundSettingAction(castVolume, icon, info.getId())) .setMax(maxVolume) .setValue(info.getVolume()));