Merge "Fix "Play media to" popup close issue when screen rotate"

This commit is contained in:
TreeHugger Robot
2019-01-10 19:43:49 +00:00
committed by Android (Google) Code Review
2 changed files with 18 additions and 6 deletions

View File

@@ -84,8 +84,8 @@ public class UpdatableListPreferenceDialogFragment extends PreferenceDialogFragm
@Override
public void onDialogClosed(boolean positiveResult) {
final ListPreference preference = getListPreference();
if (positiveResult && mClickedDialogEntryIndex >= 0) {
final ListPreference preference = getListPreference();
final String value = mEntryValues[mClickedDialogEntryIndex].toString();
if (preference.callChangeListener(value)) {
preference.setValue(value);
@@ -144,7 +144,8 @@ public class UpdatableListPreferenceDialogFragment extends PreferenceDialogFragm
return mMetricsCategory;
}
private ListPreference getListPreference() {
@VisibleForTesting
ListPreference getListPreference() {
return (ListPreference) getPreference();
}