From 1ba9127696e9eb684b1d78fb6e7896b523948b17 Mon Sep 17 00:00:00 2001 From: "Philip P. Moltmann" Date: Mon, 8 Aug 2016 10:57:22 -0700 Subject: [PATCH] Set Fragment title in onCreate. To allow the accessibility to read the title early enough. Fixes: 30677578 Change-Id: I2dbd8f0fa7697038cf69e0282ebcb590fbc64cc2 --- .../print/PrintServiceSettingsFragment.java | 22 +++++++++---------- 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/src/com/android/settings/print/PrintServiceSettingsFragment.java b/src/com/android/settings/print/PrintServiceSettingsFragment.java index 6ef900ba37e..d16f24d2a3e 100644 --- a/src/com/android/settings/print/PrintServiceSettingsFragment.java +++ b/src/com/android/settings/print/PrintServiceSettingsFragment.java @@ -117,10 +117,6 @@ public class PrintServiceSettingsFragment extends SettingsPreferenceFragment private PrintersAdapter mPrintersAdapter; - // TODO: Showing sub-sub fragment does not handle the activity title - // so we do it but this is wrong. Do a real fix when there is time. - private CharSequence mOldActivityTitle; - private int mLastUnfilteredItemCount; private boolean mServiceEnabled; @@ -133,16 +129,21 @@ public class PrintServiceSettingsFragment extends SettingsPreferenceFragment } @Override - public View onCreateView(LayoutInflater inflater, ViewGroup container, - Bundle savedInstanceState) { - View root = super.onCreateView(inflater, container, savedInstanceState); - - mServiceEnabled = getArguments().getBoolean(PrintSettingsFragment.EXTRA_CHECKED); + public void onCreate(Bundle icicle) { + super.onCreate(icicle); String title = getArguments().getString(PrintSettingsFragment.EXTRA_TITLE); if (!TextUtils.isEmpty(title)) { getActivity().setTitle(title); } + } + + @Override + public View onCreateView(LayoutInflater inflater, ViewGroup container, + Bundle savedInstanceState) { + View root = super.onCreateView(inflater, container, savedInstanceState); + + mServiceEnabled = getArguments().getBoolean(PrintSettingsFragment.EXTRA_CHECKED); return root; } @@ -177,9 +178,6 @@ public class PrintServiceSettingsFragment extends SettingsPreferenceFragment @Override public void onDestroyView() { - if (mOldActivityTitle != null) { - getActivity().getActionBar().setTitle(mOldActivityTitle); - } super.onDestroyView(); mSwitchBar.removeOnSwitchChangeListener(this); mSwitchBar.hide();