From 1b5015cae6c790f92a2d3366737641eae9aaad72 Mon Sep 17 00:00:00 2001 From: Charles He Date: Sat, 1 Apr 2017 18:52:25 +0100 Subject: [PATCH] VPN settings: add missing string resource Previously, a string resource was deleted by mistake in commit cce4e61260153dc4826e648f733f7451f73dfa01. This bug went uncaught by local and presubmit build checks. We add the missing string back to strings.xml to fix the build. The affected string is referenced in ManageablePreference.java. Apologies for any inconvenience. Test: make SettingsRoboTests; manually navigate through VPN settings Bug: 36815998 Change-Id: Ibc2ef9ad43cad73ef5f078714faf5c52bc7198c6 --- res/values/strings.xml | 2 ++ src/com/android/settings/vpn2/ManageablePreference.java | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/res/values/strings.xml b/res/values/strings.xml index de2fffebcd8..3173e85e73d 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -5656,6 +5656,8 @@ Stay connected to VPN at all times Not supported by this app + + Always-on active Block connections without VPN diff --git a/src/com/android/settings/vpn2/ManageablePreference.java b/src/com/android/settings/vpn2/ManageablePreference.java index b45ae45c574..11da7585416 100644 --- a/src/com/android/settings/vpn2/ManageablePreference.java +++ b/src/com/android/settings/vpn2/ManageablePreference.java @@ -87,7 +87,7 @@ public abstract class ManageablePreference extends GearPreference { final String[] states = res.getStringArray(R.array.vpn_states); String summary = (mState == STATE_NONE ? "" : states[mState]); if (mIsAlwaysOn) { - final String alwaysOnString = res.getString(R.string.vpn_always_on_active); + final String alwaysOnString = res.getString(R.string.vpn_always_on_summary_active); summary = TextUtils.isEmpty(summary) ? alwaysOnString : res.getString( R.string.join_two_unrelated_items, summary, alwaysOnString); }