diff --git a/tests/robotests/src/com/android/settings/SettingsActivityTest.java b/tests/robotests/src/com/android/settings/SettingsActivityTest.java index ada4c0ea8a9..89f84496a6e 100644 --- a/tests/robotests/src/com/android/settings/SettingsActivityTest.java +++ b/tests/robotests/src/com/android/settings/SettingsActivityTest.java @@ -37,6 +37,7 @@ import androidx.fragment.app.FragmentTransaction; import com.android.settings.core.OnActivityResultListener; import com.android.settings.testutils.FakeFeatureFactory; +import com.android.settings.testutils.shadow.ShadowUserManager; import org.junit.Before; import org.junit.Test; @@ -46,11 +47,13 @@ import org.mockito.MockitoAnnotations; import org.robolectric.Robolectric; import org.robolectric.RobolectricTestRunner; import org.robolectric.RuntimeEnvironment; +import org.robolectric.annotation.Config; import java.util.ArrayList; import java.util.List; @RunWith(RobolectricTestRunner.class) +@Config(shadows = ShadowUserManager.class) public class SettingsActivityTest { @Mock diff --git a/tests/robotests/src/com/android/settings/accounts/AvatarViewMixinTest.java b/tests/robotests/src/com/android/settings/accounts/AvatarViewMixinTest.java index 80f21fcf53a..02b318fb3bb 100644 --- a/tests/robotests/src/com/android/settings/accounts/AvatarViewMixinTest.java +++ b/tests/robotests/src/com/android/settings/accounts/AvatarViewMixinTest.java @@ -43,6 +43,7 @@ import android.widget.ImageView; import com.android.settings.homepage.SettingsHomepageActivity; import com.android.settings.homepage.contextualcards.slices.BatteryFixSliceTest; +import com.android.settings.testutils.shadow.ShadowUserManager; import org.junit.Before; import org.junit.Test; @@ -61,6 +62,7 @@ import org.robolectric.shadows.ShadowContentResolver; import org.robolectric.shadows.ShadowPackageManager; @RunWith(RobolectricTestRunner.class) +@Config(shadows = ShadowUserManager.class) public class AvatarViewMixinTest { private static final String FAKE_ACCOUNT = "test@domain.com"; private static final String FAKE_DOMAIN = "domain.com"; diff --git a/tests/robotests/src/com/android/settings/accounts/TopLevelAccountEntryPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/accounts/TopLevelAccountEntryPreferenceControllerTest.java index 1cd5fb153fa..3a67d7fb04f 100644 --- a/tests/robotests/src/com/android/settings/accounts/TopLevelAccountEntryPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/accounts/TopLevelAccountEntryPreferenceControllerTest.java @@ -48,15 +48,12 @@ public class TopLevelAccountEntryPreferenceControllerTest { mController = new TopLevelAccountEntryPreferenceController(mContext, "test_key"); LABELS = ShadowAuthenticationHelper.getLabels(); TYPES = ShadowAuthenticationHelper.getTypes(); + FeatureFlagUtils.setEnabled(mContext, FeatureFlags.SILKY_HOME, false); } @After public void tearDown() { ShadowAuthenticationHelper.reset(); - - if (FeatureFlagUtils.isEnabled(mContext, FeatureFlags.SILKY_HOME)) { - FeatureFlagUtils.setEnabled(mContext, FeatureFlags.SILKY_HOME, false); - } } @Test diff --git a/tests/robotests/src/com/android/settings/backup/BackupSettingsHelperTest.java b/tests/robotests/src/com/android/settings/backup/BackupSettingsHelperTest.java index b6ef32c5e9f..a662be8a7b9 100644 --- a/tests/robotests/src/com/android/settings/backup/BackupSettingsHelperTest.java +++ b/tests/robotests/src/com/android/settings/backup/BackupSettingsHelperTest.java @@ -35,8 +35,10 @@ import android.content.res.Resources; import android.os.IBinder; import android.os.RemoteException; import android.os.UserHandle; +import android.util.FeatureFlagUtils; import com.android.settings.R; +import com.android.settings.core.FeatureFlags; import org.junit.Before; import org.junit.Test; @@ -81,6 +83,7 @@ public class BackupSettingsHelperTest { when(mBackupManager.getCurrentTransport()).thenReturn("test_transport"); mBackupSettingsHelper = new BackupSettingsHelper(mContext); mUserManager = Shadow.extract(mContext.getSystemService(Context.USER_SERVICE)); + FeatureFlagUtils.setEnabled(mContext, FeatureFlags.SILKY_HOME, false); } @Test diff --git a/tests/robotests/src/com/android/settings/connecteddevice/TopLevelConnectedDevicesPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/connecteddevice/TopLevelConnectedDevicesPreferenceControllerTest.java index 232bc16526c..b1f9ed17719 100644 --- a/tests/robotests/src/com/android/settings/connecteddevice/TopLevelConnectedDevicesPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/connecteddevice/TopLevelConnectedDevicesPreferenceControllerTest.java @@ -27,7 +27,6 @@ import android.util.FeatureFlagUtils; import com.android.settings.R; import com.android.settings.core.FeatureFlags; -import org.junit.After; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; @@ -47,13 +46,7 @@ public class TopLevelConnectedDevicesPreferenceControllerTest { public void setUp() { mContext = RuntimeEnvironment.application; mController = new TopLevelConnectedDevicesPreferenceController(mContext, "test_key"); - } - - @After - public void tearDown() { - if (FeatureFlagUtils.isEnabled(mContext, FeatureFlags.SILKY_HOME)) { - FeatureFlagUtils.setEnabled(mContext, FeatureFlags.SILKY_HOME, false); - } + FeatureFlagUtils.setEnabled(mContext, FeatureFlags.SILKY_HOME, false); } @Test diff --git a/tests/robotests/src/com/android/settings/dashboard/DashboardFeatureProviderImplTest.java b/tests/robotests/src/com/android/settings/dashboard/DashboardFeatureProviderImplTest.java index a0024c04895..1e6bc4114eb 100644 --- a/tests/robotests/src/com/android/settings/dashboard/DashboardFeatureProviderImplTest.java +++ b/tests/robotests/src/com/android/settings/dashboard/DashboardFeatureProviderImplTest.java @@ -77,7 +77,6 @@ import com.android.settingslib.drawer.ProviderTile; import com.android.settingslib.drawer.Tile; import com.android.settingslib.drawer.TileUtils; -import org.junit.After; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; @@ -147,13 +146,7 @@ public class DashboardFeatureProviderImplTest { .thenReturn(new ResolveInfo()); mFeatureFactory = FakeFeatureFactory.setupForTest(); mImpl = new DashboardFeatureProviderImpl(mContext); - } - - @After - public void tearDown() { - if (FeatureFlagUtils.isEnabled(mContext, FeatureFlags.SILKY_HOME)) { - FeatureFlagUtils.setEnabled(mContext, FeatureFlags.SILKY_HOME, false); - } + FeatureFlagUtils.setEnabled(mContext, FeatureFlags.SILKY_HOME, false); } @Test diff --git a/tests/robotests/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceControllerTest.java b/tests/robotests/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceControllerTest.java index e19066a2d76..7e6be9ba476 100644 --- a/tests/robotests/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/deviceinfo/TopLevelStoragePreferenceControllerTest.java @@ -36,7 +36,6 @@ import com.android.settings.R; import com.android.settings.core.FeatureFlags; import com.android.settingslib.deviceinfo.StorageManagerVolumeProvider; -import org.junit.After; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; @@ -69,13 +68,7 @@ public class TopLevelStoragePreferenceControllerTest { when(mStorageManagerVolumeProvider.getVolumes()).thenReturn(mVolumes); mController = new TopLevelStoragePreferenceController(mContext, "test_key"); - } - - @After - public void tearDown() { - if (FeatureFlagUtils.isEnabled(mContext, FeatureFlags.SILKY_HOME)) { - FeatureFlagUtils.setEnabled(mContext, FeatureFlags.SILKY_HOME, false); - } + FeatureFlagUtils.setEnabled(mContext, FeatureFlags.SILKY_HOME, false); } @Test diff --git a/tests/robotests/src/com/android/settings/deviceinfo/aboutphone/TopLevelAboutDevicePreferenceControllerTest.java b/tests/robotests/src/com/android/settings/deviceinfo/aboutphone/TopLevelAboutDevicePreferenceControllerTest.java index 16c77a4951d..d20beabf3a5 100644 --- a/tests/robotests/src/com/android/settings/deviceinfo/aboutphone/TopLevelAboutDevicePreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/deviceinfo/aboutphone/TopLevelAboutDevicePreferenceControllerTest.java @@ -27,7 +27,6 @@ import android.util.FeatureFlagUtils; import com.android.settings.core.FeatureFlags; -import org.junit.After; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; @@ -44,13 +43,7 @@ public class TopLevelAboutDevicePreferenceControllerTest { public void setUp() { mContext = RuntimeEnvironment.application; mController = new TopLevelAboutDevicePreferenceController(mContext, "test_key"); - } - - @After - public void teardown() { - if (FeatureFlagUtils.isEnabled(mContext, FeatureFlags.SILKY_HOME)) { - FeatureFlagUtils.setEnabled(mContext, FeatureFlags.SILKY_HOME, false); - } + FeatureFlagUtils.setEnabled(mContext, FeatureFlags.SILKY_HOME, false); } @Test diff --git a/tests/robotests/src/com/android/settings/display/TopLevelDisplayPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/display/TopLevelDisplayPreferenceControllerTest.java index a52ad71c345..864d2b925fd 100644 --- a/tests/robotests/src/com/android/settings/display/TopLevelDisplayPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/display/TopLevelDisplayPreferenceControllerTest.java @@ -36,7 +36,6 @@ import android.util.FeatureFlagUtils; import com.android.settings.R; import com.android.settings.core.FeatureFlags; -import org.junit.After; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; @@ -66,13 +65,7 @@ public class TopLevelDisplayPreferenceControllerTest { when(mContext.getString(R.string.config_wallpaper_picker_class)).thenReturn("cls"); mController = new TopLevelDisplayPreferenceController(mContext, "test_key"); - } - - @After - public void tearDown() { - if (FeatureFlagUtils.isEnabled(mContext, FeatureFlags.SILKY_HOME)) { - FeatureFlagUtils.setEnabled(mContext, FeatureFlags.SILKY_HOME, false); - } + FeatureFlagUtils.setEnabled(mContext, FeatureFlags.SILKY_HOME, false); } @Test diff --git a/tests/robotests/src/com/android/settings/fuelgauge/TopLevelBatteryPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/fuelgauge/TopLevelBatteryPreferenceControllerTest.java index 6d2298b755a..f2677ce8fd8 100644 --- a/tests/robotests/src/com/android/settings/fuelgauge/TopLevelBatteryPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/fuelgauge/TopLevelBatteryPreferenceControllerTest.java @@ -27,7 +27,6 @@ import android.util.FeatureFlagUtils; import com.android.settings.R; import com.android.settings.core.FeatureFlags; -import org.junit.After; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; @@ -44,13 +43,7 @@ public class TopLevelBatteryPreferenceControllerTest { public void setUp() { mContext = RuntimeEnvironment.application; mController = new TopLevelBatteryPreferenceController(mContext, "test_key"); - } - - @After - public void tearDown() { - if (FeatureFlagUtils.isEnabled(mContext, FeatureFlags.SILKY_HOME)) { - FeatureFlagUtils.setEnabled(mContext, FeatureFlags.SILKY_HOME, false); - } + FeatureFlagUtils.setEnabled(mContext, FeatureFlags.SILKY_HOME, false); } @Test diff --git a/tests/robotests/src/com/android/settings/gestures/GesturesSettingsPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/gestures/GesturesSettingsPreferenceControllerTest.java index 1e842078b47..df1dfd03c6f 100644 --- a/tests/robotests/src/com/android/settings/gestures/GesturesSettingsPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/gestures/GesturesSettingsPreferenceControllerTest.java @@ -28,10 +28,12 @@ import android.app.Activity; import android.content.ContentResolver; import android.content.Context; import android.provider.Settings; +import android.util.FeatureFlagUtils; import androidx.preference.Preference; import com.android.settings.R; +import com.android.settings.core.FeatureFlags; import com.android.settings.testutils.FakeFeatureFactory; import com.android.settings.testutils.shadow.ShadowSecureSettings; import com.android.settingslib.core.AbstractPreferenceController; @@ -65,6 +67,7 @@ public class GesturesSettingsPreferenceControllerTest { MockitoAnnotations.initMocks(this); FakeFeatureFactory.setupForTest(); mController = new GesturesSettingPreferenceController(mActivity); + FeatureFlagUtils.setEnabled(RuntimeEnvironment.application, FeatureFlags.SILKY_HOME, false); } @Test diff --git a/tests/robotests/src/com/android/settings/homepage/SettingsHomepageActivityTest.java b/tests/robotests/src/com/android/settings/homepage/SettingsHomepageActivityTest.java index bae4432aedc..40315d267fb 100644 --- a/tests/robotests/src/com/android/settings/homepage/SettingsHomepageActivityTest.java +++ b/tests/robotests/src/com/android/settings/homepage/SettingsHomepageActivityTest.java @@ -26,11 +26,13 @@ import static org.mockito.Mockito.verify; import static org.mockito.Mockito.when; import android.os.Build; +import android.util.FeatureFlagUtils; import android.view.Window; import android.view.WindowManager; import android.widget.FrameLayout; import com.android.settings.R; +import com.android.settings.core.FeatureFlags; import com.android.settings.core.HideNonSystemOverlayMixin; import com.android.settings.homepage.contextualcards.slices.BatteryFixSliceTest; @@ -41,6 +43,7 @@ import org.mockito.ArgumentCaptor; import org.mockito.MockitoAnnotations; import org.robolectric.Robolectric; import org.robolectric.RobolectricTestRunner; +import org.robolectric.RuntimeEnvironment; import org.robolectric.android.controller.ActivityController; import org.robolectric.annotation.Config; import org.robolectric.util.ReflectionHelpers; @@ -51,6 +54,7 @@ public class SettingsHomepageActivityTest { @Before public void setUp() { MockitoAnnotations.initMocks(this); + FeatureFlagUtils.setEnabled(RuntimeEnvironment.application, FeatureFlags.SILKY_HOME, false); } @Test diff --git a/tests/robotests/src/com/android/settings/location/TopLevelLocationPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/location/TopLevelLocationPreferenceControllerTest.java index 2fa7413ff19..f5bc9619acd 100644 --- a/tests/robotests/src/com/android/settings/location/TopLevelLocationPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/location/TopLevelLocationPreferenceControllerTest.java @@ -25,7 +25,6 @@ import android.util.FeatureFlagUtils; import com.android.settings.R; import com.android.settings.core.FeatureFlags; -import org.junit.After; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; @@ -44,13 +43,7 @@ public class TopLevelLocationPreferenceControllerTest { mContext = RuntimeEnvironment.application; mController = new TopLevelLocationPreferenceController(mContext, PREFERENCE_KEY); mLocationManager = (LocationManager) mContext.getSystemService(Context.LOCATION_SERVICE); - } - - @After - public void tearDown() { - if (FeatureFlagUtils.isEnabled(mContext, FeatureFlags.SILKY_HOME)) { - FeatureFlagUtils.setEnabled(mContext, FeatureFlags.SILKY_HOME, false); - } + FeatureFlagUtils.setEnabled(mContext, FeatureFlags.SILKY_HOME, false); } @Test diff --git a/tests/robotests/src/com/android/settings/network/TopLevelNetworkEntryPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/network/TopLevelNetworkEntryPreferenceControllerTest.java index 857b3eba06b..fc01c6872ba 100644 --- a/tests/robotests/src/com/android/settings/network/TopLevelNetworkEntryPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/network/TopLevelNetworkEntryPreferenceControllerTest.java @@ -74,15 +74,12 @@ public class TopLevelNetworkEntryPreferenceControllerTest { mMobileNetworkPreferenceController); ReflectionHelpers.setField(mController, "mTetherPreferenceController", mTetherPreferenceController); + FeatureFlagUtils.setEnabled(mContext, FeatureFlags.SILKY_HOME, false); } @After public void tearDown() { ShadowUtils.reset(); - - if (FeatureFlagUtils.isEnabled(mContext, FeatureFlags.SILKY_HOME)) { - FeatureFlagUtils.setEnabled(mContext, FeatureFlags.SILKY_HOME, false); - } } @Test diff --git a/tests/robotests/src/com/android/settings/password/ChooseLockGenericTest.java b/tests/robotests/src/com/android/settings/password/ChooseLockGenericTest.java index 03ce25aaea7..634b9a8e5db 100644 --- a/tests/robotests/src/com/android/settings/password/ChooseLockGenericTest.java +++ b/tests/robotests/src/com/android/settings/password/ChooseLockGenericTest.java @@ -45,6 +45,7 @@ import android.content.Context; import android.content.Intent; import android.os.Bundle; import android.provider.Settings.Global; +import android.util.FeatureFlagUtils; import androidx.annotation.Nullable; import androidx.preference.Preference; @@ -53,6 +54,7 @@ import com.android.internal.widget.LockPatternUtils; import com.android.internal.widget.LockscreenCredential; import com.android.settings.R; import com.android.settings.biometrics.BiometricEnrollBase; +import com.android.settings.core.FeatureFlags; import com.android.settings.password.ChooseLockGeneric.ChooseLockGenericFragment; import com.android.settings.search.SearchFeatureProvider; import com.android.settings.testutils.shadow.ShadowLockPatternUtils; @@ -68,6 +70,7 @@ import org.junit.Test; import org.junit.runner.RunWith; import org.robolectric.Robolectric; import org.robolectric.RobolectricTestRunner; +import org.robolectric.RuntimeEnvironment; import org.robolectric.annotation.Config; import org.robolectric.shadows.ShadowApplication; import org.robolectric.shadows.ShadowPersistentDataBlockManager; @@ -90,6 +93,7 @@ public class ChooseLockGenericTest { public void setUp() { Global.putInt(application.getContentResolver(), Global.DEVICE_PROVISIONED, 1); mFragment = new ChooseLockGenericFragment(); + FeatureFlagUtils.setEnabled(RuntimeEnvironment.application, FeatureFlags.SILKY_HOME, false); } @After diff --git a/tests/robotests/src/com/android/settings/security/TopLevelSecurityEntryPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/security/TopLevelSecurityEntryPreferenceControllerTest.java index 33d22d4ed45..05abc40b312 100644 --- a/tests/robotests/src/com/android/settings/security/TopLevelSecurityEntryPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/security/TopLevelSecurityEntryPreferenceControllerTest.java @@ -30,7 +30,6 @@ import android.util.FeatureFlagUtils; import com.android.settings.R; import com.android.settings.core.FeatureFlags; -import org.junit.After; import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; @@ -58,13 +57,7 @@ public class TopLevelSecurityEntryPreferenceControllerTest { when(mContext.getSystemService(Context.FACE_SERVICE)) .thenReturn(mFaceManager); mController = new TopLevelSecurityEntryPreferenceController(mContext, "test_key"); - } - - @After - public void tearDown() { - if (FeatureFlagUtils.isEnabled(mContext, FeatureFlags.SILKY_HOME)) { - FeatureFlagUtils.setEnabled(mContext, FeatureFlags.SILKY_HOME, false); - } + FeatureFlagUtils.setEnabled(mContext, FeatureFlags.SILKY_HOME, false); } @Test diff --git a/tests/robotests/src/com/android/settings/system/ResetPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/system/ResetPreferenceControllerTest.java index 0d34a76628f..e80e77addc3 100644 --- a/tests/robotests/src/com/android/settings/system/ResetPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/system/ResetPreferenceControllerTest.java @@ -21,8 +21,10 @@ import android.content.Context; import android.content.pm.UserInfo; import android.os.UserHandle; import android.provider.Settings; +import android.util.FeatureFlagUtils; import com.android.settings.R; +import com.android.settings.core.FeatureFlags; import com.android.settings.testutils.shadow.ShadowUserManager; import org.junit.Before; @@ -47,6 +49,7 @@ public class ResetPreferenceControllerTest { mContext = RuntimeEnvironment.application; mController = new ResetPreferenceController(mContext, KEY_RESET_DASHBOARD); mShadowUserManager = ShadowUserManager.getShadow(); + FeatureFlagUtils.setEnabled(mContext, FeatureFlags.SILKY_HOME, false); } @Test