Split Ambient Display settings.
1. Reverting the changes for Display->Ambient Display; this setting will control incoming notification pulse. 2. Added 2 separate entries in gestures settings to control pick up and double tap gestures-triggered pulsing for Ambient Display. 3. Added automated tests to verify the preference initializes to the correct default value, and also verify that toggling the preference updates the corresponding settings correctly. Test: make SettingsTests Bug: 30595437 Change-Id: I125bf75fc4ccfea126a00ffae4207fcb789f487a
This commit is contained in:
@@ -41,7 +41,6 @@ import android.support.v7.preference.DropDownPreference;
|
||||
import android.support.v7.preference.ListPreference;
|
||||
import android.support.v7.preference.Preference;
|
||||
import android.support.v7.preference.Preference.OnPreferenceChangeListener;
|
||||
import android.support.v7.preference.PreferenceScreen;
|
||||
import android.text.TextUtils;
|
||||
import android.util.Log;
|
||||
|
||||
@@ -97,10 +96,10 @@ public class DisplaySettings extends SettingsPreferenceFragment implements
|
||||
private ListPreference mNightModePreference;
|
||||
private Preference mScreenSaverPreference;
|
||||
private SwitchPreference mLiftToWakePreference;
|
||||
private SwitchPreference mDozePreference;
|
||||
private SwitchPreference mTapToWakePreference;
|
||||
private SwitchPreference mAutoBrightnessPreference;
|
||||
private SwitchPreference mCameraGesturePreference;
|
||||
private PreferenceScreen mDozePreference;
|
||||
|
||||
@Override
|
||||
protected int getMetricsCategory() {
|
||||
@@ -144,10 +143,11 @@ public class DisplaySettings extends SettingsPreferenceFragment implements
|
||||
removePreference(KEY_LIFT_TO_WAKE);
|
||||
}
|
||||
|
||||
if (!isDozeAvailable(activity)) {
|
||||
removePreference(KEY_DOZE);
|
||||
if (isDozeAvailable(activity)) {
|
||||
mDozePreference = (SwitchPreference) findPreference(KEY_DOZE);
|
||||
mDozePreference.setOnPreferenceChangeListener(this);
|
||||
} else {
|
||||
mDozePreference = (PreferenceScreen) findPreference(KEY_DOZE);
|
||||
removePreference(KEY_DOZE);
|
||||
}
|
||||
|
||||
if (isTapToWakeAvailable(getResources())) {
|
||||
@@ -360,6 +360,12 @@ public class DisplaySettings extends SettingsPreferenceFragment implements
|
||||
mTapToWakePreference.setChecked(value != 0);
|
||||
}
|
||||
|
||||
// Update doze if it is available.
|
||||
if (mDozePreference != null) {
|
||||
int value = Settings.Secure.getInt(getContentResolver(), DOZE_ENABLED, 1);
|
||||
mDozePreference.setChecked(value != 0);
|
||||
}
|
||||
|
||||
// Update camera gesture #1 if it is available.
|
||||
if (mCameraGesturePreference != null) {
|
||||
int value = Settings.Secure.getInt(getContentResolver(), CAMERA_GESTURE_DISABLED, 0);
|
||||
@@ -407,6 +413,10 @@ public class DisplaySettings extends SettingsPreferenceFragment implements
|
||||
boolean value = (Boolean) objValue;
|
||||
Settings.Secure.putInt(getContentResolver(), WAKE_GESTURE_ENABLED, value ? 1 : 0);
|
||||
}
|
||||
if (preference == mDozePreference) {
|
||||
boolean value = (Boolean) objValue;
|
||||
Settings.Secure.putInt(getContentResolver(), DOZE_ENABLED, value ? 1 : 0);
|
||||
}
|
||||
if (preference == mTapToWakePreference) {
|
||||
boolean value = (Boolean) objValue;
|
||||
Settings.Secure.putInt(getContentResolver(), DOUBLE_TAP_TO_WAKE, value ? 1 : 0);
|
||||
|
Reference in New Issue
Block a user