PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update dark mode in accessiblity settings

Browse Source 
There was an entry point to dark mode that wasn't updated when the
display settings one was changed to point to a new screen. This
change makes it so that clicking dark mode in accessiblity also
opens the same screen.

Test: robotests pass
Bug: 129406772
Change-Id: I0ad830638e04e5520cdf7de6927764fa6b68a179
This commit is contained in:
Salvador Martinez
2019-03-27 18:29:40 -07:00
parent 12256ca49f
commit 194abe94d0
3 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
res/xml/accessibility_settings.xml
View File

@@ -58,12 +58,10 @@
android:title="@string/screen_zoom_title" android:title="@string/screen_zoom_title"
settings:searchable="false"/> settings:searchable="false"/>
<ListPreference <Preference
android:key="dark_ui_mode_accessibility" android:key="dark_ui_mode_accessibility"
android:fragment="com.android.settings.display.DarkUISettings"
android:title="@string/dark_ui_mode" android:title="@string/dark_ui_mode"
android:dialogTitle="@string/dark_ui_mode_title"
android:entries="@array/dark_ui_mode_entries"
android:entryValues="@array/dark_ui_mode_values"
settings:searchable="false" /> settings:searchable="false" />
<Preference <Preference

2
src/com/android/settings/accessibility/AccessibilitySettings.java
View File

@@ -239,7 +239,7 @@ public class AccessibilitySettings extends SettingsPreferenceFragment implements
private SwitchPreference mToggleInversionPreference; private SwitchPreference mToggleInversionPreference;
private ColorInversionPreferenceController mInversionPreferenceController; private ColorInversionPreferenceController mInversionPreferenceController;
private AccessibilityHearingAidPreferenceController mHearingAidPreferenceController; private AccessibilityHearingAidPreferenceController mHearingAidPreferenceController;
private ListPreference mDarkUIModePreference; private Preference mDarkUIModePreference;
private DarkUIPreferenceController mDarkUIPreferenceController; private DarkUIPreferenceController mDarkUIPreferenceController;
private int mLongPressTimeoutDefault; private int mLongPressTimeoutDefault;

2
tests/robotests/src/com/android/settings/accessibility/AccessibilitySettingsTest.java
View File

@@ -156,7 +156,7 @@ public class AccessibilitySettingsTest {
@Test @Test
public void testDarkUIModePreferenceSummary_shouldUpdateSummary() { public void testDarkUIModePreferenceSummary_shouldUpdateSummary() {
final ListPreference darkUIModePreference = new ListPreference(mContext); final Preference darkUIModePreference = new Preference(mContext);
final DarkUIPreferenceController mController; final DarkUIPreferenceController mController;
doReturn(darkUIModePreference).when(mSettings).findPreference( doReturn(darkUIModePreference).when(mSettings).findPreference(
DARK_UI_MODE_PREFERENCE); DARK_UI_MODE_PREFERENCE);