From 24ac9876d12559e7fe54378d4864eb6a5cc02ce1 Mon Sep 17 00:00:00 2001 From: Edgar Wang Date: Wed, 27 May 2020 13:21:29 +0800 Subject: [PATCH] [a11y] Fix Talkback speak "Edit box, Nickname" for "Select photo" button. In multi-user Profile info dialog, set labelFor will set the editbox which serves as the label of the iconview represented by this info for accessibility purposes. But since both of views have different purposes, we should not set label for icon. Bug: 141455211 Test: manual Change-Id: I6c7087fc7d2bcc75c388992c1a2b8ecc010cc279 --- res/layout/edit_user_info_dialog_content.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/res/layout/edit_user_info_dialog_content.xml b/res/layout/edit_user_info_dialog_content.xml index 62c711b789e..895cef63fb9 100644 --- a/res/layout/edit_user_info_dialog_content.xml +++ b/res/layout/edit_user_info_dialog_content.xml @@ -42,7 +42,6 @@ android:singleLine="true" android:textAppearance="?android:attr/textAppearanceMedium" android:textAlignment="viewStart" - android:labelFor="@id/user_photo" android:inputType="text|textCapWords" android:selectAllOnFocus="true" android:hint="@string/user_nickname"