Merge "Rename RadioButtonPreference -> SelectorWithWidgetPreference."

This commit is contained in:
Julia Reynolds
2021-08-05 20:34:13 +00:00
committed by Android (Google) Code Review
65 changed files with 311 additions and 305 deletions

View File

@@ -27,27 +27,27 @@
settings:searchable="false" settings:searchable="false"
settings:lottie_rawRes="@drawable/accessibility_dwell" /> settings:lottie_rawRes="@drawable/accessibility_dwell" />
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="accessibility_control_autoclick_default" android:key="accessibility_control_autoclick_default"
android:title="@string/accessibility_autoclick_default_title" android:title="@string/accessibility_autoclick_default_title"
settings:allowDividerAbove="true" /> settings:allowDividerAbove="true" />
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="accessibility_control_autoclick_200ms" android:key="accessibility_control_autoclick_200ms"
android:title="@string/accessibility_autoclick_short_title" android:title="@string/accessibility_autoclick_short_title"
android:summary="@string/accessibility_autoclick_short_summary" /> android:summary="@string/accessibility_autoclick_short_summary" />
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="accessibility_control_autoclick_600ms" android:key="accessibility_control_autoclick_600ms"
android:title="@string/accessibility_autoclick_medium_title" android:title="@string/accessibility_autoclick_medium_title"
android:summary="@string/accessibility_autoclick_medium_summary" /> android:summary="@string/accessibility_autoclick_medium_summary" />
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="accessibility_control_autoclick_1sec" android:key="accessibility_control_autoclick_1sec"
android:title="@string/accessibility_autoclick_long_title" android:title="@string/accessibility_autoclick_long_title"
android:summary="@string/accessibility_autoclick_long_summary" /> android:summary="@string/accessibility_autoclick_long_summary" />
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="accessibility_control_autoclick_custom" android:key="accessibility_control_autoclick_custom"
android:title="@string/accessibility_autoclick_custom_title" /> android:title="@string/accessibility_autoclick_custom_title" />

View File

@@ -25,28 +25,28 @@
android:key="accessibility_control_timeout_banner" android:key="accessibility_control_timeout_banner"
settings:lottie_rawRes="@raw/accessibility_timeout_banner"/> settings:lottie_rawRes="@raw/accessibility_timeout_banner"/>
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="accessibility_control_timeout_default" android:key="accessibility_control_timeout_default"
android:title="@string/accessibility_timeout_default" android:title="@string/accessibility_timeout_default"
settings:allowDividerAbove="true" settings:allowDividerAbove="true"
android:persistent="false" /> android:persistent="false" />
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="accessibility_control_timeout_10secs" android:key="accessibility_control_timeout_10secs"
android:title="@string/accessibility_timeout_10secs" android:title="@string/accessibility_timeout_10secs"
android:persistent="false" /> android:persistent="false" />
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="accessibility_control_timeout_30secs" android:key="accessibility_control_timeout_30secs"
android:title="@string/accessibility_timeout_30secs" android:title="@string/accessibility_timeout_30secs"
android:persistent="false" /> android:persistent="false" />
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="accessibility_control_timeout_1min" android:key="accessibility_control_timeout_1min"
android:title="@string/accessibility_timeout_1min" android:title="@string/accessibility_timeout_1min"
android:persistent="false" /> android:persistent="false" />
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="accessibility_control_timeout_2mins" android:key="accessibility_control_timeout_2mins"
android:title="@string/accessibility_timeout_2mins" android:title="@string/accessibility_timeout_2mins"
android:persistent="false" /> android:persistent="false" />

View File

@@ -32,24 +32,24 @@
android:title="@string/daltonizer_type" android:title="@string/daltonizer_type"
android:key="daltonizer_mode_category" > android:key="daltonizer_mode_category" >
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="daltonizer_mode_deuteranomaly" android:key="daltonizer_mode_deuteranomaly"
android:persistent="false" android:persistent="false"
android:summary="@string/daltonizer_mode_deuteranomaly_summary" android:summary="@string/daltonizer_mode_deuteranomaly_summary"
android:title="@string/daltonizer_mode_deuteranomaly_title" /> android:title="@string/daltonizer_mode_deuteranomaly_title" />
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="daltonizer_mode_protanomaly" android:key="daltonizer_mode_protanomaly"
android:persistent="false" android:persistent="false"
android:summary="@string/daltonizer_mode_protanomaly_summary" android:summary="@string/daltonizer_mode_protanomaly_summary"
android:title="@string/daltonizer_mode_protanomaly_title" /> android:title="@string/daltonizer_mode_protanomaly_title" />
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="daltonizer_mode_tritanomaly" android:key="daltonizer_mode_tritanomaly"
android:persistent="false" android:persistent="false"
android:summary="@string/daltonizer_mode_tritanomaly_summary" android:summary="@string/daltonizer_mode_tritanomaly_summary"
android:title="@string/daltonizer_mode_tritanomaly_title" /> android:title="@string/daltonizer_mode_tritanomaly_title" />
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="daltonizer_mode_grayscale" android:key="daltonizer_mode_grayscale"
android:persistent="false" android:persistent="false"
android:title="@string/daltonizer_mode_grayscale_title" /> android:title="@string/daltonizer_mode_grayscale_title" />

View File

@@ -17,16 +17,16 @@
<PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android"
android:title="@string/notification_importance_title"> android:title="@string/notification_importance_title">
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="importance_high" android:key="importance_high"
android:title="@string/notification_importance_high" /> android:title="@string/notification_importance_high" />
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="importance_default" android:key="importance_default"
android:title="@string/notification_importance_default" /> android:title="@string/notification_importance_default" />
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="importance_low" android:key="importance_low"
android:title="@string/notification_importance_low" /> android:title="@string/notification_importance_low" />
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="importance_min" android:key="importance_min"
android:title="@string/notification_importance_min" /> android:title="@string/notification_importance_min" />

View File

@@ -42,13 +42,13 @@
android:title="@string/one_handed_mode_swipe_down_category" android:title="@string/one_handed_mode_swipe_down_category"
settings:controller="com.android.settings.gestures.OneHandedPreferenceCategoryController"> settings:controller="com.android.settings.gestures.OneHandedPreferenceCategoryController">
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="gesture_one_handed_action_pull_screen_down" android:key="gesture_one_handed_action_pull_screen_down"
android:title="@string/one_handed_action_pull_down_screen_title" android:title="@string/one_handed_action_pull_down_screen_title"
android:summary="@string/one_handed_action_pull_down_screen_summary" android:summary="@string/one_handed_action_pull_down_screen_summary"
settings:controller="com.android.settings.gestures.OneHandedActionPullDownPrefController"/> settings:controller="com.android.settings.gestures.OneHandedActionPullDownPrefController"/>
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="gesture_one_handed_action_show_notification" android:key="gesture_one_handed_action_show_notification"
android:title="@string/one_handed_action_show_notification_title" android:title="@string/one_handed_action_show_notification_title"
android:summary="@string/one_handed_action_show_notification_summary" android:summary="@string/one_handed_action_show_notification_summary"

View File

@@ -30,19 +30,19 @@
<PreferenceCategory <PreferenceCategory
android:title="@string/battery_detail_manage_title"> android:title="@string/battery_detail_manage_title">
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="unrestricted_pref" android:key="unrestricted_pref"
android:summary="@string/manager_battery_usage_unrestricted_summary" android:summary="@string/manager_battery_usage_unrestricted_summary"
android:title="@string/manager_battery_usage_unrestricted_title" android:title="@string/manager_battery_usage_unrestricted_title"
settings:controller="com.android.settings.fuelgauge.UnrestrictedPreferenceController"/> settings:controller="com.android.settings.fuelgauge.UnrestrictedPreferenceController"/>
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="optimized_pref" android:key="optimized_pref"
android:summary="@string/manager_battery_usage_optimized_summary" android:summary="@string/manager_battery_usage_optimized_summary"
android:title="@string/manager_battery_usage_optimized_title" android:title="@string/manager_battery_usage_optimized_title"
settings:controller="com.android.settings.fuelgauge.OptimizedPreferenceController"/> settings:controller="com.android.settings.fuelgauge.OptimizedPreferenceController"/>
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="restricted_pref" android:key="restricted_pref"
android:summary="@string/manager_battery_usage_restricted_summary" android:summary="@string/manager_battery_usage_restricted_summary"
android:title="@string/manager_battery_usage_restricted_title" android:title="@string/manager_battery_usage_restricted_title"

View File

@@ -22,11 +22,11 @@
<PreferenceCategory <PreferenceCategory
android:key="zen_custom_rule_category"> android:key="zen_custom_rule_category">
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="zen_custom_rule_setting_default" android:key="zen_custom_rule_setting_default"
android:title="@string/zen_mode_custom_behavior_summary_default"/> android:title="@string/zen_mode_custom_behavior_summary_default"/>
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="zen_custom_rule_setting" android:key="zen_custom_rule_setting"
android:title="@string/zen_mode_custom_behavior_summary" /> android:title="@string/zen_mode_custom_behavior_summary" />
</PreferenceCategory> </PreferenceCategory>

View File

@@ -23,19 +23,19 @@
<PreferenceCategory <PreferenceCategory
android:key="restrict_category" android:key="restrict_category"
android:title="@string/zen_mode_restrict_notifications_category"> android:title="@string/zen_mode_restrict_notifications_category">
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="zen_mute_notifications" android:key="zen_mute_notifications"
android:title="@string/zen_mode_restrict_notifications_mute" android:title="@string/zen_mode_restrict_notifications_mute"
android:summary="@string/zen_mode_restrict_notifications_mute_summary" android:summary="@string/zen_mode_restrict_notifications_mute_summary"
settings:searchable="false"/> settings:searchable="false"/>
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="zen_hide_notifications" android:key="zen_hide_notifications"
android:title="@string/zen_mode_restrict_notifications_hide" android:title="@string/zen_mode_restrict_notifications_hide"
android:summary="@string/zen_mode_restrict_notifications_hide_summary" android:summary="@string/zen_mode_restrict_notifications_hide_summary"
settings:searchable="false"/> settings:searchable="false"/>
<com.android.settingslib.widget.RadioButtonPreference <com.android.settingslib.widget.SelectorWithWidgetPreference
android:key="zen_custom" android:key="zen_custom"
android:title="@string/zen_mode_restrict_notifications_custom" android:title="@string/zen_mode_restrict_notifications_custom"
settings:searchable="false"/> settings:searchable="false"/>

View File

@@ -29,7 +29,7 @@ import com.android.settings.R;
import com.android.settings.core.PreferenceControllerMixin; import com.android.settings.core.PreferenceControllerMixin;
import com.android.settingslib.core.AbstractPreferenceController; import com.android.settingslib.core.AbstractPreferenceController;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import com.google.common.primitives.Ints; import com.google.common.primitives.Ints;
@@ -40,7 +40,7 @@ import java.util.Map;
* Controller class that control accessibility time out settings. * Controller class that control accessibility time out settings.
*/ */
public class AccessibilityTimeoutController extends AbstractPreferenceController implements public class AccessibilityTimeoutController extends AbstractPreferenceController implements
LifecycleObserver, RadioButtonPreference.OnClickListener, PreferenceControllerMixin { LifecycleObserver, SelectorWithWidgetPreference.OnClickListener, PreferenceControllerMixin {
static final String CONTENT_TIMEOUT_SETTINGS_SECURE = static final String CONTENT_TIMEOUT_SETTINGS_SECURE =
Settings.Secure.ACCESSIBILITY_NON_INTERACTIVE_UI_TIMEOUT_MS; Settings.Secure.ACCESSIBILITY_NON_INTERACTIVE_UI_TIMEOUT_MS;
static final String CONTROL_TIMEOUT_SETTINGS_SECURE = static final String CONTROL_TIMEOUT_SETTINGS_SECURE =
@@ -54,7 +54,7 @@ public class AccessibilityTimeoutController extends AbstractPreferenceController
private final ContentResolver mContentResolver; private final ContentResolver mContentResolver;
private final Resources mResources; private final Resources mResources;
private OnChangeListener mOnChangeListener; private OnChangeListener mOnChangeListener;
private RadioButtonPreference mPreference; private SelectorWithWidgetPreference mPreference;
private int mAccessibilityUiTimeoutValue; private int mAccessibilityUiTimeoutValue;
public AccessibilityTimeoutController(Context context, Lifecycle lifecycle, public AccessibilityTimeoutController(Context context, Lifecycle lifecycle,
@@ -124,13 +124,13 @@ public class AccessibilityTimeoutController extends AbstractPreferenceController
public void displayPreference(PreferenceScreen screen) { public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen); super.displayPreference(screen);
mPreference = (RadioButtonPreference) mPreference = (SelectorWithWidgetPreference)
screen.findPreference(getPreferenceKey()); screen.findPreference(getPreferenceKey());
mPreference.setOnClickListener(this); mPreference.setOnClickListener(this);
} }
@Override @Override
public void onRadioButtonClicked(RadioButtonPreference preference) { public void onRadioButtonClicked(SelectorWithWidgetPreference preference) {
int value = getTimeoutValueToKeyMap().get(mPreferenceKey); int value = getTimeoutValueToKeyMap().get(mPreferenceKey);
handlePreferenceChange(String.valueOf(value)); handlePreferenceChange(String.valueOf(value));
if (mOnChangeListener != null) { if (mOnChangeListener != null) {

View File

@@ -30,7 +30,7 @@ import androidx.preference.PreferenceScreen;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.core.BasePreferenceController; import com.android.settings.core.BasePreferenceController;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import com.google.common.primitives.Ints; import com.google.common.primitives.Ints;
@@ -39,7 +39,7 @@ import java.util.Map;
/** Controller class that control radio button of accessibility daltonizer settings. */ /** Controller class that control radio button of accessibility daltonizer settings. */
public class DaltonizerRadioButtonPreferenceController extends BasePreferenceController implements public class DaltonizerRadioButtonPreferenceController extends BasePreferenceController implements
LifecycleObserver, RadioButtonPreference.OnClickListener { LifecycleObserver, SelectorWithWidgetPreference.OnClickListener {
private static final String TYPE = Settings.Secure.ACCESSIBILITY_DISPLAY_DALTONIZER; private static final String TYPE = Settings.Secure.ACCESSIBILITY_DISPLAY_DALTONIZER;
// pair the preference key and daltonizer value. // pair the preference key and daltonizer value.
@@ -49,7 +49,7 @@ public class DaltonizerRadioButtonPreferenceController extends BasePreferenceCon
private final ContentResolver mContentResolver; private final ContentResolver mContentResolver;
private final Resources mResources; private final Resources mResources;
private DaltonizerRadioButtonPreferenceController.OnChangeListener mOnChangeListener; private DaltonizerRadioButtonPreferenceController.OnChangeListener mOnChangeListener;
private RadioButtonPreference mPreference; private SelectorWithWidgetPreference mPreference;
private int mAccessibilityDaltonizerValue; private int mAccessibilityDaltonizerValue;
public DaltonizerRadioButtonPreferenceController(Context context, String preferenceKey) { public DaltonizerRadioButtonPreferenceController(Context context, String preferenceKey) {
@@ -120,7 +120,7 @@ public class DaltonizerRadioButtonPreferenceController extends BasePreferenceCon
@Override @Override
public void displayPreference(PreferenceScreen screen) { public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen); super.displayPreference(screen);
mPreference = (RadioButtonPreference) mPreference = (SelectorWithWidgetPreference)
screen.findPreference(getPreferenceKey()); screen.findPreference(getPreferenceKey());
mPreference.setOnClickListener(this); mPreference.setOnClickListener(this);
mPreference.setAppendixVisibility(View.GONE); mPreference.setAppendixVisibility(View.GONE);
@@ -128,7 +128,7 @@ public class DaltonizerRadioButtonPreferenceController extends BasePreferenceCon
} }
@Override @Override
public void onRadioButtonClicked(RadioButtonPreference preference) { public void onRadioButtonClicked(SelectorWithWidgetPreference preference) {
final int value = getDaltonizerValueToKeyMap().get(mPreferenceKey); final int value = getDaltonizerValueToKeyMap().get(mPreferenceKey);
handlePreferenceChange(String.valueOf(value)); handlePreferenceChange(String.valueOf(value));
if (mOnChangeListener != null) { if (mOnChangeListener != null) {

View File

@@ -35,7 +35,7 @@ import com.android.settings.core.BasePreferenceController;
import com.android.settings.core.PreferenceControllerMixin; import com.android.settings.core.PreferenceControllerMixin;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.LayoutPreference; import com.android.settingslib.widget.LayoutPreference;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import java.util.Map; import java.util.Map;
@@ -43,7 +43,7 @@ import java.util.Map;
* Controller class that controls accessibility autoclick settings. * Controller class that controls accessibility autoclick settings.
*/ */
public class ToggleAutoclickPreferenceController extends BasePreferenceController implements public class ToggleAutoclickPreferenceController extends BasePreferenceController implements
LifecycleObserver, RadioButtonPreference.OnClickListener, PreferenceControllerMixin { LifecycleObserver, SelectorWithWidgetPreference.OnClickListener, PreferenceControllerMixin {
@VisibleForTesting @VisibleForTesting
static final String CONTROL_AUTOCLICK_DELAY_SECURE = static final String CONTROL_AUTOCLICK_DELAY_SECURE =
@@ -67,7 +67,7 @@ public class ToggleAutoclickPreferenceController extends BasePreferenceControlle
private final ContentResolver mContentResolver; private final ContentResolver mContentResolver;
private final Resources mResources; private final Resources mResources;
private OnChangeListener mOnChangeListener; private OnChangeListener mOnChangeListener;
private RadioButtonPreference mDelayModePref; private SelectorWithWidgetPreference mDelayModePref;
/** /**
* Seek bar preference for autoclick delay value. The seek bar has values between 0 and * Seek bar preference for autoclick delay value. The seek bar has values between 0 and
@@ -109,7 +109,7 @@ public class ToggleAutoclickPreferenceController extends BasePreferenceControlle
public void displayPreference(PreferenceScreen screen) { public void displayPreference(PreferenceScreen screen) {
super.displayPreference(screen); super.displayPreference(screen);
mDelayModePref = (RadioButtonPreference) mDelayModePref = (SelectorWithWidgetPreference)
screen.findPreference(getPreferenceKey()); screen.findPreference(getPreferenceKey());
mDelayModePref.setOnClickListener(this); mDelayModePref.setOnClickListener(this);
mSeekBerPreference = (LayoutPreference) screen.findPreference(KEY_AUTOCLICK_CUSTOM_SEEKBAR); mSeekBerPreference = (LayoutPreference) screen.findPreference(KEY_AUTOCLICK_CUSTOM_SEEKBAR);
@@ -117,7 +117,7 @@ public class ToggleAutoclickPreferenceController extends BasePreferenceControlle
} }
@Override @Override
public void onRadioButtonClicked(RadioButtonPreference preference) { public void onRadioButtonClicked(SelectorWithWidgetPreference preference) {
final int value = mAccessibilityAutoclickKeyToValueMap.get(mPreferenceKey); final int value = mAccessibilityAutoclickKeyToValueMap.get(mPreferenceKey);
handleRadioButtonPreferenceChange(value); handleRadioButtonPreferenceChange(value);
if (mOnChangeListener != null) { if (mOnChangeListener != null) {

View File

@@ -34,13 +34,13 @@ import androidx.preference.PreferenceCategory;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.Utils; import com.android.settings.Utils;
import com.android.settingslib.widget.FooterPreference; import com.android.settingslib.widget.FooterPreference;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
/** /**
* Display the Open Supported Links page. Allow users choose what kind supported links they need. * Display the Open Supported Links page. Allow users choose what kind supported links they need.
*/ */
public class OpenSupportedLinks extends AppInfoWithHeader implements public class OpenSupportedLinks extends AppInfoWithHeader implements
RadioButtonPreference.OnClickListener { SelectorWithWidgetPreference.OnClickListener {
private static final String TAG = "OpenSupportedLinks"; private static final String TAG = "OpenSupportedLinks";
private static final String RADIO_GROUP_KEY = "supported_links_radio_group"; private static final String RADIO_GROUP_KEY = "supported_links_radio_group";
private static final String FOOTER_KEY = "supported_links_footer"; private static final String FOOTER_KEY = "supported_links_footer";
@@ -60,11 +60,11 @@ public class OpenSupportedLinks extends AppInfoWithHeader implements
@VisibleForTesting @VisibleForTesting
PreferenceCategory mPreferenceCategory; PreferenceCategory mPreferenceCategory;
@VisibleForTesting @VisibleForTesting
RadioButtonPreference mAllowOpening; SelectorWithWidgetPreference mAllowOpening;
@VisibleForTesting @VisibleForTesting
RadioButtonPreference mAskEveryTime; SelectorWithWidgetPreference mAskEveryTime;
@VisibleForTesting @VisibleForTesting
RadioButtonPreference mNotAllowed; SelectorWithWidgetPreference mNotAllowed;
@Override @Override
public void onCreate(Bundle savedInstanceState) { public void onCreate(Bundle savedInstanceState) {
@@ -101,7 +101,7 @@ public class OpenSupportedLinks extends AppInfoWithHeader implements
} }
@Override @Override
public void onRadioButtonClicked(RadioButtonPreference preference) { public void onRadioButtonClicked(SelectorWithWidgetPreference preference) {
final int clickedIndex = preferenceKeyToIndex(preference.getKey()); final int clickedIndex = preferenceKeyToIndex(preference.getKey());
if (mCurrentIndex != clickedIndex) { if (mCurrentIndex != clickedIndex) {
mCurrentIndex = clickedIndex; mCurrentIndex = clickedIndex;
@@ -110,8 +110,8 @@ public class OpenSupportedLinks extends AppInfoWithHeader implements
} }
} }
private RadioButtonPreference makeRadioPreference(String key, int stringId) { private SelectorWithWidgetPreference makeRadioPreference(String key, int stringId) {
final RadioButtonPreference pref = new RadioButtonPreference( final SelectorWithWidgetPreference pref = new SelectorWithWidgetPreference(
mPreferenceCategory.getContext()); mPreferenceCategory.getContext());
pref.setKey(key); pref.setKey(key);
pref.setTitle(stringId); pref.setTitle(stringId);

View File

@@ -35,7 +35,7 @@ import com.android.settings.fuelgauge.BatteryUtils;
import com.android.settings.widget.RadioButtonPickerFragment; import com.android.settings.widget.RadioButtonPickerFragment;
import com.android.settingslib.applications.DefaultAppInfo; import com.android.settingslib.applications.DefaultAppInfo;
import com.android.settingslib.widget.CandidateInfo; import com.android.settingslib.widget.CandidateInfo;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
/** /**
* A generic app picker fragment that shows a list of app as radio button group. * A generic app picker fragment that shows a list of app as radio button group.
@@ -53,7 +53,7 @@ public abstract class DefaultAppPickerFragment extends RadioButtonPickerFragment
} }
@Override @Override
public void onRadioButtonClicked(RadioButtonPreference selected) { public void onRadioButtonClicked(SelectorWithWidgetPreference selected) {
final String selectedKey = selected.getKey(); final String selectedKey = selected.getKey();
final CharSequence confirmationMessage = getConfirmationMessage(getCandidate(selectedKey)); final CharSequence confirmationMessage = getConfirmationMessage(getCandidate(selectedKey));
final FragmentActivity activity = getActivity(); final FragmentActivity activity = getActivity();
@@ -78,7 +78,7 @@ public abstract class DefaultAppPickerFragment extends RadioButtonPickerFragment
} }
@Override @Override
public void bindPreferenceExtra(RadioButtonPreference pref, public void bindPreferenceExtra(SelectorWithWidgetPreference pref,
String key, CandidateInfo info, String defaultKey, String systemDefaultKey) { String key, CandidateInfo info, String defaultKey, String systemDefaultKey) {
if (!(info instanceof DefaultAppInfo)) { if (!(info instanceof DefaultAppInfo)) {
return; return;

View File

@@ -26,7 +26,6 @@ import android.content.pm.ApplicationInfo;
import android.content.pm.PackageItemInfo; import android.content.pm.PackageItemInfo;
import android.content.pm.PackageManager; import android.content.pm.PackageManager;
import android.content.pm.UserInfo; import android.content.pm.UserInfo;
import android.os.UserHandle;
import android.util.Log; import android.util.Log;
import android.util.Pair; import android.util.Pair;
import android.view.View; import android.view.View;
@@ -35,13 +34,12 @@ import androidx.annotation.VisibleForTesting;
import androidx.preference.PreferenceScreen; import androidx.preference.PreferenceScreen;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.Utils;
import com.android.settings.applications.defaultapps.DefaultAppPickerFragment; import com.android.settings.applications.defaultapps.DefaultAppPickerFragment;
import com.android.settingslib.applications.DefaultAppInfo; import com.android.settingslib.applications.DefaultAppInfo;
import com.android.settingslib.development.DevelopmentSettingsEnabler; import com.android.settingslib.development.DevelopmentSettingsEnabler;
import com.android.settingslib.widget.CandidateInfo; import com.android.settingslib.widget.CandidateInfo;
import com.android.settingslib.widget.FooterPreference; import com.android.settingslib.widget.FooterPreference;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
@@ -169,7 +167,7 @@ public class BugReportHandlerPicker extends DefaultAppPickerFragment {
@Override @Override
public void bindPreferenceExtra(RadioButtonPreference pref, public void bindPreferenceExtra(SelectorWithWidgetPreference pref,
String key, CandidateInfo info, String defaultKey, String systemDefaultKey) { String key, CandidateInfo info, String defaultKey, String systemDefaultKey) {
super.bindPreferenceExtra(pref, key, info, defaultKey, systemDefaultKey); super.bindPreferenceExtra(pref, key, info, defaultKey, systemDefaultKey);
pref.setAppendixVisibility(View.GONE); pref.setAppendixVisibility(View.GONE);

View File

@@ -36,7 +36,7 @@ import com.android.settings.Utils;
import com.android.settings.widget.RadioButtonPickerFragment; import com.android.settings.widget.RadioButtonPickerFragment;
import com.android.settingslib.widget.CandidateInfo; import com.android.settingslib.widget.CandidateInfo;
import com.android.settingslib.widget.FooterPreference; import com.android.settingslib.widget.FooterPreference;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import com.google.android.collect.Lists; import com.google.android.collect.Lists;
@@ -214,7 +214,7 @@ public class UsbDefaultFragment extends RadioButtonPickerFragment {
private void refresh(long functions) { private void refresh(long functions) {
final PreferenceScreen screen = getPreferenceScreen(); final PreferenceScreen screen = getPreferenceScreen();
for (long option : UsbDetailsFunctionsController.FUNCTIONS_MAP.keySet()) { for (long option : UsbDetailsFunctionsController.FUNCTIONS_MAP.keySet()) {
final RadioButtonPreference pref = final SelectorWithWidgetPreference pref =
screen.findPreference(UsbBackend.usbFunctionsToString(option)); screen.findPreference(UsbBackend.usbFunctionsToString(option));
if (pref != null) { if (pref != null) {
final boolean isSupported = mUsbBackend.areFunctionsSupported(option); final boolean isSupported = mUsbBackend.areFunctionsSupported(option);

View File

@@ -27,20 +27,20 @@ import androidx.preference.PreferenceScreen;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.Utils; import com.android.settings.Utils;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
/** /**
* This class controls the radio buttons for switching between * This class controls the radio buttons for switching between
* USB device and host mode. * USB device and host mode.
*/ */
public class UsbDetailsDataRoleController extends UsbDetailsController public class UsbDetailsDataRoleController extends UsbDetailsController
implements RadioButtonPreference.OnClickListener { implements SelectorWithWidgetPreference.OnClickListener {
private PreferenceCategory mPreferenceCategory; private PreferenceCategory mPreferenceCategory;
private RadioButtonPreference mDevicePref; private SelectorWithWidgetPreference mDevicePref;
private RadioButtonPreference mHostPref; private SelectorWithWidgetPreference mHostPref;
private RadioButtonPreference mNextRolePref; private SelectorWithWidgetPreference mNextRolePref;
private final Runnable mFailureCallback = () -> { private final Runnable mFailureCallback = () -> {
if (mNextRolePref != null) { if (mNextRolePref != null) {
@@ -97,7 +97,7 @@ public class UsbDetailsDataRoleController extends UsbDetailsController
} }
@Override @Override
public void onRadioButtonClicked(RadioButtonPreference preference) { public void onRadioButtonClicked(SelectorWithWidgetPreference preference) {
int role = UsbBackend.dataRoleFromString(preference.getKey()); int role = UsbBackend.dataRoleFromString(preference.getKey());
if (role != mUsbBackend.getDataRole() && mNextRolePref == null if (role != mUsbBackend.getDataRole() && mNextRolePref == null
&& !Utils.isMonkeyRunning()) { && !Utils.isMonkeyRunning()) {
@@ -121,8 +121,9 @@ public class UsbDetailsDataRoleController extends UsbDetailsController
return "usb_details_data_role"; return "usb_details_data_role";
} }
private RadioButtonPreference makeRadioPreference(String key, int titleId) { private SelectorWithWidgetPreference makeRadioPreference(String key, int titleId) {
RadioButtonPreference pref = new RadioButtonPreference(mPreferenceCategory.getContext()); SelectorWithWidgetPreference pref = new SelectorWithWidgetPreference(
mPreferenceCategory.getContext());
pref.setKey(key); pref.setKey(key);
pref.setTitle(titleId); pref.setTitle(titleId);
pref.setOnClickListener(this); pref.setOnClickListener(this);

View File

@@ -31,7 +31,7 @@ import androidx.preference.PreferenceScreen;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.Utils; import com.android.settings.Utils;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import java.util.LinkedHashMap; import java.util.LinkedHashMap;
import java.util.Map; import java.util.Map;
@@ -40,7 +40,7 @@ import java.util.Map;
* This class controls the radio buttons for choosing between different USB functions. * This class controls the radio buttons for choosing between different USB functions.
*/ */
public class UsbDetailsFunctionsController extends UsbDetailsController public class UsbDetailsFunctionsController extends UsbDetailsController
implements RadioButtonPreference.OnClickListener { implements SelectorWithWidgetPreference.OnClickListener {
private static final String TAG = "UsbFunctionsCtrl"; private static final String TAG = "UsbFunctionsCtrl";
private static final boolean DEBUG = Log.isLoggable(TAG, Log.DEBUG); private static final boolean DEBUG = Log.isLoggable(TAG, Log.DEBUG);
@@ -83,10 +83,10 @@ public class UsbDetailsFunctionsController extends UsbDetailsController
/** /**
* Gets a switch preference for the particular option, creating it if needed. * Gets a switch preference for the particular option, creating it if needed.
*/ */
private RadioButtonPreference getProfilePreference(String key, int titleId) { private SelectorWithWidgetPreference getProfilePreference(String key, int titleId) {
RadioButtonPreference pref = mProfilesContainer.findPreference(key); SelectorWithWidgetPreference pref = mProfilesContainer.findPreference(key);
if (pref == null) { if (pref == null) {
pref = new RadioButtonPreference(mProfilesContainer.getContext()); pref = new SelectorWithWidgetPreference(mProfilesContainer.getContext());
pref.setKey(key); pref.setKey(key);
pref.setTitle(titleId); pref.setTitle(titleId);
pref.setSingleLineTitle(false); pref.setSingleLineTitle(false);
@@ -108,7 +108,7 @@ public class UsbDetailsFunctionsController extends UsbDetailsController
// Functions are only available in device mode // Functions are only available in device mode
mProfilesContainer.setEnabled(true); mProfilesContainer.setEnabled(true);
} }
RadioButtonPreference pref; SelectorWithWidgetPreference pref;
for (long option : FUNCTIONS_MAP.keySet()) { for (long option : FUNCTIONS_MAP.keySet()) {
int title = FUNCTIONS_MAP.get(option); int title = FUNCTIONS_MAP.get(option);
pref = getProfilePreference(UsbBackend.usbFunctionsToString(option), title); pref = getProfilePreference(UsbBackend.usbFunctionsToString(option), title);
@@ -128,7 +128,7 @@ public class UsbDetailsFunctionsController extends UsbDetailsController
} }
@Override @Override
public void onRadioButtonClicked(RadioButtonPreference preference) { public void onRadioButtonClicked(SelectorWithWidgetPreference preference) {
final long function = UsbBackend.usbFunctionsFromString(preference.getKey()); final long function = UsbBackend.usbFunctionsFromString(preference.getKey());
final long previousFunction = mUsbBackend.getCurrentFunctions(); final long previousFunction = mUsbBackend.getCurrentFunctions();
if (DEBUG) { if (DEBUG) {
@@ -142,8 +142,8 @@ public class UsbDetailsFunctionsController extends UsbDetailsController
mPreviousFunction = previousFunction; mPreviousFunction = previousFunction;
//Update the UI in advance to make it looks smooth //Update the UI in advance to make it looks smooth
final RadioButtonPreference prevPref = final SelectorWithWidgetPreference prevPref =
(RadioButtonPreference) mProfilesContainer.findPreference( (SelectorWithWidgetPreference) mProfilesContainer.findPreference(
UsbBackend.usbFunctionsToString(mPreviousFunction)); UsbBackend.usbFunctionsToString(mPreviousFunction));
if (prevPref != null) { if (prevPref != null) {
prevPref.setChecked(false); prevPref.setChecked(false);

View File

@@ -53,7 +53,7 @@ import com.android.settingslib.search.SearchIndexable;
import com.android.settingslib.search.SearchIndexableRaw; import com.android.settingslib.search.SearchIndexableRaw;
import com.android.settingslib.widget.CandidateInfo; import com.android.settingslib.widget.CandidateInfo;
import com.android.settingslib.widget.FooterPreference; import com.android.settingslib.widget.FooterPreference;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import com.google.common.annotations.VisibleForTesting; import com.google.common.annotations.VisibleForTesting;
@@ -181,8 +181,8 @@ public class ScreenTimeoutSettings extends RadioButtonPickerFragment implements
} }
for (CandidateInfo info : candidateList) { for (CandidateInfo info : candidateList) {
RadioButtonPreference pref = SelectorWithWidgetPreference pref =
new RadioButtonPreference(getPrefContext()); new SelectorWithWidgetPreference(getPrefContext());
bindPreference(pref, info.getKey(), info, defaultKey); bindPreference(pref, info.getKey(), info, defaultKey);
screen.addPreference(pref); screen.addPreference(pref);
} }
@@ -192,8 +192,8 @@ public class ScreenTimeoutSettings extends RadioButtonPickerFragment implements
if (!candidateList.isEmpty() && (selectedTimeout > maxTimeout)) { if (!candidateList.isEmpty() && (selectedTimeout > maxTimeout)) {
// The selected time out value is longer than the max timeout allowed by the admin. // The selected time out value is longer than the max timeout allowed by the admin.
// Select the largest value from the list by default. // Select the largest value from the list by default.
final RadioButtonPreference preferenceWithLargestTimeout = final SelectorWithWidgetPreference preferenceWithLargestTimeout =
(RadioButtonPreference) screen.getPreference(candidateList.size() - 1); (SelectorWithWidgetPreference) screen.getPreference(candidateList.size() - 1);
preferenceWithLargestTimeout.setChecked(true); preferenceWithLargestTimeout.setChecked(true);
} }

View File

@@ -53,7 +53,7 @@ import com.android.settingslib.core.AbstractPreferenceController;
import com.android.settingslib.utils.StringUtil; import com.android.settingslib.utils.StringUtil;
import com.android.settingslib.widget.FooterPreference; import com.android.settingslib.widget.FooterPreference;
import com.android.settingslib.widget.LayoutPreference; import com.android.settingslib.widget.LayoutPreference;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
@@ -66,7 +66,8 @@ import java.util.List;
*/ */
public class AdvancedPowerUsageDetail extends DashboardFragment implements public class AdvancedPowerUsageDetail extends DashboardFragment implements
ButtonActionDialogFragment.AppButtonsDialogListener, ButtonActionDialogFragment.AppButtonsDialogListener,
BatteryTipPreferenceController.BatteryTipListener, RadioButtonPreference.OnClickListener { BatteryTipPreferenceController.BatteryTipListener,
SelectorWithWidgetPreference.OnClickListener {
public static final String TAG = "AdvancedPowerDetail"; public static final String TAG = "AdvancedPowerDetail";
public static final String EXTRA_UID = "extra_uid"; public static final String EXTRA_UID = "extra_uid";
@@ -107,11 +108,11 @@ public class AdvancedPowerUsageDetail extends DashboardFragment implements
@VisibleForTesting @VisibleForTesting
FooterPreference mFooterPreference; FooterPreference mFooterPreference;
@VisibleForTesting @VisibleForTesting
RadioButtonPreference mRestrictedPreference; SelectorWithWidgetPreference mRestrictedPreference;
@VisibleForTesting @VisibleForTesting
RadioButtonPreference mOptimizePreference; SelectorWithWidgetPreference mOptimizePreference;
@VisibleForTesting @VisibleForTesting
RadioButtonPreference mUnrestrictedPreference; SelectorWithWidgetPreference mUnrestrictedPreference;
@VisibleForTesting @VisibleForTesting
boolean enableTriState = true; boolean enableTriState = true;
@@ -385,8 +386,8 @@ public class AdvancedPowerUsageDetail extends DashboardFragment implements
final String packageName = bundle.getString(EXTRA_PACKAGE_NAME); final String packageName = bundle.getString(EXTRA_PACKAGE_NAME);
mAppButtonsPreferenceController = new AppButtonsPreferenceController( mAppButtonsPreferenceController = new AppButtonsPreferenceController(
(SettingsActivity) getActivity(), this, getSettingsLifecycle(), packageName, (SettingsActivity) getActivity(), this, getSettingsLifecycle(),
mState, REQUEST_UNINSTALL, REQUEST_REMOVE_DEVICE_ADMIN); packageName, mState, REQUEST_UNINSTALL, REQUEST_REMOVE_DEVICE_ADMIN);
controllers.add(mAppButtonsPreferenceController); controllers.add(mAppButtonsPreferenceController);
if (enableTriState) { if (enableTriState) {
controllers.add(new UnrestrictedPreferenceController(context, uid, packageName)); controllers.add(new UnrestrictedPreferenceController(context, uid, packageName));
@@ -425,7 +426,7 @@ public class AdvancedPowerUsageDetail extends DashboardFragment implements
} }
@Override @Override
public void onRadioButtonClicked(RadioButtonPreference selected) { public void onRadioButtonClicked(SelectorWithWidgetPreference selected) {
final String selectedKey = selected.getKey(); final String selectedKey = selected.getKey();
updatePreferenceState(mUnrestrictedPreference, selectedKey); updatePreferenceState(mUnrestrictedPreference, selectedKey);
updatePreferenceState(mOptimizePreference, selectedKey); updatePreferenceState(mOptimizePreference, selectedKey);
@@ -452,7 +453,8 @@ public class AdvancedPowerUsageDetail extends DashboardFragment implements
} }
} }
private void updatePreferenceState(RadioButtonPreference preference, String selectedKey) { private void updatePreferenceState(SelectorWithWidgetPreference preference,
String selectedKey) {
preference.setChecked(selectedKey.equals(preference.getKey())); preference.setChecked(selectedKey.equals(preference.getKey()));
} }

View File

@@ -26,7 +26,7 @@ import androidx.preference.Preference;
import com.android.settings.core.PreferenceControllerMixin; import com.android.settings.core.PreferenceControllerMixin;
import com.android.settingslib.core.AbstractPreferenceController; import com.android.settingslib.core.AbstractPreferenceController;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
public class OptimizedPreferenceController extends AbstractPreferenceController public class OptimizedPreferenceController extends AbstractPreferenceController
implements PreferenceControllerMixin { implements PreferenceControllerMixin {
@@ -51,19 +51,19 @@ public class OptimizedPreferenceController extends AbstractPreferenceController
if (!mBatteryOptimizeUtils.isValidPackageName()) { if (!mBatteryOptimizeUtils.isValidPackageName()) {
Log.d(TAG, "invalid package name, optimized states only"); Log.d(TAG, "invalid package name, optimized states only");
preference.setEnabled(true); preference.setEnabled(true);
((RadioButtonPreference) preference).setChecked(true); ((SelectorWithWidgetPreference) preference).setChecked(true);
return; return;
} }
if (mBatteryOptimizeUtils.isSystemOrDefaultApp()) { if (mBatteryOptimizeUtils.isSystemOrDefaultApp()) {
Log.d(TAG, "is system or default app, disable pref"); Log.d(TAG, "is system or default app, disable pref");
((RadioButtonPreference) preference).setChecked(false); ((SelectorWithWidgetPreference) preference).setChecked(false);
preference.setEnabled(false); preference.setEnabled(false);
} else if (mBatteryOptimizeUtils.getAppUsageState() == OPTIMIZED) { } else if (mBatteryOptimizeUtils.getAppUsageState() == OPTIMIZED) {
Log.d(TAG, "is optimized states"); Log.d(TAG, "is optimized states");
((RadioButtonPreference) preference).setChecked(true); ((SelectorWithWidgetPreference) preference).setChecked(true);
} else { } else {
((RadioButtonPreference) preference).setChecked(false); ((SelectorWithWidgetPreference) preference).setChecked(false);
} }
} }

View File

@@ -27,7 +27,7 @@ import androidx.preference.Preference;
import com.android.settings.core.PreferenceControllerMixin; import com.android.settings.core.PreferenceControllerMixin;
import com.android.settingslib.core.AbstractPreferenceController; import com.android.settingslib.core.AbstractPreferenceController;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
public class RestrictedPreferenceController extends AbstractPreferenceController public class RestrictedPreferenceController extends AbstractPreferenceController
implements PreferenceControllerMixin { implements PreferenceControllerMixin {
@@ -55,13 +55,13 @@ public class RestrictedPreferenceController extends AbstractPreferenceController
if (mBatteryOptimizeUtils.isSystemOrDefaultApp()) { if (mBatteryOptimizeUtils.isSystemOrDefaultApp()) {
Log.d(TAG, "is system or default app, disable pref"); Log.d(TAG, "is system or default app, disable pref");
((RadioButtonPreference) preference).setChecked(false); ((SelectorWithWidgetPreference) preference).setChecked(false);
preference.setEnabled(false); preference.setEnabled(false);
} else if (mBatteryOptimizeUtils.getAppUsageState() == RESTRICTED) { } else if (mBatteryOptimizeUtils.getAppUsageState() == RESTRICTED) {
Log.d(TAG, "is restricted states"); Log.d(TAG, "is restricted states");
((RadioButtonPreference) preference).setChecked(true); ((SelectorWithWidgetPreference) preference).setChecked(true);
} else { } else {
((RadioButtonPreference) preference).setChecked(false); ((SelectorWithWidgetPreference) preference).setChecked(false);
} }
} }

View File

@@ -26,7 +26,7 @@ import androidx.preference.Preference;
import com.android.settings.core.PreferenceControllerMixin; import com.android.settings.core.PreferenceControllerMixin;
import com.android.settingslib.core.AbstractPreferenceController; import com.android.settingslib.core.AbstractPreferenceController;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
public class UnrestrictedPreferenceController extends AbstractPreferenceController public class UnrestrictedPreferenceController extends AbstractPreferenceController
implements PreferenceControllerMixin { implements PreferenceControllerMixin {
@@ -54,12 +54,12 @@ public class UnrestrictedPreferenceController extends AbstractPreferenceControll
if (mBatteryOptimizeUtils.isSystemOrDefaultApp()) { if (mBatteryOptimizeUtils.isSystemOrDefaultApp()) {
Log.d(TAG, "is system or default app, unrestricted states only"); Log.d(TAG, "is system or default app, unrestricted states only");
((RadioButtonPreference) preference).setChecked(true); ((SelectorWithWidgetPreference) preference).setChecked(true);
} else if (mBatteryOptimizeUtils.getAppUsageState() == UNRESTRICTED) { } else if (mBatteryOptimizeUtils.getAppUsageState() == UNRESTRICTED) {
Log.d(TAG, "is unrestricted states"); Log.d(TAG, "is unrestricted states");
((RadioButtonPreference) preference).setChecked(true); ((SelectorWithWidgetPreference) preference).setChecked(true);
} else { } else {
((RadioButtonPreference) preference).setChecked(false); ((SelectorWithWidgetPreference) preference).setChecked(false);
} }
} }

View File

@@ -37,7 +37,7 @@ import com.android.settings.R;
import com.android.settings.widget.RadioButtonPickerFragment; import com.android.settings.widget.RadioButtonPickerFragment;
import com.android.settingslib.fuelgauge.BatterySaverUtils; import com.android.settingslib.fuelgauge.BatterySaverUtils;
import com.android.settingslib.widget.CandidateInfo; import com.android.settingslib.widget.CandidateInfo;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import com.google.common.collect.Lists; import com.google.common.collect.Lists;
@@ -142,8 +142,8 @@ public class BatterySaverScheduleSettings extends RadioButtonPickerFragment {
} }
@Override @Override
public void bindPreferenceExtra(RadioButtonPreference pref, String key, CandidateInfo info, public void bindPreferenceExtra(SelectorWithWidgetPreference pref, String key,
String defaultKey, String systemDefaultKey) { CandidateInfo info, String defaultKey, String systemDefaultKey) {
final BatterySaverScheduleCandidateInfo candidateInfo = final BatterySaverScheduleCandidateInfo candidateInfo =
(BatterySaverScheduleCandidateInfo) info; (BatterySaverScheduleCandidateInfo) info;
final CharSequence summary = candidateInfo.getSummary(); final CharSequence summary = candidateInfo.getSummary();

View File

@@ -26,7 +26,7 @@ import com.android.settings.core.BasePreferenceController;
import com.android.settingslib.core.lifecycle.LifecycleObserver; import com.android.settingslib.core.lifecycle.LifecycleObserver;
import com.android.settingslib.core.lifecycle.events.OnStart; import com.android.settingslib.core.lifecycle.events.OnStart;
import com.android.settingslib.core.lifecycle.events.OnStop; import com.android.settingslib.core.lifecycle.events.OnStop;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
/** /**
* The controller to handle one-handed mode pull screen into reach preference. * The controller to handle one-handed mode pull screen into reach preference.
@@ -46,8 +46,8 @@ public class OneHandedActionPullDownPrefController extends BasePreferenceControl
@Override @Override
public void updateState(Preference preference) { public void updateState(Preference preference) {
super.updateState(preference); super.updateState(preference);
if (preference instanceof RadioButtonPreference) { if (preference instanceof SelectorWithWidgetPreference) {
((RadioButtonPreference) preference).setChecked( ((SelectorWithWidgetPreference) preference).setChecked(
!OneHandedSettingsUtils.isSwipeDownNotificationEnabled(mContext)); !OneHandedSettingsUtils.isSwipeDownNotificationEnabled(mContext));
} }
} }
@@ -65,8 +65,8 @@ public class OneHandedActionPullDownPrefController extends BasePreferenceControl
return false; return false;
} }
OneHandedSettingsUtils.setSwipeDownNotificationEnabled(mContext, false); OneHandedSettingsUtils.setSwipeDownNotificationEnabled(mContext, false);
if (preference instanceof RadioButtonPreference) { if (preference instanceof SelectorWithWidgetPreference) {
((RadioButtonPreference) preference).setChecked(true); ((SelectorWithWidgetPreference) preference).setChecked(true);
} }
return true; return true;
} }

View File

@@ -26,7 +26,7 @@ import com.android.settings.core.BasePreferenceController;
import com.android.settingslib.core.lifecycle.LifecycleObserver; import com.android.settingslib.core.lifecycle.LifecycleObserver;
import com.android.settingslib.core.lifecycle.events.OnStart; import com.android.settingslib.core.lifecycle.events.OnStart;
import com.android.settingslib.core.lifecycle.events.OnStop; import com.android.settingslib.core.lifecycle.events.OnStop;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
/** /**
* The controller to handle one-handed mode show notification preference. * The controller to handle one-handed mode show notification preference.
@@ -46,8 +46,8 @@ public class OneHandedActionShowNotificationPrefController extends BasePreferenc
@Override @Override
public void updateState(Preference preference) { public void updateState(Preference preference) {
super.updateState(preference); super.updateState(preference);
if (preference instanceof RadioButtonPreference) { if (preference instanceof SelectorWithWidgetPreference) {
((RadioButtonPreference) preference).setChecked( ((SelectorWithWidgetPreference) preference).setChecked(
OneHandedSettingsUtils.isSwipeDownNotificationEnabled(mContext)); OneHandedSettingsUtils.isSwipeDownNotificationEnabled(mContext));
} }
} }
@@ -65,8 +65,8 @@ public class OneHandedActionShowNotificationPrefController extends BasePreferenc
return false; return false;
} }
OneHandedSettingsUtils.setSwipeDownNotificationEnabled(mContext, true); OneHandedSettingsUtils.setSwipeDownNotificationEnabled(mContext, true);
if (preference instanceof RadioButtonPreference) { if (preference instanceof SelectorWithWidgetPreference) {
((RadioButtonPreference) preference).setChecked(true); ((SelectorWithWidgetPreference) preference).setChecked(true);
} }
return true; return true;
} }

View File

@@ -35,10 +35,10 @@ import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.core.lifecycle.LifecycleObserver; import com.android.settingslib.core.lifecycle.LifecycleObserver;
import com.android.settingslib.core.lifecycle.events.OnPause; import com.android.settingslib.core.lifecycle.events.OnPause;
import com.android.settingslib.core.lifecycle.events.OnResume; import com.android.settingslib.core.lifecycle.events.OnResume;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
public class PreventRingingGesturePreferenceController extends AbstractPreferenceController public class PreventRingingGesturePreferenceController extends AbstractPreferenceController
implements RadioButtonPreference.OnClickListener, LifecycleObserver, implements SelectorWithWidgetPreference.OnClickListener, LifecycleObserver,
OnResume, OnPause, PreferenceControllerMixin { OnResume, OnPause, PreferenceControllerMixin {
@VisibleForTesting @VisibleForTesting
@@ -54,9 +54,9 @@ public class PreventRingingGesturePreferenceController extends AbstractPreferenc
@VisibleForTesting @VisibleForTesting
PreferenceCategory mPreferenceCategory; PreferenceCategory mPreferenceCategory;
@VisibleForTesting @VisibleForTesting
RadioButtonPreference mVibratePref; SelectorWithWidgetPreference mVibratePref;
@VisibleForTesting @VisibleForTesting
RadioButtonPreference mMutePref; SelectorWithWidgetPreference mMutePref;
private SettingObserver mSettingObserver; private SettingObserver mSettingObserver;
@@ -100,7 +100,7 @@ public class PreventRingingGesturePreferenceController extends AbstractPreferenc
} }
@Override @Override
public void onRadioButtonClicked(RadioButtonPreference preference) { public void onRadioButtonClicked(SelectorWithWidgetPreference preference) {
int preventRingingSetting = keyToSetting(preference.getKey()); int preventRingingSetting = keyToSetting(preference.getKey());
if (preventRingingSetting != Settings.Secure.getInt(mContext.getContentResolver(), if (preventRingingSetting != Settings.Secure.getInt(mContext.getContentResolver(),
Settings.Secure.VOLUME_HUSH_GESTURE, Settings.Secure.VOLUME_HUSH_VIBRATE)) { Settings.Secure.VOLUME_HUSH_GESTURE, Settings.Secure.VOLUME_HUSH_VIBRATE)) {
@@ -157,8 +157,9 @@ public class PreventRingingGesturePreferenceController extends AbstractPreferenc
} }
} }
private RadioButtonPreference makeRadioPreference(String key, int titleId) { private SelectorWithWidgetPreference makeRadioPreference(String key, int titleId) {
RadioButtonPreference pref = new RadioButtonPreference(mPreferenceCategory.getContext()); SelectorWithWidgetPreference pref = new SelectorWithWidgetPreference(
mPreferenceCategory.getContext());
pref.setKey(key); pref.setKey(key);
pref.setTitle(titleId); pref.setTitle(titleId);
pref.setOnClickListener(this); pref.setOnClickListener(this);

View File

@@ -48,7 +48,7 @@ import com.android.settings.widget.RadioButtonPickerFragment;
import com.android.settingslib.search.SearchIndexable; import com.android.settingslib.search.SearchIndexable;
import com.android.settingslib.widget.CandidateInfo; import com.android.settingslib.widget.CandidateInfo;
import com.android.settingslib.widget.IllustrationPreference; import com.android.settingslib.widget.IllustrationPreference;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
@@ -109,8 +109,8 @@ public class SystemNavigationGestureSettings extends RadioButtonPickerFragment i
return; return;
} }
for (CandidateInfo info : candidateList) { for (CandidateInfo info : candidateList) {
RadioButtonPreference pref = SelectorWithWidgetPreference pref =
new RadioButtonPreference(getPrefContext()); new SelectorWithWidgetPreference(getPrefContext());
bindPreference(pref, info.getKey(), info, defaultKey); bindPreference(pref, info.getKey(), info, defaultKey);
bindPreferenceExtra(pref, info.getKey(), info, defaultKey, systemDefaultKey); bindPreferenceExtra(pref, info.getKey(), info, defaultKey, systemDefaultKey);
screen.addPreference(pref); screen.addPreference(pref);
@@ -119,7 +119,7 @@ public class SystemNavigationGestureSettings extends RadioButtonPickerFragment i
} }
@Override @Override
public void bindPreferenceExtra(RadioButtonPreference pref, public void bindPreferenceExtra(SelectorWithWidgetPreference pref,
String key, CandidateInfo info, String defaultKey, String systemDefaultKey) { String key, CandidateInfo info, String defaultKey, String systemDefaultKey) {
if (!(info instanceof CandidateInfoExtra)) { if (!(info instanceof CandidateInfoExtra)) {
return; return;

View File

@@ -35,7 +35,7 @@ import com.android.settings.core.SubSettingLauncher;
import com.android.settings.notification.NotificationBackend; import com.android.settings.notification.NotificationBackend;
import com.android.settings.notification.app.ConversationListSettings; import com.android.settings.notification.app.ConversationListSettings;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.HashMap; import java.util.HashMap;
@@ -58,7 +58,7 @@ public class ZenModePriorityConversationsPreferenceController
private int mNumImportantConversations = UNSET; private int mNumImportantConversations = UNSET;
private int mNumConversations = UNSET; private int mNumConversations = UNSET;
private PreferenceCategory mPreferenceCategory; private PreferenceCategory mPreferenceCategory;
private List<RadioButtonPreference> mRadioButtonPreferences = new ArrayList<>(); private List<SelectorWithWidgetPreference> mSelectorWithWidgetPreferences = new ArrayList<>();
private Context mPreferenceScreenContext; private Context mPreferenceScreenContext;
public ZenModePriorityConversationsPreferenceController(Context context, String key, public ZenModePriorityConversationsPreferenceController(Context context, String key,
@@ -101,7 +101,7 @@ public class ZenModePriorityConversationsPreferenceController
public void updateState(Preference preference) { public void updateState(Preference preference) {
final int currSetting = mBackend.getPriorityConversationSenders(); final int currSetting = mBackend.getPriorityConversationSenders();
for (RadioButtonPreference pref : mRadioButtonPreferences) { for (SelectorWithWidgetPreference pref : mSelectorWithWidgetPreferences) {
pref.setChecked(keyToSetting(pref.getKey()) == currSetting); pref.setChecked(keyToSetting(pref.getKey()) == currSetting);
pref.setSummary(getSummary(pref.getKey())); pref.setSummary(getSummary(pref.getKey()));
} }
@@ -181,9 +181,9 @@ public class ZenModePriorityConversationsPreferenceController
}.execute(); }.execute();
} }
private RadioButtonPreference makeRadioPreference(String key, int titleId) { private SelectorWithWidgetPreference makeRadioPreference(String key, int titleId) {
final RadioButtonPreference pref = final SelectorWithWidgetPreference pref =
new RadioButtonPreference(mPreferenceCategory.getContext()); new SelectorWithWidgetPreference(mPreferenceCategory.getContext());
if (KEY_ALL.equals(key) || KEY_IMPORTANT.equals(key)) { if (KEY_ALL.equals(key) || KEY_IMPORTANT.equals(key)) {
pref.setExtraWidgetOnClickListener(mConversationSettingsWidgetClickListener); pref.setExtraWidgetOnClickListener(mConversationSettingsWidgetClickListener);
} }
@@ -191,7 +191,7 @@ public class ZenModePriorityConversationsPreferenceController
pref.setTitle(titleId); pref.setTitle(titleId);
pref.setOnClickListener(mRadioButtonClickListener); pref.setOnClickListener(mRadioButtonClickListener);
mPreferenceCategory.addPreference(pref); mPreferenceCategory.addPreference(pref);
mRadioButtonPreferences.add(pref); mSelectorWithWidgetPreferences.add(pref);
return pref; return pref;
} }
@@ -206,10 +206,10 @@ public class ZenModePriorityConversationsPreferenceController
} }
}; };
private RadioButtonPreference.OnClickListener mRadioButtonClickListener = private SelectorWithWidgetPreference.OnClickListener mRadioButtonClickListener =
new RadioButtonPreference.OnClickListener() { new SelectorWithWidgetPreference.OnClickListener() {
@Override @Override
public void onRadioButtonClicked(RadioButtonPreference preference) { public void onRadioButtonClicked(SelectorWithWidgetPreference preference) {
int selectedConversationSetting = keyToSetting(preference.getKey()); int selectedConversationSetting = keyToSetting(preference.getKey());
if (selectedConversationSetting != mBackend.getPriorityConversationSenders()) { if (selectedConversationSetting != mBackend.getPriorityConversationSenders()) {
mBackend.saveConversationSenders(selectedConversationSetting); mBackend.saveConversationSenders(selectedConversationSetting);

View File

@@ -33,7 +33,7 @@ import androidx.preference.PreferenceScreen;
import com.android.settings.R; import com.android.settings.R;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
@@ -63,7 +63,7 @@ public class ZenModePrioritySendersPreferenceController
private final boolean mIsMessages; // if this is false, then this preference is for calls private final boolean mIsMessages; // if this is false, then this preference is for calls
private PreferenceCategory mPreferenceCategory; private PreferenceCategory mPreferenceCategory;
private List<RadioButtonPreference> mRadioButtonPreferences = new ArrayList<>(); private List<SelectorWithWidgetPreference> mSelectorWithWidgetPreferences = new ArrayList<>();
public ZenModePrioritySendersPreferenceController(Context context, String key, public ZenModePrioritySendersPreferenceController(Context context, String key,
Lifecycle lifecycle, boolean isMessages) { Lifecycle lifecycle, boolean isMessages) {
@@ -110,7 +110,7 @@ public class ZenModePrioritySendersPreferenceController
public void updateState(Preference preference) { public void updateState(Preference preference) {
final int currSetting = getPrioritySenders(); final int currSetting = getPrioritySenders();
for (RadioButtonPreference pref : mRadioButtonPreferences) { for (SelectorWithWidgetPreference pref : mSelectorWithWidgetPreferences) {
pref.setChecked(keyToSetting(pref.getKey()) == currSetting); pref.setChecked(keyToSetting(pref.getKey()) == currSetting);
} }
} }
@@ -122,7 +122,7 @@ public class ZenModePrioritySendersPreferenceController
} }
private void updateSummaries() { private void updateSummaries() {
for (RadioButtonPreference pref : mRadioButtonPreferences) { for (SelectorWithWidgetPreference pref : mSelectorWithWidgetPreferences) {
pref.setSummary(getSummary(pref.getKey())); pref.setSummary(getSummary(pref.getKey()));
} }
} }
@@ -165,9 +165,9 @@ public class ZenModePrioritySendersPreferenceController
} }
} }
private RadioButtonPreference makeRadioPreference(String key, int titleId) { private SelectorWithWidgetPreference makeRadioPreference(String key, int titleId) {
final RadioButtonPreference pref = final SelectorWithWidgetPreference pref =
new RadioButtonPreference(mPreferenceCategory.getContext()); new SelectorWithWidgetPreference(mPreferenceCategory.getContext());
pref.setKey(key); pref.setKey(key);
pref.setTitle(titleId); pref.setTitle(titleId);
pref.setOnClickListener(mRadioButtonClickListener); pref.setOnClickListener(mRadioButtonClickListener);
@@ -178,14 +178,14 @@ public class ZenModePrioritySendersPreferenceController
} }
mPreferenceCategory.addPreference(pref); mPreferenceCategory.addPreference(pref);
mRadioButtonPreferences.add(pref); mSelectorWithWidgetPreferences.add(pref);
return pref; return pref;
} }
private RadioButtonPreference.OnClickListener mRadioButtonClickListener = private SelectorWithWidgetPreference.OnClickListener mRadioButtonClickListener =
new RadioButtonPreference.OnClickListener() { new SelectorWithWidgetPreference.OnClickListener() {
@Override @Override
public void onRadioButtonClicked(RadioButtonPreference preference) { public void onRadioButtonClicked(SelectorWithWidgetPreference preference) {
int selectedSetting = keyToSetting(preference.getKey()); int selectedSetting = keyToSetting(preference.getKey());
if (selectedSetting != getPrioritySenders()) { if (selectedSetting != getPrioritySenders()) {
mBackend.saveSenders( mBackend.saveSenders(

View File

@@ -24,13 +24,13 @@ import androidx.preference.Preference;
import androidx.preference.PreferenceScreen; import androidx.preference.PreferenceScreen;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
public class ZenModeVisEffectsAllPreferenceController public class ZenModeVisEffectsAllPreferenceController
extends AbstractZenModePreferenceController extends AbstractZenModePreferenceController
implements RadioButtonPreference.OnClickListener { implements SelectorWithWidgetPreference.OnClickListener {
private RadioButtonPreference mPreference; private SelectorWithWidgetPreference mPreference;
protected static final int EFFECTS = Policy.SUPPRESSED_EFFECT_SCREEN_OFF protected static final int EFFECTS = Policy.SUPPRESSED_EFFECT_SCREEN_OFF
| Policy.SUPPRESSED_EFFECT_SCREEN_ON | Policy.SUPPRESSED_EFFECT_SCREEN_ON
@@ -69,7 +69,7 @@ public class ZenModeVisEffectsAllPreferenceController
} }
@Override @Override
public void onRadioButtonClicked(RadioButtonPreference p) { public void onRadioButtonClicked(SelectorWithWidgetPreference p) {
mMetricsFeatureProvider.action(mContext, mMetricsFeatureProvider.action(mContext,
SettingsEnums.ACTION_ZEN_SOUND_AND_VIS_EFFECTS, true); SettingsEnums.ACTION_ZEN_SOUND_AND_VIS_EFFECTS, true);
mBackend.saveVisualEffectsPolicy(EFFECTS, true); mBackend.saveVisualEffectsPolicy(EFFECTS, true);

View File

@@ -26,12 +26,12 @@ import androidx.preference.PreferenceScreen;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.core.SubSettingLauncher; import com.android.settings.core.SubSettingLauncher;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
public class ZenModeVisEffectsCustomPreferenceController public class ZenModeVisEffectsCustomPreferenceController
extends AbstractZenModePreferenceController { extends AbstractZenModePreferenceController {
private RadioButtonPreference mPreference; private SelectorWithWidgetPreference mPreference;
protected static final int INTERRUPTIVE_EFFECTS = protected static final int INTERRUPTIVE_EFFECTS =
NotificationManager.Policy.SUPPRESSED_EFFECT_AMBIENT NotificationManager.Policy.SUPPRESSED_EFFECT_AMBIENT

View File

@@ -24,13 +24,13 @@ import androidx.preference.Preference;
import androidx.preference.PreferenceScreen; import androidx.preference.PreferenceScreen;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
public class ZenModeVisEffectsNonePreferenceController public class ZenModeVisEffectsNonePreferenceController
extends AbstractZenModePreferenceController extends AbstractZenModePreferenceController
implements RadioButtonPreference.OnClickListener { implements SelectorWithWidgetPreference.OnClickListener {
private RadioButtonPreference mPreference; private SelectorWithWidgetPreference mPreference;
protected static final int EFFECTS = Policy.SUPPRESSED_EFFECT_SCREEN_OFF protected static final int EFFECTS = Policy.SUPPRESSED_EFFECT_SCREEN_OFF
| Policy.SUPPRESSED_EFFECT_SCREEN_ON | Policy.SUPPRESSED_EFFECT_SCREEN_ON
@@ -68,7 +68,7 @@ public class ZenModeVisEffectsNonePreferenceController
} }
@Override @Override
public void onRadioButtonClicked(RadioButtonPreference preference) { public void onRadioButtonClicked(SelectorWithWidgetPreference preference) {
mMetricsFeatureProvider.action(mContext, mMetricsFeatureProvider.action(mContext,
SettingsEnums.ACTION_ZEN_SOUND_ONLY, true); SettingsEnums.ACTION_ZEN_SOUND_ONLY, true);
mBackend.saveVisualEffectsPolicy(EFFECTS, false); mBackend.saveVisualEffectsPolicy(EFFECTS, false);

View File

@@ -25,12 +25,12 @@ import androidx.preference.PreferenceScreen;
import com.android.settings.core.SubSettingLauncher; import com.android.settings.core.SubSettingLauncher;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
public class ZenRuleCustomPolicyPreferenceController extends public class ZenRuleCustomPolicyPreferenceController extends
AbstractZenCustomRulePreferenceController { AbstractZenCustomRulePreferenceController {
private RadioButtonPreference mPreference; private SelectorWithWidgetPreference mPreference;
public ZenRuleCustomPolicyPreferenceController(Context context, Lifecycle lifecycle, public ZenRuleCustomPolicyPreferenceController(Context context, Lifecycle lifecycle,
String key) { String key) {

View File

@@ -26,12 +26,12 @@ import androidx.preference.PreferenceScreen;
import com.android.internal.logging.nano.MetricsProto; import com.android.internal.logging.nano.MetricsProto;
import com.android.settings.core.PreferenceControllerMixin; import com.android.settings.core.PreferenceControllerMixin;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
public class ZenRuleDefaultPolicyPreferenceController extends public class ZenRuleDefaultPolicyPreferenceController extends
AbstractZenCustomRulePreferenceController implements PreferenceControllerMixin { AbstractZenCustomRulePreferenceController implements PreferenceControllerMixin {
private RadioButtonPreference mPreference; private SelectorWithWidgetPreference mPreference;
public ZenRuleDefaultPolicyPreferenceController(Context context, Lifecycle lifecycle, public ZenRuleDefaultPolicyPreferenceController(Context context, Lifecycle lifecycle,
String key) { String key) {

View File

@@ -27,12 +27,12 @@ import androidx.preference.PreferenceScreen;
import com.android.internal.logging.nano.MetricsProto; import com.android.internal.logging.nano.MetricsProto;
import com.android.settings.core.PreferenceControllerMixin; import com.android.settings.core.PreferenceControllerMixin;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
public class ZenRuleVisEffectsAllPreferenceController extends public class ZenRuleVisEffectsAllPreferenceController extends
AbstractZenCustomRulePreferenceController implements PreferenceControllerMixin { AbstractZenCustomRulePreferenceController implements PreferenceControllerMixin {
private RadioButtonPreference mPreference; private SelectorWithWidgetPreference mPreference;
public ZenRuleVisEffectsAllPreferenceController(Context context, Lifecycle lifecycle, public ZenRuleVisEffectsAllPreferenceController(Context context, Lifecycle lifecycle,
String key) { String key) {

View File

@@ -27,12 +27,12 @@ import com.android.internal.logging.nano.MetricsProto;
import com.android.settings.core.PreferenceControllerMixin; import com.android.settings.core.PreferenceControllerMixin;
import com.android.settings.core.SubSettingLauncher; import com.android.settings.core.SubSettingLauncher;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
public class ZenRuleVisEffectsCustomPreferenceController extends public class ZenRuleVisEffectsCustomPreferenceController extends
AbstractZenCustomRulePreferenceController implements PreferenceControllerMixin { AbstractZenCustomRulePreferenceController implements PreferenceControllerMixin {
private RadioButtonPreference mPreference; private SelectorWithWidgetPreference mPreference;
public ZenRuleVisEffectsCustomPreferenceController(Context context, Lifecycle lifecycle, public ZenRuleVisEffectsCustomPreferenceController(Context context, Lifecycle lifecycle,
String key) { String key) {

View File

@@ -27,12 +27,12 @@ import androidx.preference.PreferenceScreen;
import com.android.internal.logging.nano.MetricsProto; import com.android.internal.logging.nano.MetricsProto;
import com.android.settings.core.PreferenceControllerMixin; import com.android.settings.core.PreferenceControllerMixin;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
public class ZenRuleVisEffectsNonePreferenceController extends public class ZenRuleVisEffectsNonePreferenceController extends
AbstractZenCustomRulePreferenceController implements PreferenceControllerMixin { AbstractZenCustomRulePreferenceController implements PreferenceControllerMixin {
private RadioButtonPreference mPreference; private SelectorWithWidgetPreference mPreference;
public ZenRuleVisEffectsNonePreferenceController(Context context, Lifecycle lifecycle, public ZenRuleVisEffectsNonePreferenceController(Context context, Lifecycle lifecycle,
String key) { String key) {

View File

@@ -38,7 +38,7 @@ import com.android.settings.core.InstrumentedPreferenceFragment;
import com.android.settings.core.PreferenceXmlParserUtils; import com.android.settings.core.PreferenceXmlParserUtils;
import com.android.settings.core.PreferenceXmlParserUtils.MetadataFlag; import com.android.settings.core.PreferenceXmlParserUtils.MetadataFlag;
import com.android.settingslib.widget.CandidateInfo; import com.android.settingslib.widget.CandidateInfo;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.xmlpull.v1.XmlPullParserException; import org.xmlpull.v1.XmlPullParserException;
@@ -47,7 +47,7 @@ import java.util.List;
import java.util.Map; import java.util.Map;
public abstract class RadioButtonPickerFragment extends InstrumentedPreferenceFragment implements public abstract class RadioButtonPickerFragment extends InstrumentedPreferenceFragment implements
RadioButtonPreference.OnClickListener { SelectorWithWidgetPreference.OnClickListener {
@VisibleForTesting @VisibleForTesting
static final String EXTRA_FOR_WORK = "for_work"; static final String EXTRA_FOR_WORK = "for_work";
@@ -110,7 +110,7 @@ public abstract class RadioButtonPickerFragment extends InstrumentedPreferenceFr
protected abstract int getPreferenceScreenResId(); protected abstract int getPreferenceScreenResId();
@Override @Override
public void onRadioButtonClicked(RadioButtonPreference selected) { public void onRadioButtonClicked(SelectorWithWidgetPreference selected) {
final String selectedKey = selected.getKey(); final String selectedKey = selected.getKey();
onRadioButtonConfirmed(selectedKey); onRadioButtonConfirmed(selectedKey);
} }
@@ -150,7 +150,7 @@ public abstract class RadioButtonPickerFragment extends InstrumentedPreferenceFr
/** /**
* A chance for subclasses to bind additional things to the preference. * A chance for subclasses to bind additional things to the preference.
*/ */
public void bindPreferenceExtra(RadioButtonPreference pref, public void bindPreferenceExtra(SelectorWithWidgetPreference pref,
String key, CandidateInfo info, String defaultKey, String systemDefaultKey) { String key, CandidateInfo info, String defaultKey, String systemDefaultKey) {
} }
@@ -175,7 +175,8 @@ public abstract class RadioButtonPickerFragment extends InstrumentedPreferenceFr
final int customLayoutResId = getRadioButtonPreferenceCustomLayoutResId(); final int customLayoutResId = getRadioButtonPreferenceCustomLayoutResId();
if (shouldShowItemNone()) { if (shouldShowItemNone()) {
final RadioButtonPreference nonePref = new RadioButtonPreference(getPrefContext()); final SelectorWithWidgetPreference nonePref =
new SelectorWithWidgetPreference(getPrefContext());
if (customLayoutResId > 0) { if (customLayoutResId > 0) {
nonePref.setLayoutResource(customLayoutResId); nonePref.setLayoutResource(customLayoutResId);
} }
@@ -187,7 +188,8 @@ public abstract class RadioButtonPickerFragment extends InstrumentedPreferenceFr
} }
if (candidateList != null) { if (candidateList != null) {
for (CandidateInfo info : candidateList) { for (CandidateInfo info : candidateList) {
RadioButtonPreference pref = new RadioButtonPreference(getPrefContext()); SelectorWithWidgetPreference pref =
new SelectorWithWidgetPreference(getPrefContext());
if (customLayoutResId > 0) { if (customLayoutResId > 0) {
pref.setLayoutResource(customLayoutResId); pref.setLayoutResource(customLayoutResId);
} }
@@ -202,7 +204,7 @@ public abstract class RadioButtonPickerFragment extends InstrumentedPreferenceFr
} }
} }
public RadioButtonPreference bindPreference(RadioButtonPreference pref, public SelectorWithWidgetPreference bindPreference(SelectorWithWidgetPreference pref,
String key, CandidateInfo info, String defaultKey) { String key, CandidateInfo info, String defaultKey) {
pref.setTitle(info.loadLabel()); pref.setTitle(info.loadLabel());
pref.setIcon(Utils.getSafeIcon(info.loadIcon())); pref.setIcon(Utils.getSafeIcon(info.loadIcon()));
@@ -221,8 +223,9 @@ public abstract class RadioButtonPickerFragment extends InstrumentedPreferenceFr
final int count = screen.getPreferenceCount(); final int count = screen.getPreferenceCount();
for (int i = 0; i < count; i++) { for (int i = 0; i < count; i++) {
final Preference pref = screen.getPreference(i); final Preference pref = screen.getPreference(i);
if (pref instanceof RadioButtonPreference) { if (pref instanceof SelectorWithWidgetPreference) {
final RadioButtonPreference radioPref = (RadioButtonPreference) pref; final SelectorWithWidgetPreference radioPref =
(SelectorWithWidgetPreference) pref;
final boolean newCheckedState = TextUtils.equals(pref.getKey(), selectedKey); final boolean newCheckedState = TextUtils.equals(pref.getKey(), selectedKey);
if (radioPref.isChecked() != newCheckedState) { if (radioPref.isChecked() != newCheckedState) {
radioPref.setChecked(TextUtils.equals(pref.getKey(), selectedKey)); radioPref.setChecked(TextUtils.equals(pref.getKey(), selectedKey));
@@ -237,8 +240,8 @@ public abstract class RadioButtonPickerFragment extends InstrumentedPreferenceFr
// If there is only 1 thing on screen, select it. // If there is only 1 thing on screen, select it.
if (screen != null && screen.getPreferenceCount() == 1) { if (screen != null && screen.getPreferenceCount() == 1) {
final Preference onlyPref = screen.getPreference(0); final Preference onlyPref = screen.getPreference(0);
if (onlyPref instanceof RadioButtonPreference) { if (onlyPref instanceof SelectorWithWidgetPreference) {
((RadioButtonPreference) onlyPref).setChecked(true); ((SelectorWithWidgetPreference) onlyPref).setChecked(true);
} }
} }
} }

View File

@@ -32,7 +32,7 @@ import androidx.preference.PreferenceScreen;
import com.android.settings.R; import com.android.settings.R;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -50,7 +50,7 @@ public class AccessibilityTimeoutControllerTest
private AccessibilityTimeoutController mController; private AccessibilityTimeoutController mController;
@Mock @Mock
private RadioButtonPreference mMockPref; private SelectorWithWidgetPreference mMockPref;
private Context mContext; private Context mContext;
private ContentResolver mContentResolver; private ContentResolver mContentResolver;

View File

@@ -31,7 +31,7 @@ import androidx.preference.Preference;
import androidx.preference.PreferenceScreen; import androidx.preference.PreferenceScreen;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -51,7 +51,7 @@ public class DaltonizerRadioButtonPreferenceControllerTest implements
private DaltonizerRadioButtonPreferenceController mController; private DaltonizerRadioButtonPreferenceController mController;
@Mock @Mock
private RadioButtonPreference mMockPref; private SelectorWithWidgetPreference mMockPref;
private Context mContext; private Context mContext;
@Mock @Mock

View File

@@ -42,8 +42,8 @@ import androidx.test.core.app.ApplicationProvider;
import com.android.settings.accessibility.ToggleAutoclickPreferenceController.OnChangeListener; import com.android.settings.accessibility.ToggleAutoclickPreferenceController.OnChangeListener;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.LayoutPreference; import com.android.settingslib.widget.LayoutPreference;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import com.android.settingslib.widget.RadioButtonPreference.OnClickListener; import com.android.settingslib.widget.SelectorWithWidgetPreference.OnClickListener;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -62,7 +62,7 @@ public class ToggleAutoclickPreferenceControllerTest {
private PreferenceScreen mScreen; private PreferenceScreen mScreen;
@Mock @Mock
private RadioButtonPreference mDelayModePref; private SelectorWithWidgetPreference mDelayModePref;
@Mock @Mock
private OnChangeListener mOnChangeListener; private OnChangeListener mOnChangeListener;
@@ -118,7 +118,7 @@ public class ToggleAutoclickPreferenceControllerTest {
when(mAccessibilityAutoclickKeyToValueMap.get(mPrefKey)).thenReturn(AUTOCLICK_OFF_MODE); when(mAccessibilityAutoclickKeyToValueMap.get(mPrefKey)).thenReturn(AUTOCLICK_OFF_MODE);
mController.displayPreference(mScreen); mController.displayPreference(mScreen);
mController.onRadioButtonClicked(any(RadioButtonPreference.class)); mController.onRadioButtonClicked(any(SelectorWithWidgetPreference.class));
final boolean isEnabled = Secure.getInt(mContext.getContentResolver(), final boolean isEnabled = Secure.getInt(mContext.getContentResolver(),
Secure.ACCESSIBILITY_AUTOCLICK_ENABLED, /* def= */ 0) == 1; Secure.ACCESSIBILITY_AUTOCLICK_ENABLED, /* def= */ 0) == 1;
final int delayMs = Secure.getInt(mContext.getContentResolver(), final int delayMs = Secure.getInt(mContext.getContentResolver(),
@@ -137,7 +137,7 @@ public class ToggleAutoclickPreferenceControllerTest {
when(mAccessibilityAutoclickKeyToValueMap.get(mPrefKey)).thenReturn(AUTOCLICK_CUSTOM_MODE); when(mAccessibilityAutoclickKeyToValueMap.get(mPrefKey)).thenReturn(AUTOCLICK_CUSTOM_MODE);
mController.displayPreference(mScreen); mController.displayPreference(mScreen);
mController.onRadioButtonClicked(any(RadioButtonPreference.class)); mController.onRadioButtonClicked(any(SelectorWithWidgetPreference.class));
final boolean isEnabled = Secure.getInt(mContext.getContentResolver(), final boolean isEnabled = Secure.getInt(mContext.getContentResolver(),
Secure.ACCESSIBILITY_AUTOCLICK_ENABLED, /* def= */ 0) == 1; Secure.ACCESSIBILITY_AUTOCLICK_ENABLED, /* def= */ 0) == 1;
final int keyDelayMode = mSharedPreferences.getInt(KEY_DELAY_MODE, AUTOCLICK_CUSTOM_MODE); final int keyDelayMode = mSharedPreferences.getInt(KEY_DELAY_MODE, AUTOCLICK_CUSTOM_MODE);
@@ -154,7 +154,7 @@ public class ToggleAutoclickPreferenceControllerTest {
mController.setOnChangeListener(mOnChangeListener); mController.setOnChangeListener(mOnChangeListener);
mController.displayPreference(mScreen); mController.displayPreference(mScreen);
mController.onRadioButtonClicked(any(RadioButtonPreference.class)); mController.onRadioButtonClicked(any(SelectorWithWidgetPreference.class));
verify(mOnChangeListener).onCheckedChanged(mDelayModePref); verify(mOnChangeListener).onCheckedChanged(mDelayModePref);
} }

View File

@@ -32,7 +32,7 @@ import androidx.preference.PreferenceScreen;
import com.android.internal.logging.nano.MetricsProto; import com.android.internal.logging.nano.MetricsProto;
import com.android.settings.testutils.FakeFeatureFactory; import com.android.settings.testutils.FakeFeatureFactory;
import com.android.settingslib.applications.DefaultAppInfo; import com.android.settingslib.applications.DefaultAppInfo;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -73,8 +73,8 @@ public class DefaultAppPickerFragmentTest {
@Test @Test
public void clickPreference_hasConfirmation_shouldShowConfirmation() { public void clickPreference_hasConfirmation_shouldShowConfirmation() {
mFragment.onAttach((Context) mActivity); mFragment.onAttach((Context) mActivity);
final RadioButtonPreference pref = final SelectorWithWidgetPreference pref =
new RadioButtonPreference(RuntimeEnvironment.application); new SelectorWithWidgetPreference(RuntimeEnvironment.application);
pref.setKey("TEST"); pref.setKey("TEST");
doReturn("confirmation_text").when(mFragment) doReturn("confirmation_text").when(mFragment)
.getConfirmationMessage(any(DefaultAppInfo.class)); .getConfirmationMessage(any(DefaultAppInfo.class));

View File

@@ -39,7 +39,7 @@ import android.util.Pair;
import androidx.fragment.app.FragmentActivity; import androidx.fragment.app.FragmentActivity;
import com.android.settingslib.core.instrumentation.MetricsFeatureProvider; import com.android.settingslib.core.instrumentation.MetricsFeatureProvider;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.After; import org.junit.After;
import org.junit.Before; import org.junit.Before;
@@ -138,7 +138,7 @@ public class BugReportHandlerPickerTest {
when(mBugReportHandlerUtil.setCurrentBugReportHandlerAppAndUser(any(), eq(PACKAGE_NAME), when(mBugReportHandlerUtil.setCurrentBugReportHandlerAppAndUser(any(), eq(PACKAGE_NAME),
eq(USER_ID))).thenReturn(true); eq(USER_ID))).thenReturn(true);
RadioButtonPreference defaultPackagePref = mock(RadioButtonPreference.class); SelectorWithWidgetPreference defaultPackagePref = mock(SelectorWithWidgetPreference.class);
when(defaultPackagePref.getKey()).thenReturn( when(defaultPackagePref.getKey()).thenReturn(
BugReportHandlerPicker.getKey(PACKAGE_NAME, USER_ID)); BugReportHandlerPicker.getKey(PACKAGE_NAME, USER_ID));
mPicker.onRadioButtonClicked(defaultPackagePref); mPicker.onRadioButtonClicked(defaultPackagePref);
@@ -157,7 +157,7 @@ public class BugReportHandlerPickerTest {
when(mBugReportHandlerUtil.setCurrentBugReportHandlerAppAndUser(any(), eq(PACKAGE_NAME), when(mBugReportHandlerUtil.setCurrentBugReportHandlerAppAndUser(any(), eq(PACKAGE_NAME),
eq(USER_ID))).thenReturn(false); eq(USER_ID))).thenReturn(false);
RadioButtonPreference defaultPackagePref = mock(RadioButtonPreference.class); SelectorWithWidgetPreference defaultPackagePref = mock(SelectorWithWidgetPreference.class);
when(defaultPackagePref.getKey()).thenReturn( when(defaultPackagePref.getKey()).thenReturn(
BugReportHandlerPicker.getKey(PACKAGE_NAME, USER_ID)); BugReportHandlerPicker.getKey(PACKAGE_NAME, USER_ID));
mPicker.onRadioButtonClicked(defaultPackagePref); mPicker.onRadioButtonClicked(defaultPackagePref);

View File

@@ -39,7 +39,7 @@ import androidx.preference.PreferenceScreen;
import com.android.settings.R; import com.android.settings.R;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -100,8 +100,8 @@ public class UsbDetailsDataRoleControllerTest {
mDetailsDataRoleController.refresh(true, UsbManager.FUNCTION_NONE, POWER_ROLE_SINK, mDetailsDataRoleController.refresh(true, UsbManager.FUNCTION_NONE, POWER_ROLE_SINK,
DATA_ROLE_DEVICE); DATA_ROLE_DEVICE);
final RadioButtonPreference devicePref = getRadioPreference(DATA_ROLE_DEVICE); final SelectorWithWidgetPreference devicePref = getRadioPreference(DATA_ROLE_DEVICE);
final RadioButtonPreference hostPref = getRadioPreference(DATA_ROLE_HOST); final SelectorWithWidgetPreference hostPref = getRadioPreference(DATA_ROLE_HOST);
assertThat(devicePref.isChecked()).isTrue(); assertThat(devicePref.isChecked()).isTrue();
assertThat(hostPref.isChecked()).isFalse(); assertThat(hostPref.isChecked()).isFalse();
} }
@@ -113,8 +113,8 @@ public class UsbDetailsDataRoleControllerTest {
mDetailsDataRoleController.refresh(true, UsbManager.FUNCTION_NONE, POWER_ROLE_SINK, mDetailsDataRoleController.refresh(true, UsbManager.FUNCTION_NONE, POWER_ROLE_SINK,
DATA_ROLE_HOST); DATA_ROLE_HOST);
final RadioButtonPreference devicePref = getRadioPreference(DATA_ROLE_DEVICE); final SelectorWithWidgetPreference devicePref = getRadioPreference(DATA_ROLE_DEVICE);
final RadioButtonPreference hostPref = getRadioPreference(DATA_ROLE_HOST); final SelectorWithWidgetPreference hostPref = getRadioPreference(DATA_ROLE_HOST);
assertThat(devicePref.isChecked()).isFalse(); assertThat(devicePref.isChecked()).isFalse();
assertThat(hostPref.isChecked()).isTrue(); assertThat(hostPref.isChecked()).isTrue();
} }
@@ -134,7 +134,7 @@ public class UsbDetailsDataRoleControllerTest {
mDetailsDataRoleController.displayPreference(mScreen); mDetailsDataRoleController.displayPreference(mScreen);
when(mUsbBackend.getDataRole()).thenReturn(DATA_ROLE_HOST); when(mUsbBackend.getDataRole()).thenReturn(DATA_ROLE_HOST);
final RadioButtonPreference devicePref = getRadioPreference(DATA_ROLE_DEVICE); final SelectorWithWidgetPreference devicePref = getRadioPreference(DATA_ROLE_DEVICE);
devicePref.performClick(); devicePref.performClick();
verify(mUsbBackend).setDataRole(DATA_ROLE_DEVICE); verify(mUsbBackend).setDataRole(DATA_ROLE_DEVICE);
@@ -147,7 +147,7 @@ public class UsbDetailsDataRoleControllerTest {
mDetailsDataRoleController.displayPreference(mScreen); mDetailsDataRoleController.displayPreference(mScreen);
when(mUsbBackend.getDataRole()).thenReturn(DATA_ROLE_HOST); when(mUsbBackend.getDataRole()).thenReturn(DATA_ROLE_HOST);
final RadioButtonPreference devicePref = getRadioPreference(DATA_ROLE_DEVICE); final SelectorWithWidgetPreference devicePref = getRadioPreference(DATA_ROLE_DEVICE);
devicePref.performClick(); devicePref.performClick();
assertThat(devicePref.getSummary()) assertThat(devicePref.getSummary())
@@ -161,7 +161,7 @@ public class UsbDetailsDataRoleControllerTest {
mDetailsDataRoleController.displayPreference(mScreen); mDetailsDataRoleController.displayPreference(mScreen);
when(mUsbBackend.getDataRole()).thenReturn(DATA_ROLE_HOST); when(mUsbBackend.getDataRole()).thenReturn(DATA_ROLE_HOST);
final RadioButtonPreference devicePref = getRadioPreference(DATA_ROLE_DEVICE); final SelectorWithWidgetPreference devicePref = getRadioPreference(DATA_ROLE_DEVICE);
devicePref.performClick(); devicePref.performClick();
verify(mUsbBackend).setDataRole(DATA_ROLE_DEVICE); verify(mUsbBackend).setDataRole(DATA_ROLE_DEVICE);
@@ -179,7 +179,7 @@ public class UsbDetailsDataRoleControllerTest {
mDetailsDataRoleController.displayPreference(mScreen); mDetailsDataRoleController.displayPreference(mScreen);
when(mUsbBackend.getDataRole()).thenReturn(DATA_ROLE_HOST); when(mUsbBackend.getDataRole()).thenReturn(DATA_ROLE_HOST);
final RadioButtonPreference devicePref = getRadioPreference(DATA_ROLE_DEVICE); final SelectorWithWidgetPreference devicePref = getRadioPreference(DATA_ROLE_DEVICE);
devicePref.performClick(); devicePref.performClick();
verify(mUsbBackend).setDataRole(DATA_ROLE_DEVICE); verify(mUsbBackend).setDataRole(DATA_ROLE_DEVICE);
@@ -198,7 +198,7 @@ public class UsbDetailsDataRoleControllerTest {
mDetailsDataRoleController.displayPreference(mScreen); mDetailsDataRoleController.displayPreference(mScreen);
when(mUsbBackend.getDataRole()).thenReturn(DATA_ROLE_HOST); when(mUsbBackend.getDataRole()).thenReturn(DATA_ROLE_HOST);
final RadioButtonPreference devicePref = getRadioPreference(DATA_ROLE_DEVICE); final SelectorWithWidgetPreference devicePref = getRadioPreference(DATA_ROLE_DEVICE);
devicePref.performClick(); devicePref.performClick();
verify(mUsbBackend).setDataRole(DATA_ROLE_DEVICE); verify(mUsbBackend).setDataRole(DATA_ROLE_DEVICE);
@@ -214,8 +214,8 @@ public class UsbDetailsDataRoleControllerTest {
.isEqualTo(mContext.getString(R.string.usb_switching_failed)); .isEqualTo(mContext.getString(R.string.usb_switching_failed));
} }
private RadioButtonPreference getRadioPreference(int role) { private SelectorWithWidgetPreference getRadioPreference(int role) {
return (RadioButtonPreference) return (SelectorWithWidgetPreference)
mPreference.findPreference(UsbBackend.dataRoleToString(role)); mPreference.findPreference(UsbBackend.dataRoleToString(role));
} }
} }

View File

@@ -41,7 +41,7 @@ import androidx.preference.PreferenceScreen;
import com.android.settings.testutils.shadow.ShadowUtils; import com.android.settings.testutils.shadow.ShadowUtils;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -65,7 +65,7 @@ public class UsbDetailsFunctionsControllerTest {
private PreferenceCategory mPreferenceCategory; private PreferenceCategory mPreferenceCategory;
private PreferenceManager mPreferenceManager; private PreferenceManager mPreferenceManager;
private PreferenceScreen mScreen; private PreferenceScreen mScreen;
private RadioButtonPreference mRadioButtonPreference; private SelectorWithWidgetPreference mRadioButtonPreference;
@Mock @Mock
private UsbBackend mUsbBackend; private UsbBackend mUsbBackend;
@@ -99,7 +99,7 @@ public class UsbDetailsFunctionsControllerTest {
mScreen.addPreference(mPreferenceCategory); mScreen.addPreference(mPreferenceCategory);
mDetailsFunctionsController.displayPreference(mScreen); mDetailsFunctionsController.displayPreference(mScreen);
mRadioButtonPreference = new RadioButtonPreference(mContext); mRadioButtonPreference = new SelectorWithWidgetPreference(mContext);
} }
@Test @Test
@@ -109,10 +109,10 @@ public class UsbDetailsFunctionsControllerTest {
mDetailsFunctionsController.displayPreference(mScreen); mDetailsFunctionsController.displayPreference(mScreen);
mDetailsFunctionsController.refresh(true, UsbManager.FUNCTION_NONE, POWER_ROLE_SINK, mDetailsFunctionsController.refresh(true, UsbManager.FUNCTION_NONE, POWER_ROLE_SINK,
DATA_ROLE_DEVICE); DATA_ROLE_DEVICE);
List<RadioButtonPreference> prefs = getRadioPreferences(); List<SelectorWithWidgetPreference> prefs = getRadioPreferences();
Iterator<Long> iter = UsbDetailsFunctionsController.FUNCTIONS_MAP.keySet().iterator(); Iterator<Long> iter = UsbDetailsFunctionsController.FUNCTIONS_MAP.keySet().iterator();
for (RadioButtonPreference pref : prefs) { for (SelectorWithWidgetPreference pref : prefs) {
assertThat(pref.getKey()).isEqualTo(UsbBackend.usbFunctionsToString(iter.next())); assertThat(pref.getKey()).isEqualTo(UsbBackend.usbFunctionsToString(iter.next()));
} }
} }
@@ -135,7 +135,7 @@ public class UsbDetailsFunctionsControllerTest {
mDetailsFunctionsController.refresh(true, UsbManager.FUNCTION_NONE, POWER_ROLE_SINK, mDetailsFunctionsController.refresh(true, UsbManager.FUNCTION_NONE, POWER_ROLE_SINK,
DATA_ROLE_DEVICE); DATA_ROLE_DEVICE);
List<RadioButtonPreference> prefs = getRadioPreferences(); List<SelectorWithWidgetPreference> prefs = getRadioPreferences();
assertThat(prefs.size()).isEqualTo(1); assertThat(prefs.size()).isEqualTo(1);
assertThat(prefs.get(0).getKey()) assertThat(prefs.get(0).getKey())
.isEqualTo(UsbBackend.usbFunctionsToString(UsbManager.FUNCTION_MIDI)); .isEqualTo(UsbBackend.usbFunctionsToString(UsbManager.FUNCTION_MIDI));
@@ -147,7 +147,7 @@ public class UsbDetailsFunctionsControllerTest {
mDetailsFunctionsController.refresh(true, UsbManager.FUNCTION_MTP, POWER_ROLE_SINK, mDetailsFunctionsController.refresh(true, UsbManager.FUNCTION_MTP, POWER_ROLE_SINK,
DATA_ROLE_DEVICE); DATA_ROLE_DEVICE);
List<RadioButtonPreference> prefs = getRadioPreferences(); List<SelectorWithWidgetPreference> prefs = getRadioPreferences();
assertThat(prefs.get(0).getKey()) assertThat(prefs.get(0).getKey())
.isEqualTo(UsbBackend.usbFunctionsToString(UsbManager.FUNCTION_MTP)); .isEqualTo(UsbBackend.usbFunctionsToString(UsbManager.FUNCTION_MTP));
@@ -160,7 +160,7 @@ public class UsbDetailsFunctionsControllerTest {
mDetailsFunctionsController.refresh(true, UsbManager.FUNCTION_ACCESSORY, POWER_ROLE_SINK, mDetailsFunctionsController.refresh(true, UsbManager.FUNCTION_ACCESSORY, POWER_ROLE_SINK,
DATA_ROLE_DEVICE); DATA_ROLE_DEVICE);
List<RadioButtonPreference> prefs = getRadioPreferences(); List<SelectorWithWidgetPreference> prefs = getRadioPreferences();
assertThat(prefs.get(0).getKey()) assertThat(prefs.get(0).getKey())
.isEqualTo(UsbBackend.usbFunctionsToString(UsbManager.FUNCTION_MTP)); .isEqualTo(UsbBackend.usbFunctionsToString(UsbManager.FUNCTION_MTP));
@@ -173,7 +173,7 @@ public class UsbDetailsFunctionsControllerTest {
mDetailsFunctionsController.refresh(true, UsbManager.FUNCTION_NCM, POWER_ROLE_SINK, mDetailsFunctionsController.refresh(true, UsbManager.FUNCTION_NCM, POWER_ROLE_SINK,
DATA_ROLE_DEVICE); DATA_ROLE_DEVICE);
List<RadioButtonPreference> prefs = getRadioPreferences(); List<SelectorWithWidgetPreference> prefs = getRadioPreferences();
assertThat(prefs.get(1).getKey()) assertThat(prefs.get(1).getKey())
.isEqualTo(UsbBackend.usbFunctionsToString(UsbManager.FUNCTION_RNDIS)); .isEqualTo(UsbBackend.usbFunctionsToString(UsbManager.FUNCTION_RNDIS));
@@ -187,7 +187,7 @@ public class UsbDetailsFunctionsControllerTest {
mDetailsFunctionsController.refresh(true, UsbManager.FUNCTION_NONE, POWER_ROLE_SINK, mDetailsFunctionsController.refresh(true, UsbManager.FUNCTION_NONE, POWER_ROLE_SINK,
DATA_ROLE_DEVICE); DATA_ROLE_DEVICE);
when(mUsbBackend.getCurrentFunctions()).thenReturn(UsbManager.FUNCTION_NONE); when(mUsbBackend.getCurrentFunctions()).thenReturn(UsbManager.FUNCTION_NONE);
List<RadioButtonPreference> prefs = getRadioPreferences(); List<SelectorWithWidgetPreference> prefs = getRadioPreferences();
prefs.get(0).performClick(); prefs.get(0).performClick();
assertThat(prefs.get(0).getKey()) assertThat(prefs.get(0).getKey())
@@ -205,7 +205,7 @@ public class UsbDetailsFunctionsControllerTest {
mDetailsFunctionsController.refresh(true, UsbManager.FUNCTION_PTP, POWER_ROLE_SINK, mDetailsFunctionsController.refresh(true, UsbManager.FUNCTION_PTP, POWER_ROLE_SINK,
DATA_ROLE_DEVICE); DATA_ROLE_DEVICE);
when(mUsbBackend.getCurrentFunctions()).thenReturn(UsbManager.FUNCTION_PTP); when(mUsbBackend.getCurrentFunctions()).thenReturn(UsbManager.FUNCTION_PTP);
List<RadioButtonPreference> prefs = getRadioPreferences(); List<SelectorWithWidgetPreference> prefs = getRadioPreferences();
prefs.get(0).performClick(); prefs.get(0).performClick();
assertThat(prefs.get(0).getKey()) assertThat(prefs.get(0).getKey())
@@ -226,7 +226,7 @@ public class UsbDetailsFunctionsControllerTest {
mDetailsFunctionsController.refresh(true, UsbManager.FUNCTION_MTP, POWER_ROLE_SINK, mDetailsFunctionsController.refresh(true, UsbManager.FUNCTION_MTP, POWER_ROLE_SINK,
DATA_ROLE_DEVICE); DATA_ROLE_DEVICE);
when(mUsbBackend.getCurrentFunctions()).thenReturn(UsbManager.FUNCTION_MTP); when(mUsbBackend.getCurrentFunctions()).thenReturn(UsbManager.FUNCTION_MTP);
List<RadioButtonPreference> prefs = getRadioPreferences(); List<SelectorWithWidgetPreference> prefs = getRadioPreferences();
prefs.get(4).performClick(); prefs.get(4).performClick();
assertThat(prefs.get(4).getKey()) assertThat(prefs.get(4).getKey())
@@ -244,10 +244,10 @@ public class UsbDetailsFunctionsControllerTest {
assertThat(mDetailsFunctionsController.isAvailable()).isFalse(); assertThat(mDetailsFunctionsController.isAvailable()).isFalse();
} }
private List<RadioButtonPreference> getRadioPreferences() { private List<SelectorWithWidgetPreference> getRadioPreferences() {
ArrayList<RadioButtonPreference> result = new ArrayList<>(); ArrayList<SelectorWithWidgetPreference> result = new ArrayList<>();
for (int i = 0; i < mPreferenceCategory.getPreferenceCount(); i++) { for (int i = 0; i < mPreferenceCategory.getPreferenceCount(); i++) {
result.add((RadioButtonPreference) mPreferenceCategory.getPreference(i)); result.add((SelectorWithWidgetPreference) mPreferenceCategory.getPreference(i));
} }
return result; return result;
} }

View File

@@ -62,7 +62,7 @@ import com.android.settingslib.core.instrumentation.MetricsFeatureProvider;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.FooterPreference; import com.android.settingslib.widget.FooterPreference;
import com.android.settingslib.widget.LayoutPreference; import com.android.settingslib.widget.LayoutPreference;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.After; import org.junit.After;
import org.junit.Before; import org.junit.Before;
@@ -127,9 +127,9 @@ public class AdvancedPowerUsageDetailTest {
private Preference mForegroundPreference; private Preference mForegroundPreference;
private Preference mBackgroundPreference; private Preference mBackgroundPreference;
private FooterPreference mFooterPreference; private FooterPreference mFooterPreference;
private RadioButtonPreference mRestrictedPreference; private SelectorWithWidgetPreference mRestrictedPreference;
private RadioButtonPreference mOptimizePreference; private SelectorWithWidgetPreference mOptimizePreference;
private RadioButtonPreference mUnrestrictedPreference; private SelectorWithWidgetPreference mUnrestrictedPreference;
private AdvancedPowerUsageDetail mFragment; private AdvancedPowerUsageDetail mFragment;
private SettingsActivity mTestActivity; private SettingsActivity mTestActivity;
private FakeFeatureFactory mFeatureFactory; private FakeFeatureFactory mFeatureFactory;
@@ -208,9 +208,9 @@ public class AdvancedPowerUsageDetailTest {
mForegroundPreference = new Preference(mContext); mForegroundPreference = new Preference(mContext);
mBackgroundPreference = new Preference(mContext); mBackgroundPreference = new Preference(mContext);
mFooterPreference = new FooterPreference(mContext); mFooterPreference = new FooterPreference(mContext);
mRestrictedPreference = new RadioButtonPreference(mContext); mRestrictedPreference = new SelectorWithWidgetPreference(mContext);
mOptimizePreference = new RadioButtonPreference(mContext); mOptimizePreference = new SelectorWithWidgetPreference(mContext);
mUnrestrictedPreference = new RadioButtonPreference(mContext); mUnrestrictedPreference = new SelectorWithWidgetPreference(mContext);
mFragment.mForegroundPreference = mForegroundPreference; mFragment.mForegroundPreference = mForegroundPreference;
mFragment.mBackgroundPreference = mBackgroundPreference; mFragment.mBackgroundPreference = mBackgroundPreference;
mFragment.mFooterPreference = mFooterPreference; mFragment.mFooterPreference = mFooterPreference;

View File

@@ -22,7 +22,7 @@ import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyZeroInteractions; import static org.mockito.Mockito.verifyZeroInteractions;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -38,7 +38,7 @@ public class OptimizedPreferenceControllerTest {
private static final String PACKAGE_NAME = "com.android.app"; private static final String PACKAGE_NAME = "com.android.app";
private OptimizedPreferenceController mController; private OptimizedPreferenceController mController;
private RadioButtonPreference mPreference; private SelectorWithWidgetPreference mPreference;
@Mock BatteryOptimizeUtils mockBatteryOptimizeUtils; @Mock BatteryOptimizeUtils mockBatteryOptimizeUtils;
@@ -48,7 +48,7 @@ public class OptimizedPreferenceControllerTest {
mController = new OptimizedPreferenceController( mController = new OptimizedPreferenceController(
RuntimeEnvironment.application, UID, PACKAGE_NAME); RuntimeEnvironment.application, UID, PACKAGE_NAME);
mPreference = new RadioButtonPreference(RuntimeEnvironment.application); mPreference = new SelectorWithWidgetPreference(RuntimeEnvironment.application);
mController.mBatteryOptimizeUtils = mockBatteryOptimizeUtils; mController.mBatteryOptimizeUtils = mockBatteryOptimizeUtils;
} }

View File

@@ -22,7 +22,7 @@ import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyZeroInteractions; import static org.mockito.Mockito.verifyZeroInteractions;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -38,7 +38,7 @@ public class RestrictedPreferenceControllerTest {
private static final String PACKAGE_NAME = "com.android.app"; private static final String PACKAGE_NAME = "com.android.app";
private RestrictedPreferenceController mController; private RestrictedPreferenceController mController;
private RadioButtonPreference mPreference; private SelectorWithWidgetPreference mPreference;
@Mock BatteryOptimizeUtils mockBatteryOptimizeUtils; @Mock BatteryOptimizeUtils mockBatteryOptimizeUtils;
@@ -48,7 +48,7 @@ public class RestrictedPreferenceControllerTest {
mController = new RestrictedPreferenceController( mController = new RestrictedPreferenceController(
RuntimeEnvironment.application, UID, PACKAGE_NAME); RuntimeEnvironment.application, UID, PACKAGE_NAME);
mPreference = new RadioButtonPreference(RuntimeEnvironment.application); mPreference = new SelectorWithWidgetPreference(RuntimeEnvironment.application);
mController.mBatteryOptimizeUtils = mockBatteryOptimizeUtils; mController.mBatteryOptimizeUtils = mockBatteryOptimizeUtils;
} }

View File

@@ -23,7 +23,7 @@ import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyZeroInteractions; import static org.mockito.Mockito.verifyZeroInteractions;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -39,7 +39,7 @@ public class UnrestrictedPreferenceControllerTest {
private static final String PACKAGE_NAME = "com.android.app"; private static final String PACKAGE_NAME = "com.android.app";
private UnrestrictedPreferenceController mController; private UnrestrictedPreferenceController mController;
private RadioButtonPreference mPreference; private SelectorWithWidgetPreference mPreference;
@Mock BatteryOptimizeUtils mockBatteryOptimizeUtils; @Mock BatteryOptimizeUtils mockBatteryOptimizeUtils;
@@ -49,7 +49,7 @@ public class UnrestrictedPreferenceControllerTest {
mController = new UnrestrictedPreferenceController( mController = new UnrestrictedPreferenceController(
RuntimeEnvironment.application, UID, PACKAGE_NAME); RuntimeEnvironment.application, UID, PACKAGE_NAME);
mPreference = new RadioButtonPreference(RuntimeEnvironment.application); mPreference = new SelectorWithWidgetPreference(RuntimeEnvironment.application);
mController.mBatteryOptimizeUtils = mockBatteryOptimizeUtils; mController.mBatteryOptimizeUtils = mockBatteryOptimizeUtils;
} }

View File

@@ -23,7 +23,7 @@ import android.os.SystemProperties;
import android.os.UserHandle; import android.os.UserHandle;
import com.android.settings.core.BasePreferenceController; import com.android.settings.core.BasePreferenceController;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -39,14 +39,14 @@ public class OneHandedActionPullDownPrefControllerTest {
private Context mContext; private Context mContext;
private OneHandedSettingsUtils mUtils; private OneHandedSettingsUtils mUtils;
private OneHandedActionPullDownPrefController mController; private OneHandedActionPullDownPrefController mController;
private RadioButtonPreference mPreference; private SelectorWithWidgetPreference mPreference;
@Before @Before
public void setUp() { public void setUp() {
mContext = RuntimeEnvironment.application; mContext = RuntimeEnvironment.application;
mUtils = new OneHandedSettingsUtils(mContext); mUtils = new OneHandedSettingsUtils(mContext);
mController = new OneHandedActionPullDownPrefController(mContext, KEY); mController = new OneHandedActionPullDownPrefController(mContext, KEY);
mPreference = new RadioButtonPreference(mContext); mPreference = new SelectorWithWidgetPreference(mContext);
OneHandedSettingsUtils.setUserId(UserHandle.myUserId()); OneHandedSettingsUtils.setUserId(UserHandle.myUserId());
} }

View File

@@ -23,7 +23,7 @@ import android.os.SystemProperties;
import android.os.UserHandle; import android.os.UserHandle;
import com.android.settings.core.BasePreferenceController; import com.android.settings.core.BasePreferenceController;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -39,14 +39,14 @@ public class OneHandedActionShowNotificationPrefControllerTest {
private Context mContext; private Context mContext;
private OneHandedSettingsUtils mUtils; private OneHandedSettingsUtils mUtils;
private OneHandedActionShowNotificationPrefController mController; private OneHandedActionShowNotificationPrefController mController;
private RadioButtonPreference mPreference; private SelectorWithWidgetPreference mPreference;
@Before @Before
public void setUp() { public void setUp() {
mContext = RuntimeEnvironment.application; mContext = RuntimeEnvironment.application;
mUtils = new OneHandedSettingsUtils(mContext); mUtils = new OneHandedSettingsUtils(mContext);
mController = new OneHandedActionShowNotificationPrefController(mContext, KEY); mController = new OneHandedActionShowNotificationPrefController(mContext, KEY);
mPreference = new RadioButtonPreference(mContext); mPreference = new SelectorWithWidgetPreference(mContext);
OneHandedSettingsUtils.setUserId(UserHandle.myUserId()); OneHandedSettingsUtils.setUserId(UserHandle.myUserId());
} }

View File

@@ -29,7 +29,7 @@ import android.provider.Settings;
import androidx.preference.Preference; import androidx.preference.Preference;
import androidx.preference.PreferenceCategory; import androidx.preference.PreferenceCategory;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -58,8 +58,8 @@ public class PreventRingingGesturePreferenceControllerTest {
.thenReturn(true); .thenReturn(true);
mController = new PreventRingingGesturePreferenceController(mContext, null); mController = new PreventRingingGesturePreferenceController(mContext, null);
mController.mPreferenceCategory = new PreferenceCategory(mContext); mController.mPreferenceCategory = new PreferenceCategory(mContext);
mController.mVibratePref = new RadioButtonPreference(mContext); mController.mVibratePref = new SelectorWithWidgetPreference(mContext);
mController.mMutePref = new RadioButtonPreference(mContext); mController.mMutePref = new SelectorWithWidgetPreference(mContext);
} }
@Test @Test
@@ -122,7 +122,7 @@ public class PreventRingingGesturePreferenceControllerTest {
@Test @Test
public void testRadioButtonClicked_mute() { public void testRadioButtonClicked_mute() {
RadioButtonPreference rbPref = new RadioButtonPreference(mContext); SelectorWithWidgetPreference rbPref = new SelectorWithWidgetPreference(mContext);
rbPref.setKey(PreventRingingGesturePreferenceController.KEY_MUTE); rbPref.setKey(PreventRingingGesturePreferenceController.KEY_MUTE);
Settings.Secure.putInt(mContext.getContentResolver(), Settings.Secure.VOLUME_HUSH_GESTURE, Settings.Secure.putInt(mContext.getContentResolver(), Settings.Secure.VOLUME_HUSH_GESTURE,
@@ -136,7 +136,7 @@ public class PreventRingingGesturePreferenceControllerTest {
@Test @Test
public void testRadioButtonClicked_vibrate() { public void testRadioButtonClicked_vibrate() {
RadioButtonPreference rbPref = new RadioButtonPreference(mContext); SelectorWithWidgetPreference rbPref = new SelectorWithWidgetPreference(mContext);
rbPref.setKey(PreventRingingGesturePreferenceController.KEY_VIBRATE); rbPref.setKey(PreventRingingGesturePreferenceController.KEY_VIBRATE);
Settings.Secure.putInt(mContext.getContentResolver(), Settings.Secure.VOLUME_HUSH_GESTURE, Settings.Secure.putInt(mContext.getContentResolver(), Settings.Secure.VOLUME_HUSH_GESTURE,

View File

@@ -44,7 +44,7 @@ import androidx.preference.PreferenceScreen;
import com.android.settings.notification.NotificationBackend; import com.android.settings.notification.NotificationBackend;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -74,7 +74,7 @@ public class ZenModePriorityConversationsPreferenceControllerTest {
@Mock @Mock
private NotificationBackend mNotifBackend; private NotificationBackend mNotifBackend;
private List<RadioButtonPreference> mRadioButtonPreferences; private List<SelectorWithWidgetPreference> mSelectorWithWidgetPreferences;
private ContentResolver mContentResolver; private ContentResolver mContentResolver;
private Context mContext; private Context mContext;
@Before @Before
@@ -102,7 +102,7 @@ public class ZenModePriorityConversationsPreferenceControllerTest {
@Test @Test
public void clickAllConversations() { public void clickAllConversations() {
RadioButtonPreference allConversationsRb = getButton(KEY_ALL); SelectorWithWidgetPreference allConversationsRb = getButton(KEY_ALL);
allConversationsRb.onClick(); allConversationsRb.onClick();
verify(mZenBackend).saveConversationSenders(CONVERSATION_SENDERS_ANYONE); verify(mZenBackend).saveConversationSenders(CONVERSATION_SENDERS_ANYONE);
@@ -110,7 +110,7 @@ public class ZenModePriorityConversationsPreferenceControllerTest {
@Test @Test
public void clickImportantConversations() { public void clickImportantConversations() {
RadioButtonPreference importantConversationsRb = getButton(KEY_IMPORTANT); SelectorWithWidgetPreference importantConversationsRb = getButton(KEY_IMPORTANT);
importantConversationsRb.onClick(); importantConversationsRb.onClick();
verify(mZenBackend).saveConversationSenders(CONVERSATION_SENDERS_IMPORTANT); verify(mZenBackend).saveConversationSenders(CONVERSATION_SENDERS_IMPORTANT);
@@ -118,7 +118,7 @@ public class ZenModePriorityConversationsPreferenceControllerTest {
@Test @Test
public void clickNoConversations() { public void clickNoConversations() {
RadioButtonPreference noConversationsRb = getButton(KEY_NONE); SelectorWithWidgetPreference noConversationsRb = getButton(KEY_NONE);
noConversationsRb.onClick(); noConversationsRb.onClick();
verify(mZenBackend) verify(mZenBackend)
@@ -126,20 +126,20 @@ public class ZenModePriorityConversationsPreferenceControllerTest {
} }
private void captureRadioButtons() { private void captureRadioButtons() {
ArgumentCaptor<RadioButtonPreference> rbCaptor = ArgumentCaptor<SelectorWithWidgetPreference> rbCaptor =
ArgumentCaptor.forClass(RadioButtonPreference.class); ArgumentCaptor.forClass(SelectorWithWidgetPreference.class);
mController.displayPreference(mPreferenceScreen); mController.displayPreference(mPreferenceScreen);
// verifies 3 buttons were added // verifies 3 buttons were added
verify(mMockPrefCategory, times(3)).addPreference(rbCaptor.capture()); verify(mMockPrefCategory, times(3)).addPreference(rbCaptor.capture());
mRadioButtonPreferences = rbCaptor.getAllValues(); mSelectorWithWidgetPreferences = rbCaptor.getAllValues();
assertThat(mRadioButtonPreferences.size()).isEqualTo(3); assertThat(mSelectorWithWidgetPreferences.size()).isEqualTo(3);
reset(mMockPrefCategory); reset(mMockPrefCategory);
} }
private RadioButtonPreference getButton(String key) { private SelectorWithWidgetPreference getButton(String key) {
for (RadioButtonPreference pref : mRadioButtonPreferences) { for (SelectorWithWidgetPreference pref : mSelectorWithWidgetPreferences) {
if (key.equals(pref.getKey())) { if (key.equals(pref.getKey())) {
return pref; return pref;
} }

View File

@@ -46,7 +46,7 @@ import androidx.preference.PreferenceScreen;
import com.android.settings.notification.NotificationBackend; import com.android.settings.notification.NotificationBackend;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -76,7 +76,7 @@ public class ZenModePrioritySendersPreferenceControllerTest {
@Mock @Mock
private NotificationBackend mNotifBackend; private NotificationBackend mNotifBackend;
private List<RadioButtonPreference> mRadioButtonPreferences; private List<SelectorWithWidgetPreference> mSelectorWithWidgetPreferences;
private ContentResolver mContentResolver; private ContentResolver mContentResolver;
private Context mContext; private Context mContext;
@Before @Before
@@ -108,7 +108,7 @@ public class ZenModePrioritySendersPreferenceControllerTest {
when(mZenBackend.getPriorityMessageSenders()).thenReturn(PRIORITY_SENDERS_STARRED); when(mZenBackend.getPriorityMessageSenders()).thenReturn(PRIORITY_SENDERS_STARRED);
// WHEN user clicks the any senders option // WHEN user clicks the any senders option
RadioButtonPreference allSendersRb = getButton(KEY_ANY); SelectorWithWidgetPreference allSendersRb = getButton(KEY_ANY);
allSendersRb.onClick(); allSendersRb.onClick();
// THEN any senders gets saved as priority senders for messages // THEN any senders gets saved as priority senders for messages
@@ -121,7 +121,7 @@ public class ZenModePrioritySendersPreferenceControllerTest {
when(mZenBackend.getPriorityMessageSenders()).thenReturn(PRIORITY_SENDERS_ANY); when(mZenBackend.getPriorityMessageSenders()).thenReturn(PRIORITY_SENDERS_ANY);
// WHEN user clicks the starred contacts option // WHEN user clicks the starred contacts option
RadioButtonPreference starredRb = getButton(KEY_STARRED); SelectorWithWidgetPreference starredRb = getButton(KEY_STARRED);
starredRb.onClick(); starredRb.onClick();
// THEN starred contacts gets saved as priority senders for messages // THEN starred contacts gets saved as priority senders for messages
@@ -134,7 +134,7 @@ public class ZenModePrioritySendersPreferenceControllerTest {
when(mZenBackend.getPriorityMessageSenders()).thenReturn(PRIORITY_SENDERS_ANY); when(mZenBackend.getPriorityMessageSenders()).thenReturn(PRIORITY_SENDERS_ANY);
// WHEN user clicks the contacts only option // WHEN user clicks the contacts only option
RadioButtonPreference contactsRb = getButton(KEY_CONTACTS); SelectorWithWidgetPreference contactsRb = getButton(KEY_CONTACTS);
contactsRb.onClick(); contactsRb.onClick();
// THEN contacts gets saved as priority senders for messages // THEN contacts gets saved as priority senders for messages
@@ -147,7 +147,7 @@ public class ZenModePrioritySendersPreferenceControllerTest {
when(mZenBackend.getPriorityMessageSenders()).thenReturn(PRIORITY_SENDERS_ANY); when(mZenBackend.getPriorityMessageSenders()).thenReturn(PRIORITY_SENDERS_ANY);
// WHEN user clicks the no senders option // WHEN user clicks the no senders option
RadioButtonPreference noSenders = getButton(KEY_NONE); SelectorWithWidgetPreference noSenders = getButton(KEY_NONE);
noSenders.onClick(); noSenders.onClick();
// THEN no senders gets saved as priority senders for messages // THEN no senders gets saved as priority senders for messages
@@ -160,7 +160,7 @@ public class ZenModePrioritySendersPreferenceControllerTest {
when(mZenBackend.getPriorityMessageSenders()).thenReturn(PRIORITY_SENDERS_ANY); when(mZenBackend.getPriorityMessageSenders()).thenReturn(PRIORITY_SENDERS_ANY);
// WHEN user clicks the any senders option multiple times again // WHEN user clicks the any senders option multiple times again
RadioButtonPreference anySenders = getButton(KEY_ANY); SelectorWithWidgetPreference anySenders = getButton(KEY_ANY);
anySenders.onClick(); anySenders.onClick();
anySenders.onClick(); anySenders.onClick();
anySenders.onClick(); anySenders.onClick();
@@ -170,20 +170,20 @@ public class ZenModePrioritySendersPreferenceControllerTest {
} }
private void captureRadioButtons() { private void captureRadioButtons() {
ArgumentCaptor<RadioButtonPreference> rbCaptor = ArgumentCaptor<SelectorWithWidgetPreference> rbCaptor =
ArgumentCaptor.forClass(RadioButtonPreference.class); ArgumentCaptor.forClass(SelectorWithWidgetPreference.class);
mMessagesController.displayPreference(mPreferenceScreen); mMessagesController.displayPreference(mPreferenceScreen);
// verifies 4 buttons were added // verifies 4 buttons were added
verify(mMockPrefCategory, times(4)).addPreference(rbCaptor.capture()); verify(mMockPrefCategory, times(4)).addPreference(rbCaptor.capture());
mRadioButtonPreferences = rbCaptor.getAllValues(); mSelectorWithWidgetPreferences = rbCaptor.getAllValues();
assertThat(mRadioButtonPreferences.size()).isEqualTo(4); assertThat(mSelectorWithWidgetPreferences.size()).isEqualTo(4);
reset(mMockPrefCategory); reset(mMockPrefCategory);
} }
private RadioButtonPreference getButton(String key) { private SelectorWithWidgetPreference getButton(String key) {
for (RadioButtonPreference pref : mRadioButtonPreferences) { for (SelectorWithWidgetPreference pref : mSelectorWithWidgetPreferences) {
if (key.equals(pref.getKey())) { if (key.equals(pref.getKey())) {
return pref; return pref;
} }

View File

@@ -42,7 +42,7 @@ import androidx.preference.PreferenceScreen;
import com.android.settings.testutils.FakeFeatureFactory; import com.android.settings.testutils.FakeFeatureFactory;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -61,7 +61,7 @@ public class ZenModeVisEffectsAllPreferenceControllerTest {
@Mock @Mock
private ZenModeBackend mBackend; private ZenModeBackend mBackend;
@Mock @Mock
private RadioButtonPreference mPref; private SelectorWithWidgetPreference mPref;
private Context mContext; private Context mContext;
private FakeFeatureFactory mFeatureFactory; private FakeFeatureFactory mFeatureFactory;
@Mock @Mock

View File

@@ -40,7 +40,7 @@ import androidx.preference.PreferenceScreen;
import com.android.settings.testutils.FakeFeatureFactory; import com.android.settings.testutils.FakeFeatureFactory;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -59,7 +59,7 @@ public class ZenModeVisEffectsCustomPreferenceControllerTest {
@Mock @Mock
private ZenModeBackend mBackend; private ZenModeBackend mBackend;
@Mock @Mock
private RadioButtonPreference mPref; private SelectorWithWidgetPreference mPref;
private Context mContext; private Context mContext;
@Mock @Mock
private PreferenceScreen mScreen; private PreferenceScreen mScreen;

View File

@@ -42,7 +42,7 @@ import androidx.preference.PreferenceScreen;
import com.android.settings.testutils.FakeFeatureFactory; import com.android.settings.testutils.FakeFeatureFactory;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -61,7 +61,7 @@ public class ZenModeVisEffectsNonePreferenceControllerTest {
@Mock @Mock
private ZenModeBackend mBackend; private ZenModeBackend mBackend;
@Mock @Mock
private RadioButtonPreference mMockPref; private SelectorWithWidgetPreference mMockPref;
private Context mContext; private Context mContext;
private FakeFeatureFactory mFeatureFactory; private FakeFeatureFactory mFeatureFactory;
@Mock @Mock

View File

@@ -27,7 +27,7 @@ import android.service.notification.ZenPolicy;
import androidx.preference.PreferenceScreen; import androidx.preference.PreferenceScreen;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -48,7 +48,7 @@ public class ZenRuleCustomPolicyPreferenceControllerTest extends
@Mock @Mock
private NotificationManager mNotificationManager; private NotificationManager mNotificationManager;
@Mock @Mock
private RadioButtonPreference mMockPref; private SelectorWithWidgetPreference mMockPref;
@Mock @Mock
private PreferenceScreen mScreen; private PreferenceScreen mScreen;

View File

@@ -27,7 +27,7 @@ import android.service.notification.ZenPolicy;
import androidx.preference.PreferenceScreen; import androidx.preference.PreferenceScreen;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -48,7 +48,7 @@ public class ZenRuleDefaultPolicyPreferenceControllerTest extends
@Mock @Mock
private NotificationManager mNotificationManager; private NotificationManager mNotificationManager;
@Mock @Mock
private RadioButtonPreference mMockPref; private SelectorWithWidgetPreference mMockPref;
@Mock @Mock
private PreferenceScreen mScreen; private PreferenceScreen mScreen;

View File

@@ -29,7 +29,7 @@ import android.content.Context;
import androidx.preference.PreferenceScreen; import androidx.preference.PreferenceScreen;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -49,7 +49,7 @@ public class ZenRulePreferenceControllerTest {
@Mock @Mock
private NotificationManager mNotificationManager; private NotificationManager mNotificationManager;
@Mock @Mock
private RadioButtonPreference mMockPref; private SelectorWithWidgetPreference mMockPref;
@Mock @Mock
private PreferenceScreen mScreen; private PreferenceScreen mScreen;

View File

@@ -27,7 +27,7 @@ import android.service.notification.ZenPolicy;
import androidx.preference.PreferenceScreen; import androidx.preference.PreferenceScreen;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -48,7 +48,7 @@ public class ZenRuleVisEffectsAllPreferenceControllerTest extends
@Mock @Mock
private NotificationManager mNotificationManager; private NotificationManager mNotificationManager;
@Mock @Mock
private RadioButtonPreference mMockPref; private SelectorWithWidgetPreference mMockPref;
@Mock @Mock
private PreferenceScreen mScreen; private PreferenceScreen mScreen;

View File

@@ -27,7 +27,7 @@ import android.service.notification.ZenPolicy;
import androidx.preference.PreferenceScreen; import androidx.preference.PreferenceScreen;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -48,7 +48,7 @@ public class ZenRuleVisEffectsCustomPreferenceControllerTest extends
@Mock @Mock
private NotificationManager mNotificationManager; private NotificationManager mNotificationManager;
@Mock @Mock
private RadioButtonPreference mMockPref; private SelectorWithWidgetPreference mMockPref;
@Mock @Mock
private PreferenceScreen mScreen; private PreferenceScreen mScreen;

View File

@@ -27,7 +27,7 @@ import android.service.notification.ZenPolicy;
import androidx.preference.PreferenceScreen; import androidx.preference.PreferenceScreen;
import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.core.lifecycle.Lifecycle;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -48,7 +48,7 @@ public class ZenRuleVisEffectsNonePreferenceControllerTest extends
@Mock @Mock
private NotificationManager mNotificationManager; private NotificationManager mNotificationManager;
@Mock @Mock
private RadioButtonPreference mMockPref; private SelectorWithWidgetPreference mMockPref;
@Mock @Mock
private PreferenceScreen mScreen; private PreferenceScreen mScreen;

View File

@@ -43,7 +43,7 @@ import androidx.fragment.app.FragmentActivity;
import com.android.settingslib.applications.DefaultAppInfo; import com.android.settingslib.applications.DefaultAppInfo;
import com.android.settingslib.core.instrumentation.MetricsFeatureProvider; import com.android.settingslib.core.instrumentation.MetricsFeatureProvider;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.After; import org.junit.After;
import org.junit.Before; import org.junit.Before;
@@ -147,7 +147,7 @@ public class WebViewAppPickerTest {
mContext.getPackageManager(), mContext.getPackageManager(),
createApplicationInfo(PACKAGE_NAME), "disabled"); createApplicationInfo(PACKAGE_NAME), "disabled");
RadioButtonPreference preference = mock(RadioButtonPreference.class); SelectorWithWidgetPreference preference = mock(SelectorWithWidgetPreference.class);
mPicker.bindPreference(preference, PACKAGE_NAME, webviewAppInfo, null); mPicker.bindPreference(preference, PACKAGE_NAME, webviewAppInfo, null);
mPicker.bindPreferenceExtra(preference, PACKAGE_NAME, webviewAppInfo, null, null); mPicker.bindPreferenceExtra(preference, PACKAGE_NAME, webviewAppInfo, null, null);
verify(preference, times(1)).setEnabled(eq(false)); verify(preference, times(1)).setEnabled(eq(false));
@@ -161,7 +161,7 @@ public class WebViewAppPickerTest {
mContext.getPackageManager(), mContext.getPackageManager(),
createApplicationInfo(PACKAGE_NAME), disabledReason); createApplicationInfo(PACKAGE_NAME), disabledReason);
RadioButtonPreference preference = mock(RadioButtonPreference.class); SelectorWithWidgetPreference preference = mock(SelectorWithWidgetPreference.class);
mPicker.bindPreference(preference, PACKAGE_NAME, webviewAppInfo, null); mPicker.bindPreference(preference, PACKAGE_NAME, webviewAppInfo, null);
mPicker.bindPreferenceExtra(preference, PACKAGE_NAME, webviewAppInfo, null, null); mPicker.bindPreferenceExtra(preference, PACKAGE_NAME, webviewAppInfo, null, null);
verify(preference, times(1)).setEnabled(eq(true)); verify(preference, times(1)).setEnabled(eq(true));
@@ -175,7 +175,7 @@ public class WebViewAppPickerTest {
mContext.getPackageManager(), mContext.getPackageManager(),
createApplicationInfo(PACKAGE_NAME), disabledReason); createApplicationInfo(PACKAGE_NAME), disabledReason);
RadioButtonPreference preference = mock(RadioButtonPreference.class); SelectorWithWidgetPreference preference = mock(SelectorWithWidgetPreference.class);
mPicker.bindPreference(preference, PACKAGE_NAME, webviewAppInfo, null); mPicker.bindPreference(preference, PACKAGE_NAME, webviewAppInfo, null);
mPicker.bindPreferenceExtra(preference, PACKAGE_NAME, webviewAppInfo, null, null); mPicker.bindPreferenceExtra(preference, PACKAGE_NAME, webviewAppInfo, null, null);
verify(preference, times(1)).setSummary(eq(disabledReason)); verify(preference, times(1)).setSummary(eq(disabledReason));
@@ -189,7 +189,7 @@ public class WebViewAppPickerTest {
mContext.getPackageManager(), mContext.getPackageManager(),
createApplicationInfo(PACKAGE_NAME), null); createApplicationInfo(PACKAGE_NAME), null);
RadioButtonPreference preference = mock(RadioButtonPreference.class); SelectorWithWidgetPreference preference = mock(SelectorWithWidgetPreference.class);
mPicker.bindPreference(preference, PACKAGE_NAME, webviewAppInfo, null); mPicker.bindPreference(preference, PACKAGE_NAME, webviewAppInfo, null);
mPicker.bindPreferenceExtra(preference, PACKAGE_NAME, webviewAppInfo, null, null); mPicker.bindPreferenceExtra(preference, PACKAGE_NAME, webviewAppInfo, null, null);
verify(preference, never()).setSummary(any()); verify(preference, never()).setSummary(any());
@@ -314,7 +314,8 @@ public class WebViewAppPickerTest {
mContext.getPackageManager(), mContext.getPackageManager(),
createApplicationInfo(PACKAGE_NAME), "" /* disabledReason */); createApplicationInfo(PACKAGE_NAME), "" /* disabledReason */);
final RadioButtonPreference mockPreference = mock(RadioButtonPreference.class); final SelectorWithWidgetPreference mockPreference =
mock(SelectorWithWidgetPreference.class);
mPicker.bindPreference(mockPreference, PACKAGE_NAME, webviewAppInfo, null); mPicker.bindPreference(mockPreference, PACKAGE_NAME, webviewAppInfo, null);
mPicker.bindPreferenceExtra( mPicker.bindPreferenceExtra(
mockPreference, PACKAGE_NAME, webviewAppInfo, null, null); mockPreference, PACKAGE_NAME, webviewAppInfo, null, null);
@@ -339,7 +340,7 @@ public class WebViewAppPickerTest {
.thenReturn(Collections.singletonList(createApplicationInfo(PACKAGE_NAME))); .thenReturn(Collections.singletonList(createApplicationInfo(PACKAGE_NAME)));
when(mWvusWrapper.setWebViewProvider(eq(PACKAGE_NAME))).thenReturn(true); when(mWvusWrapper.setWebViewProvider(eq(PACKAGE_NAME))).thenReturn(true);
RadioButtonPreference defaultPackagePref = mock(RadioButtonPreference.class); SelectorWithWidgetPreference defaultPackagePref = mock(SelectorWithWidgetPreference.class);
when(defaultPackagePref.getKey()).thenReturn(PACKAGE_NAME); when(defaultPackagePref.getKey()).thenReturn(PACKAGE_NAME);
mPicker.onRadioButtonClicked(defaultPackagePref); mPicker.onRadioButtonClicked(defaultPackagePref);
@@ -353,7 +354,7 @@ public class WebViewAppPickerTest {
.thenReturn(Collections.singletonList(createApplicationInfo(PACKAGE_NAME))); .thenReturn(Collections.singletonList(createApplicationInfo(PACKAGE_NAME)));
when(mWvusWrapper.setWebViewProvider(eq(PACKAGE_NAME))).thenReturn(false); when(mWvusWrapper.setWebViewProvider(eq(PACKAGE_NAME))).thenReturn(false);
RadioButtonPreference defaultPackagePref = mock(RadioButtonPreference.class); SelectorWithWidgetPreference defaultPackagePref = mock(SelectorWithWidgetPreference.class);
when(defaultPackagePref.getKey()).thenReturn(PACKAGE_NAME); when(defaultPackagePref.getKey()).thenReturn(PACKAGE_NAME);
mPicker.onRadioButtonClicked(defaultPackagePref); mPicker.onRadioButtonClicked(defaultPackagePref);

View File

@@ -32,7 +32,7 @@ import androidx.preference.PreferenceScreen;
import com.android.settings.testutils.FakeFeatureFactory; import com.android.settings.testutils.FakeFeatureFactory;
import com.android.settingslib.applications.DefaultAppInfo; import com.android.settingslib.applications.DefaultAppInfo;
import com.android.settingslib.widget.RadioButtonPreference; import com.android.settingslib.widget.SelectorWithWidgetPreference;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
@@ -80,8 +80,8 @@ public class RadioButtonPickerFragmentTest {
@Test @Test
public void displaySingleOption_shouldSelectRadioButton() { public void displaySingleOption_shouldSelectRadioButton() {
final RadioButtonPreference pref = final SelectorWithWidgetPreference pref =
new RadioButtonPreference(RuntimeEnvironment.application); new SelectorWithWidgetPreference(RuntimeEnvironment.application);
when(mScreen.getPreferenceCount()).thenReturn(1); when(mScreen.getPreferenceCount()).thenReturn(1);
when(mScreen.getPreference(0)).thenReturn(pref); when(mScreen.getPreference(0)).thenReturn(pref);
@@ -92,8 +92,8 @@ public class RadioButtonPickerFragmentTest {
@Test @Test
public void clickPreference_shouldConfirm() { public void clickPreference_shouldConfirm() {
final RadioButtonPreference pref = final SelectorWithWidgetPreference pref =
new RadioButtonPreference(RuntimeEnvironment.application); new SelectorWithWidgetPreference(RuntimeEnvironment.application);
pref.setKey("TEST"); pref.setKey("TEST");
mFragment.onRadioButtonClicked(pref); mFragment.onRadioButtonClicked(pref);