PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Do not trigger card loader reloading upon screen rotation.

Browse Source 
Use the cached loaded results when it is not the first launch.

Fixes: 123941365
Test: robotests
Change-Id: Ib6de1142b12196e997a8c19122617e9215d23655
This commit is contained in:
Yi-Ling Chuang
2019-02-20 20:00:26 +08:00
parent 343b0211fe
commit 175a22c882
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/com/android/settings/homepage/contextualcards/ContextualCardManager.java
View File

@@ -108,7 +108,8 @@ public class ContextualCardManager implements ContextualCardLoader.CardContentLo
final CardContentLoaderCallbacks cardContentLoaderCallbacks = final CardContentLoaderCallbacks cardContentLoaderCallbacks =
new CardContentLoaderCallbacks(mContext); new CardContentLoaderCallbacks(mContext);
cardContentLoaderCallbacks.setListener(this); cardContentLoaderCallbacks.setListener(this);
LoaderManager.getInstance(fragment).restartLoader(CARD_CONTENT_LOADER_ID, null /* bundle */, // Use the cached data when navigating back to the first page and upon screen rotation.
LoaderManager.getInstance(fragment).initLoader(CARD_CONTENT_LOADER_ID, null /* bundle */,
cardContentLoaderCallbacks); cardContentLoaderCallbacks);
} }
@@ -192,7 +193,7 @@ public class ContextualCardManager implements ContextualCardLoader.CardContentLo
Log.d(TAG, "Total loading time = " + loadTime); Log.d(TAG, "Total loading time = " + loadTime);
final List<ContextualCard> cardsToKeep = getCardsToKeep(cards); final List<ContextualCard> cardsToKeep = getCardsToKeep(cards);
//navigate back to the homepage or after card dismissal //navigate back to the homepage, screen rotate or after card dismissal
if (!mIsFirstLaunch) { if (!mIsFirstLaunch) {
onContextualCardUpdated(cardsToKeep.stream() onContextualCardUpdated(cardsToKeep.stream()
.collect(groupingBy(ContextualCard::getCardType))); .collect(groupingBy(ContextualCard::getCardType)));