From 031cda05c33ba443e7fd6428dcb25b8c2a42fff1 Mon Sep 17 00:00:00 2001 From: Stanley Wang Date: Fri, 22 Apr 2022 10:36:43 +0800 Subject: [PATCH] Fixe the problem of invalid switch preference - SettingsMainSwithBar will be recreated after the page is resumed. We should keep the OnMainSwitchChangeListener for SettingsMainSwitchPreference and re-register the listeners after the page is resumed. Fix: 228930107 Fix: 222384287 Test: Manually test and see the UI Change-Id: I9b57053989e611288cf4814b2a0ecbf9e3c55145 --- .../android/settings/widget/SettingsMainSwitchPreference.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/com/android/settings/widget/SettingsMainSwitchPreference.java b/src/com/android/settings/widget/SettingsMainSwitchPreference.java index f1eb603a719..0e17d3f8e90 100644 --- a/src/com/android/settings/widget/SettingsMainSwitchPreference.java +++ b/src/com/android/settings/widget/SettingsMainSwitchPreference.java @@ -254,7 +254,5 @@ public class SettingsMainSwitchPreference extends TwoStatePreference implements for (OnMainSwitchChangeListener listener : mSwitchChangeListeners) { mMainSwitchBar.addOnSwitchChangeListener(listener); } - mBeforeCheckedChangeListeners.clear(); - mSwitchChangeListeners.clear(); } }