Sync lastest lifecycle interface
Bug: 142938506 Test: rebuild Change-Id: I6a8d75e5a3ba8564cfb400a88d6582c962c965ee
This commit is contained in:
@@ -31,7 +31,6 @@ import android.view.LayoutInflater;
|
|||||||
import android.view.View;
|
import android.view.View;
|
||||||
import android.view.ViewGroup;
|
import android.view.ViewGroup;
|
||||||
import android.view.accessibility.AccessibilityManager;
|
import android.view.accessibility.AccessibilityManager;
|
||||||
import android.widget.LinearLayout;
|
|
||||||
import android.widget.TextView;
|
import android.widget.TextView;
|
||||||
|
|
||||||
import androidx.appcompat.app.AlertDialog;
|
import androidx.appcompat.app.AlertDialog;
|
||||||
|
@@ -25,7 +25,6 @@ import androidx.appcompat.app.AlertDialog;
|
|||||||
|
|
||||||
import com.android.settings.R;
|
import com.android.settings.R;
|
||||||
import com.android.settings.core.instrumentation.InstrumentedDialogFragment;
|
import com.android.settings.core.instrumentation.InstrumentedDialogFragment;
|
||||||
import com.android.settings.notification.ZenAccessSettings;
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Warning dialog when allowing zen access warning about the privileges being granted.
|
* Warning dialog when allowing zen access warning about the privileges being granted.
|
||||||
|
@@ -93,7 +93,8 @@ public final class Utils {
|
|||||||
@VisibleForTesting
|
@VisibleForTesting
|
||||||
static void showConnectingError(Context context, String name, LocalBluetoothManager manager) {
|
static void showConnectingError(Context context, String name, LocalBluetoothManager manager) {
|
||||||
FeatureFactory.getFactory(context).getMetricsFeatureProvider().visible(context,
|
FeatureFactory.getFactory(context).getMetricsFeatureProvider().visible(context,
|
||||||
SettingsEnums.PAGE_UNKNOWN, SettingsEnums.ACTION_SETTINGS_BLUETOOTH_CONNECT_ERROR);
|
SettingsEnums.PAGE_UNKNOWN, SettingsEnums.ACTION_SETTINGS_BLUETOOTH_CONNECT_ERROR,
|
||||||
|
0);
|
||||||
showError(context, name, R.string.bluetooth_connecting_error_message, manager);
|
showError(context, name, R.string.bluetooth_connecting_error_message, manager);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@@ -47,8 +47,4 @@ public abstract class InstrumentedFragment extends ObservableFragment implements
|
|||||||
mVisibilityLoggerMixin.setSourceMetricsCategory(getActivity());
|
mVisibilityLoggerMixin.setSourceMetricsCategory(getActivity());
|
||||||
super.onResume();
|
super.onResume();
|
||||||
}
|
}
|
||||||
|
|
||||||
protected final VisibilityLoggerMixin getVisibilityLogger() {
|
|
||||||
return mVisibilityLoggerMixin;
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
@@ -91,10 +91,6 @@ public abstract class InstrumentedPreferenceFragment extends ObservablePreferenc
|
|||||||
return getPreferenceManager().getContext();
|
return getPreferenceManager().getContext();
|
||||||
}
|
}
|
||||||
|
|
||||||
protected final VisibilityLoggerMixin getVisibilityLogger() {
|
|
||||||
return mVisibilityLoggerMixin;
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Get the res id for static preference xml for this fragment.
|
* Get the res id for static preference xml for this fragment.
|
||||||
*/
|
*/
|
||||||
|
@@ -25,11 +25,11 @@ import com.android.settingslib.core.instrumentation.EventLogWriter;
|
|||||||
public class SettingsEventLogWriter extends EventLogWriter {
|
public class SettingsEventLogWriter extends EventLogWriter {
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public void visible(Context context, int source, int category) {
|
public void visible(Context context, int source, int category, int latency) {
|
||||||
if (shouldDisableGenericEventLogging()) {
|
if (shouldDisableGenericEventLogging()) {
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
super.visible(context, source, category);
|
super.visible(context, source, category, latency);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
|
@@ -61,12 +61,12 @@ public class SettingsIntelligenceLogWriter implements LogWriter {
|
|||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public void visible(Context context, int attribution, int pageId) {
|
public void visible(Context context, int attribution, int pageId, int latency) {
|
||||||
action(attribution /* attribution */,
|
action(attribution /* from pageId */,
|
||||||
SettingsEnums.PAGE_VISIBLE /* action */,
|
SettingsEnums.PAGE_VISIBLE /* action */,
|
||||||
pageId /* pageId */,
|
pageId /* target pageId */,
|
||||||
"" /* changedPreferenceKey */,
|
"" /* changedPreferenceKey */,
|
||||||
0 /* changedPreferenceIntValue */);
|
latency /* changedPreferenceIntValue */);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
|
@@ -26,13 +26,13 @@ import com.android.settingslib.core.instrumentation.LogWriter;
|
|||||||
public class StatsLogWriter implements LogWriter {
|
public class StatsLogWriter implements LogWriter {
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public void visible(Context context, int attribution, int pageId) {
|
public void visible(Context context, int attribution, int pageId, int latency) {
|
||||||
StatsLog.write(StatsLog.SETTINGS_UI_CHANGED /* Atom name */,
|
StatsLog.write(StatsLog.SETTINGS_UI_CHANGED /* Atom name */,
|
||||||
attribution,
|
attribution, /* from pageId */
|
||||||
SettingsEnums.PAGE_VISIBLE /* action */,
|
SettingsEnums.PAGE_VISIBLE /* action */,
|
||||||
pageId,
|
pageId, /* target pageId */
|
||||||
null /* changedPreferenceKey */,
|
null /* changedPreferenceKey */,
|
||||||
0 /* changedPreferenceIntValue */);
|
latency /* changedPreferenceIntValue */);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
|
@@ -65,7 +65,7 @@ public class ConditionContextualCardRenderer implements ContextualCardRenderer {
|
|||||||
mContext).getMetricsFeatureProvider();
|
mContext).getMetricsFeatureProvider();
|
||||||
|
|
||||||
metricsFeatureProvider.visible(mContext, SettingsEnums.SETTINGS_HOMEPAGE,
|
metricsFeatureProvider.visible(mContext, SettingsEnums.SETTINGS_HOMEPAGE,
|
||||||
card.getMetricsConstant());
|
card.getMetricsConstant(), 0);
|
||||||
initializePrimaryClick(view, card, metricsFeatureProvider);
|
initializePrimaryClick(view, card, metricsFeatureProvider);
|
||||||
initializeView(view, card);
|
initializeView(view, card);
|
||||||
initializeActionButton(view, card, metricsFeatureProvider);
|
initializeActionButton(view, card, metricsFeatureProvider);
|
||||||
|
@@ -15,8 +15,6 @@
|
|||||||
*/
|
*/
|
||||||
package com.android.settings.bluetooth;
|
package com.android.settings.bluetooth;
|
||||||
|
|
||||||
import static com.google.common.truth.Truth.assertThat;
|
|
||||||
|
|
||||||
import static org.mockito.ArgumentMatchers.anyInt;
|
import static org.mockito.ArgumentMatchers.anyInt;
|
||||||
import static org.mockito.ArgumentMatchers.anyString;
|
import static org.mockito.ArgumentMatchers.anyString;
|
||||||
import static org.mockito.ArgumentMatchers.eq;
|
import static org.mockito.ArgumentMatchers.eq;
|
||||||
@@ -24,7 +22,6 @@ import static org.mockito.Mockito.mock;
|
|||||||
import static org.mockito.Mockito.verify;
|
import static org.mockito.Mockito.verify;
|
||||||
import static org.mockito.Mockito.when;
|
import static org.mockito.Mockito.when;
|
||||||
|
|
||||||
import android.bluetooth.BluetoothDevice;
|
|
||||||
import android.content.Context;
|
import android.content.Context;
|
||||||
|
|
||||||
import com.android.internal.logging.nano.MetricsProto.MetricsEvent;
|
import com.android.internal.logging.nano.MetricsProto.MetricsEvent;
|
||||||
@@ -61,6 +58,6 @@ public class UtilsTest {
|
|||||||
Utils.showConnectingError(mContext, "testName", mock(LocalBluetoothManager.class));
|
Utils.showConnectingError(mContext, "testName", mock(LocalBluetoothManager.class));
|
||||||
|
|
||||||
verify(mMetricsFeatureProvider).visible(eq(mContext), anyInt(),
|
verify(mMetricsFeatureProvider).visible(eq(mContext), anyInt(),
|
||||||
eq(MetricsEvent.ACTION_SETTINGS_BLUETOOTH_CONNECT_ERROR));
|
eq(MetricsEvent.ACTION_SETTINGS_BLUETOOTH_CONNECT_ERROR), anyInt());
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@@ -62,7 +62,7 @@ public class SettingsEventLogWriterTest {
|
|||||||
SettingsUIDeviceConfig.GENERIC_EVENT_LOGGING_ENABLED, "true", true);
|
SettingsUIDeviceConfig.GENERIC_EVENT_LOGGING_ENABLED, "true", true);
|
||||||
|
|
||||||
mWriter.visible(RuntimeEnvironment.application, SettingsEnums.PAGE_UNKNOWN,
|
mWriter.visible(RuntimeEnvironment.application, SettingsEnums.PAGE_UNKNOWN,
|
||||||
SettingsEnums.SETTINGS_HOMEPAGE);
|
SettingsEnums.SETTINGS_HOMEPAGE, 0);
|
||||||
|
|
||||||
assertThat(ShadowMetricsLogger.sActionLoggedCount).isEqualTo(1);
|
assertThat(ShadowMetricsLogger.sActionLoggedCount).isEqualTo(1);
|
||||||
}
|
}
|
||||||
@@ -83,7 +83,7 @@ public class SettingsEventLogWriterTest {
|
|||||||
SettingsUIDeviceConfig.GENERIC_EVENT_LOGGING_ENABLED, "false", true);
|
SettingsUIDeviceConfig.GENERIC_EVENT_LOGGING_ENABLED, "false", true);
|
||||||
|
|
||||||
mWriter.visible(RuntimeEnvironment.application, SettingsEnums.PAGE_UNKNOWN,
|
mWriter.visible(RuntimeEnvironment.application, SettingsEnums.PAGE_UNKNOWN,
|
||||||
SettingsEnums.SETTINGS_HOMEPAGE);
|
SettingsEnums.SETTINGS_HOMEPAGE, 0);
|
||||||
|
|
||||||
assertThat(ShadowMetricsLogger.sActionLoggedCount).isEqualTo(0);
|
assertThat(ShadowMetricsLogger.sActionLoggedCount).isEqualTo(0);
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user