From 16809b1ad7262ee95d647b7655c4adf8cdeb75ab Mon Sep 17 00:00:00 2001 From: Adrian Roos Date: Fri, 5 Dec 2014 18:47:12 +0100 Subject: [PATCH] Fix race leading to spuriously disabled trust agents If TrustManagerService is able to refresh the trust agents before the Settings activity gets a chance to reenable the lock pattern, the TrustManagerService won't see a secure credential and won't load any agents. This was introduced when we switched to isSecure instead of getKeyguardStoredPasswordQuality. The latter ignored the lockPatternEnabled flag. Bug: 18596036 Change-Id: I2734899f7684916fc84bc3a07edca29310887103 --- src/com/android/settings/ChooseLockPattern.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/com/android/settings/ChooseLockPattern.java b/src/com/android/settings/ChooseLockPattern.java index 85694b1999e..837aefe0272 100644 --- a/src/com/android/settings/ChooseLockPattern.java +++ b/src/com/android/settings/ChooseLockPattern.java @@ -555,8 +555,8 @@ public class ChooseLockPattern extends SettingsActivity { final boolean required = getActivity().getIntent().getBooleanExtra( EncryptionInterstitial.EXTRA_REQUIRE_PASSWORD, true); utils.setCredentialRequiredToDecrypt(required); - utils.saveLockPattern(mChosenPattern, isFallback); utils.setLockPatternEnabled(true); + utils.saveLockPattern(mChosenPattern, isFallback); if (lockVirgin) { utils.setVisiblePatternEnabled(true);